From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.2501.1583782180128984742 for ; Mon, 09 Mar 2020 12:29:40 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=X+wAMXO9; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583782179; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EzvXrFG5nf3+UYDKVkil52x1Mjda7GhAXBvDfL2Ap3g=; b=X+wAMXO9OLLcUw5ayhIECKVxfs7znjD8z5VYjpwQ3Yvyv0Tm1ad3jKu3GL2iMk0O6qTN2w uD/a0NSAACv0RdJSC2lDI6YAj9N+occXchyJTALmez5UfNWpmT3tnF1MJhw2TI7Qu+Yy40 AEskUoFTcXDPmOeftnsPd4UGh2c3J2I= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-97-q-2E4s3WNoqX7_jGIxI44A-1; Mon, 09 Mar 2020 15:29:34 -0400 X-MC-Unique: q-2E4s3WNoqX7_jGIxI44A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 2E9B518B6380; Mon, 9 Mar 2020 19:29:33 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-76.ams2.redhat.com [10.36.116.76]) by smtp.corp.redhat.com (Postfix) with ESMTP id 797555C28D; Mon, 9 Mar 2020 19:29:31 +0000 (UTC) Subject: Re: [edk2-devel] EDK II Maintainers - EDK II CI is now active on edk2/master To: "Kinney, Michael D" , "devel@edk2.groups.io" , "sean.brogan@microsoft.com" , Bret Barkelew , "Gao, Liming" Cc: "Leif Lindholm (Nuvia address)" , Andrew Fish References: From: "Laszlo Ersek" Message-ID: <01473986-a0f7-6143-6f81-63611f1f6b00@redhat.com> Date: Mon, 9 Mar 2020 20:29:30 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Hi Mike, On 03/08/20 20:53, Kinney, Michael D wrote: > I added the @Mergifyio refresh to these PRs. > > This one was merged: > https://github.com/tianocore/edk2/pull/427 > > This one is failing PatchCheck with a missing Signed-off-by > https://github.com/tianocore/edk2/pull/430 > > This one needs to be rebased and resubmitted > https://github.com/tianocore/edk2/pull/428 Thanks for kicking mergify. I think maintainers should have permission to kick mergify (if they don't have that permission already). Otherwise, the automated merge-on-CI-pass is not actually automated, and we create a bottleneck in an otherwise distributed / asynchronous workflow. If only you can kick mergify, then any *valid* (CI-clean) pull request will potentially have to wait on you. Mergify kicking rights do not allow maintainers to bypass CI checks, if I understand correctly. (Unlike direct merge / repository write access.) BTW I didn't even know about this mergify "command". Is there a guide somewhere? I honestly feel this should have been handled / introduced more transparently. I rarely feel as powerless as with PR#428. CI passed, the PR was stuck, github didn't respond to my ticket, mergify.io didn't respond to my ticket, and the PR was actually urgent (fixing a build breakage). I was sitting there uncomfortably as one of the stewards, unable to fix the situation. Earlier all this would take was a git-push command. Thanks Laszlo