From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 1036D74003D for ; Tue, 30 Apr 2024 01:57:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=XZTLKIkiGDV9EHbGbYfEnhT5GYwTIDpLU0Mb7Amj2Nk=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20240206; t=1714442263; v=1; b=CNp8K/VcxuRJIsLHfzHCa1NpEc5+L8Eb8gGNAVijBfLc6vTPL6V/4Udsd08Ltnr+thzW9G7J xCbLeJCCwqoOnMDAYDq5O+Dm1hXgKeBWQD/tuBzGdDLVZDmnSV+cSYzJ929K47x1A/PinE79Ri6 Fog2OLF0KNj/qHNaTRUH2wQWKbKBoBjQpQYlJomPn17AV6N0PBXXg4JI4wce5CwwkY31pEtOHvb J44eTxdPVGQRgRjSmR6jqzCz+jvBbpaQ8xd+J49nEibs4+AK7JWwjQIDEs0NWwaGyQr8Bjy4XoY lXUgtK+6/u53hQ7YxGf6Op1d9ph5ujWifBc8FCwwLPlAA== X-Received: by 127.0.0.2 with SMTP id kjoOYY7687511xJku0oYTumB; Mon, 29 Apr 2024 18:57:43 -0700 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web10.5500.1714442261830969052 for ; Mon, 29 Apr 2024 18:57:42 -0700 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 0071CA32E023 for ; Tue, 30 Apr 2024 09:57:38 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id E482EA32DFD9 for ; Tue, 30 Apr 2024 09:57:38 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id DD095A32DFFB for ; Tue, 30 Apr 2024 09:57:35 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Tue, 30 Apr 2024 09:57:29 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , Cc: , , "'Felix Polyudov'" , "'Srinivasan Mani'" , "'Sundaresan S'" References: <20240422112609.2182-1-praveensankarn@ami.com> <20240422112609.2182-2-praveensankarn@ami.com> <01c001da9580$7ca91820$75fb4860$@byosoft.com.cn> <002401da99d0$32a3bdd0$97eb3970$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiDlm57lpI06IFtlZGsyLWRldmVsXSDlm57lpI06IFtQQVRDSCB2MiAxLzFdIFN1YmplY3Q6IFtQQVRDSF0gTWRlUGtnOkFkZGVkIG5ldyBTUENSIHRhYmxlIHN0dWN0dXJlIG1lbWJlcnMgYXMgaW4gUmV2NC4=?= Date: Tue, 30 Apr 2024 09:57:30 +0800 Message-ID: <014901da9aa1$c2d545a0$487fd0e0$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQGgytvHbrR0aQ0gU0dmAHge2FlXwAJuXqtZAlSpCbwB9mn0QwLn8O9uAa6YsoSxmSxWYA== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 29 Apr 2024 18:57:42 -0700 Resent-From: gaoliming@byosoft.com.cn Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: oJv4U0ARDb2j5yqDTOSi667Fx7686176AA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="CNp8K/Vc"; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Praveen: To be compatible, I would suggest to follow new ACPI version definition t= o add new structure for SPCR table version 4, and also need to define versi= on 4 macro.=20 =20 For example,=20 #define EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_REVISION_4 0x04 EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE_V4 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Praveen > Sankar N via groups.io > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B44=E6=9C=8829=E6=97=A5 = 18:58 > =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; devel@= edk2.groups.io > =E6=8A=84=E9=80=81: michael.d.kinney@intel.com; zhiguang.liu@intel.com; F= elix Polyudov > ; Srinivasan Mani ; Sundaresan S > > =E4=B8=BB=E9=A2=98: Re: =E5=9B=9E=E5=A4=8D: [edk2-devel] =E5=9B=9E=E5=A4= =8D: [PATCH v2 1/1] Subject: [PATCH] > MdePkg:Added new SPCR table stucture members as in Rev4. >=20 > Hi Liming, > We are updating the ACPI tables with newer revision released recent= ly > and SPCR table has its revision 4 upgradation. So, we updated the SPCR ta= ble > to revision 4, tested in our AMI BIOS environment and validated Windows > Server EMS functionality. >=20 > Thanks, > Praveen Sankar >=20 > -----Original Message----- > From: gaoliming > Sent: Monday, April 29, 2024 6:27 AM > To: devel@edk2.groups.io; Praveen Sankar N > Cc: michael.d.kinney@intel.com; zhiguang.liu@intel.com; Felix Polyudov > ; Srinivasan Mani ; Sundaresan S > > Subject: [EXTERNAL] =E5=9B=9E=E5=A4=8D: [edk2-devel] =E5=9B=9E=E5=A4=8D: = [PATCH v2 1/1] Subject: > [PATCH] MdePkg:Added new SPCR table stucture members as in Rev4. >=20 >=20 > **CAUTION: The e-mail below is from an external source. Please exercise > caution before opening attachments, clicking links, or following guidance= .** >=20 > Praveen: > I want to know what will happen if the platform doesn't make changes wi= th > the updated table. >=20 > According to its impact, we can make direction how and when to merge > this patch. >=20 > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =E4=BB=A3=E8=A1=A8 Praveen > Sankar N > > via groups.io > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B44=E6=9C=8826=E6=97= =A5 12:58 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: gaoliming ; deve= l@edk2.groups.io > > =E6=8A=84=E9=80=81: michael.d.kinney@intel.com; zhiguang.liu@intel.com;= Felix Polyudov > > ; Srinivasan Mani ; Sundaresan > S > > > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] =E5=9B=9E=E5=A4=8D: [PATCH v2 1/1]= Subject: [PATCH] > MdePkg:Added > > new SPCR table stucture members as in Rev4. > > > > Hi Liming, > > I am about to resubmit the patch with the changes in the files > > SpcrGenerator.c and Spcr.aslc which are consuming the SPCR structure > > from SerialPortConsoleRedirectionTable.h file and these files > > seemingly initializes the SPCR structure members. So please let me > > know about your opinion on this and I think you mean the incompatible > > change as these files are affected with the initial patch. > > > > Thanks, > > Praveen Sankar N > > > > -----Original Message----- > > From: gaoliming > > Sent: Tuesday, April 23, 2024 6:47 PM > > To: Praveen Sankar N ; devel@edk2.groups.io > > Cc: michael.d.kinney@intel.com; zhiguang.liu@intel.com; Felix Polyudov > > ; Srinivasan Mani ; Sundaresan > S > > > > Subject: [EXTERNAL] =E5=9B=9E=E5=A4=8D: [PATCH v2 1/1] Subject: [PATCH] > MdePkg:Added > > new SPCR table stucture members as in Rev4. > > > > > > **CAUTION: The e-mail below is from an external source. Please > > exercise caution before opening attachments, clicking links, or > > following guidance.** > > > > Seemly, this is an incompatible change. What's impact with this change? > > > > Thanks > > Liming > > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Praveen Sankar N > > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2024=E5=B9=B44=E6=9C=8822=E6=97= =A5 19:26 > > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > > =E6=8A=84=E9=80=81: michael.d.kinney@intel.com; gaoliming@byosoft.com= .cn; > > > zhiguang.liu@intel.com; Felix Polyudov ; Srinivasan > > > Mani ; Sundaresan S > > > =E4=B8=BB=E9=A2=98: [PATCH v2 1/1] Subject: [PATCH] MdePkg:Added new = SPCR table > > > stucture members as in Rev4. > > > > > > In SPCR table, 4 structure members have been added newly as per SPCR > > > table Rev4, which has to be added in > > > MdePkg/SerialPortConsoleRedirectionTable.h file. > > > > > > Signed-off-by: Praveen Sankar N praveensankarn@ami.com > > > Cc: michael.d.kinney@intel.com > > > Cc: gaoliming@byosoft.com.cn > > > Cc: zhiguang.liu@intel.com > > > Cc: Felixp@ami.com > > > Cc: srinivasanm@ami.com > > > Cc: sundaresans@ami.com > > > --- > > > .../IndustryStandard/SerialPortConsoleRedirectionTable.h | 6 > +++++- > > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > > > diff --git > > > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable. > > > h > > > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable. > > > h > > > index eb5ae28390..f0001ab137 100644 > > > --- > > > a/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable. > > > h > > > +++ > > > b/MdePkg/Include/IndustryStandard/SerialPortConsoleRedirectionTable. > > > h > > > @@ -47,7 +47,11 @@ typedef struct { > > > UINT8 > > PciFunctionNumber; > > > > > > UINT32 PciFlags; > > > > > > UINT8 PciSegment; > > > > > > - UINT32 Reserved3; > > > > > > + UINT32 > > UartClockFrequency; > > > > > > + UINT32 PreciseBaudRate; > > > > > > + UINT16 > > > NameSpaceStrLength; > > > > > > + UINT16 > > > NameSpaceStrOffset; > > > > > > + CHAR8 > > > NameSpaceString[0]; > > > > > > } EFI_ACPI_SERIAL_PORT_CONSOLE_REDIRECTION_TABLE; > > > > > > > > > > > > #pragma pack() > > > > > > -- > > > 2.38.1.windows.1 > > > -The information contained in this message may be confidential and > > > proprietary to American Megatrends (AMI). This communication is > > > intended > > to > > > be read only by the individual or entity to whom it is addressed or > > > by > > their > > > designee. If the reader of this message is not the intended > > > recipient, you > > are > > > on notice that any distribution of this message, in any form, is > > > strictly prohibited. Please promptly notify the sender by reply > > > e-mail or by > > telephone > > > at 770-246-8600, and then delete or destroy all copies of the > > transmission=3D > > > > > > -The information contained in this message may be confidential and > > proprietary to American Megatrends (AMI). This communication is > > intended to be read only by the individual or entity to whom it is > > addressed or by their designee. If the reader of this message is not > > the intended recipient, you are on notice that any distribution of > > this message, in any form, is strictly prohibited. Please promptly > > notify the sender by reply e-mail or by telephone at 770-246-8600, and = then > delete or destroy all copies of the transmission. > > > > > > > > >=20 >=20 >=20 > -The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intended = to > be read only by the individual or entity to whom it is addressed or by th= eir > designee. If the reader of this message is not the intended recipient, yo= u are > on notice that any distribution of this message, in any form, is strictly > prohibited. Please promptly notify the sender by reply e-mail or by telep= hone > at 770-246-8600, and then delete or destroy all copies of the transmissio= n. >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118399): https://edk2.groups.io/g/devel/message/118399 Mute This Topic: https://groups.io/mt/105814254/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-