From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web12.52007.1595843470982119267 for ; Mon, 27 Jul 2020 02:51:11 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=dKkxrKqF; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1595843470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jOilz6cFkFMe7omewVjQU/knRLVJBGLd0IwOjnlmw9Y=; b=dKkxrKqF273O/PGw94+fST8n/oAR+f14nq2Em8xxWQQzTy43U9gs5hllMHmcxRuVMUdNSs rR0JyE9TsU9Xl27C5BOGaRNhekhJPhB5POyMB4F2G/Kw4swufj7hK+6jMDrdI/lqNwEhcw 5RyAdMZ9Z3P/aahkip5QImO0zGTepsU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-200-pPWNEk6YN-qv1m9owvmSbg-1; Mon, 27 Jul 2020 05:51:02 -0400 X-MC-Unique: pPWNEk6YN-qv1m9owvmSbg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 18C2B800470; Mon, 27 Jul 2020 09:51:01 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-235.ams2.redhat.com [10.36.113.235]) by smtp.corp.redhat.com (Postfix) with ESMTP id 43B1760F96; Mon, 27 Jul 2020 09:50:56 +0000 (UTC) Subject: Re: [PATCH 10/15] OvmfPkg/OvmfPkg.ci.yaml: Add configuration for LicenseCheck To: "Zhang, Shenglei" , Rebecca Cran Cc: "devel@edk2.groups.io" , "Justen, Jordan L" , Ard Biesheuvel References: <20200720083709.17264-1-shenglei.zhang@intel.com> <20200720083709.17264-11-shenglei.zhang@intel.com> <6961878a-716a-e4d3-2b7e-34ca5c28ce9b@redhat.com> From: "Laszlo Ersek" Message-ID: <014b464b-0621-2ff9-a714-3ae8948510bf@redhat.com> Date: Mon, 27 Jul 2020 11:50:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 07/27/20 08:21, Zhang, Shenglei wrote: > Hi Laszlo, > > VbeShim.h is existing in edk2 now. This plugin only checks the patches to be checked in. > So there's no need to add existing files to this section. OK, thanks, we can always extend this stanza later, if needed. Rebecca: once this patch is upstream, please post a separate patch for listing "OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h" in "IgnoreFiles". Otherwise I won't be able to merge your patch at . Shenglei: I have a question regarding IgnoreFiles syntax. In "MdeModulePkg/MdeModulePkg.ci.yaml", there are two syntaxes: - The IgnoreFiles stanza for "CharEncodingCheck" uses pathnames that are relative to the *project* root: > ## options defined ci/Plugin/CharEncodingCheck > "CharEncodingCheck": { > "IgnoreFiles": [ > "MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/test/testc.c", > "MdeModulePkg/Universal/RegularExpressionDxe/oniguruma/windows/testc.c" > ] > }, - The IgnoreFiles stanza for "SpellCheck" uses pathnames that are relative to the *package* (not project) root: > "SpellCheck": { > ... > "IgnoreFiles": [ # use gitignore syntax to ignore errors in matching files > "Library/LzmaCustomDecompressLib/Sdk/DOC/*" > ], How do we know whether a particular check's IgnoreFiles stanza requires project-root-relative or package-root-relative pathnames? Thanks! Laszlo > Thanks, > Shenglei > >> -----Original Message----- >> From: Laszlo Ersek >> Sent: Tuesday, July 21, 2020 6:01 AM >> To: Zhang, Shenglei ; devel@edk2.groups.io >> Cc: Justen, Jordan L ; Ard Biesheuvel >> >> Subject: Re: [PATCH 10/15] OvmfPkg/OvmfPkg.ci.yaml: Add configuration for >> LicenseCheck >> >> On 07/20/20 10:37, Shenglei Zhang wrote: >>> Add configuration IgnoreFiles for package config files. >>> So users can rely on this to skip license conflict for >>> some generated files. >>> >>> Cc: Jordan Justen >>> Cc: Laszlo Ersek >>> Cc: Ard Biesheuvel >>> Signed-off-by: Shenglei Zhang >>> --- >>> OvmfPkg/OvmfPkg.ci.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/OvmfPkg/OvmfPkg.ci.yaml b/OvmfPkg/OvmfPkg.ci.yaml >>> index 98992f0429ff..ed342d7a3d08 100644 >>> --- a/OvmfPkg/OvmfPkg.ci.yaml >>> +++ b/OvmfPkg/OvmfPkg.ci.yaml >>> @@ -8,6 +8,10 @@ >>> # SPDX-License-Identifier: BSD-2-Clause-Patent >>> ## >>> { >>> + ## options defined .pytool/Plugin/LicenseCheck >>> + "LicenseCheck": { >>> + "IgnoreFiles": [] >>> + }, >>> ## options defined .pytool/Plugin/CompilerPlugin >>> "CompilerPlugin": { >>> "DscPath": "" # Don't support this test >>> >> >> Can you list the following file at once, please: >> >> OvmfPkg/QemuVideoDxe/VbeShim.h >> >> With that: >> >> Reviewed-by: Laszlo Ersek >> >> Thanks >> Laszlo >