From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8EC797803CD for ; Tue, 12 Dec 2023 15:09:36 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=F5v6bPEW6oE3ofD9IZqMU2c9VAdhgdTMhheERwucaz4=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702393775; v=1; b=ltrs+U0RIeKODGFYTy8sI+s1/0fpsdOAAL4UyIyZb8BDc2YUH03ixpiprefVUB0rkB/Cc4Si gA+treC61/mH5I5gUaK4DRayEBMkfTRQFChqb24LTVSlP++xQcT4o3EBwmTtQk/7RAKK8EFNr3B 2zMGU4Q+e9y2SBUet1VLruGE= X-Received: by 127.0.0.2 with SMTP id u3RWYY7687511xnYf3vu33pj; Tue, 12 Dec 2023 07:09:35 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web10.3947.1702393774384770687 for ; Tue, 12 Dec 2023 07:09:34 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-641-SCYxL7GLPHOp75_7iEH4zA-1; Tue, 12 Dec 2023 10:09:28 -0500 X-MC-Unique: SCYxL7GLPHOp75_7iEH4zA-1 X-Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id E842B280604E; Tue, 12 Dec 2023 15:09:27 +0000 (UTC) X-Received: from [10.39.192.120] (unknown [10.39.192.120]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B39B82026D6F; Tue, 12 Dec 2023 15:09:26 +0000 (UTC) Message-ID: <01567d33-c323-94eb-f320-cfd549f08826@redhat.com> Date: Tue, 12 Dec 2023 16:09:24 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [Patch V3 0/6] Create and consume a new gMpInformationHobGuid2 in UefiCpuPkg. To: "Tan, Dun" , "devel@edk2.groups.io" Cc: "Ni, Ray" , Ard Biesheuvel , "Kinney, Michael D" , Gerd Hoffmann References: <179ED2A497A4E732.16398@groups.io> From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ykZAa03GQBCKH6wPdxEio4Qjx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=ltrs+U0R; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 12/12/23 02:20, Tan, Dun wrote: > Hi Laszlo, >=20 > Thanks for your reply. Sorry that I didn't add you in the reviewer list f= rom the beginning of this patch series review. About the patch review, plea= se take your time. Also take care your body! >=20 > The patch set was reviewed-by Ray last week. So I think we can merge the = patch set first. You can ping me if you have any comments about this patch = set later. Right, I think you should just go ahead and merge the series with Ray's R-b at this time. Thanks! Laszlo >=20 > Thanks, > Dun >=20 > -----Original Message----- > From: Laszlo Ersek =20 > Sent: Monday, December 11, 2023 9:50 PM > To: Tan, Dun ; devel@edk2.groups.io > Cc: Ni, Ray ; Ard Biesheuvel ; Kinney,= Michael D ; Gerd Hoffmann > Subject: Re: [edk2-devel] [Patch V3 0/6] Create and consume a new gMpInfo= rmationHobGuid2 in UefiCpuPkg. >=20 > Hi Dun, >=20 > On 12/11/23 04:16, Tan, Dun wrote: >> Hi Laszlo, >> >> Previously I sent a patch set " Move gMpInformationHobGuid from Standalo= neMmPkg to UefiCpuPkg. " and thanks for your review. To solve the issue tha= t the maximum length of one HOB might not be enough when CPU count is 1-200= 0 or bigger and extend the HOB, we decide to create a new MpInfo2Hob in Uef= iCpuPkg in this patch set. Do you have any comments about the patch set? >> >> Thanks, >> Dun >=20 > A few days ago I made an effort to at least identify the newest patch set= s I should "sometime" review on edk2, including those that apparently super= seded older versions. Thus, although not with 100% certainty, I did deduce = the above "change of plan", i.e., that the movement of the existent info HO= B between packages would be superseded by a brand new HOB. However, all I c= ould do at the time was simply tagging the new version for review -- and th= at's where I stand now. >=20 > For reference, I have approx. 14+ patch sets tagged for review on edk2-de= vel -- these have accumulated due to my 2 weeks long sick leave. > I'm back to work for 4 days this week, but then I'll disappear again unti= l the end of the year. So, I think I had best declare "email bankruptcy". >=20 > Apologies for blocking you -- I had made some efforts to inform my co-mai= ntainers of my status meanwhile. So, please don't wait for my feedback at t= his time; I might catch up, if I'm lucky, but I probably won't be able to. = So if Ray is pleased with your patches, please go ahead and merge them. >=20 > I might make comments on smaller patches this week; rest assured that tha= t kind of "preference" is just practicality, not laziness. It feels hopeles= s for me to make a serious "dent" in reviewing any larger patch set this we= ek, so I'll try to spend review effort where it has a fleeting chance at en= abling actual progress. >=20 > Best regards, > Laszlo >=20 >=20 >> >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of duntan >> Sent: Friday, December 8, 2023 5:55 PM >> To: devel@edk2.groups.io >> Subject: [edk2-devel] [Patch V3 0/6] Create and consume a new gMpInforma= tionHobGuid2 in UefiCpuPkg. >> >> In the V3 patch set, >> In patch "UefiCpuPkg: Build MpInfo2HOB in CpuMpPei", the DEBUG message f= ormat is modified In patch "UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe",= remove unneccesary assert check. >> In patch "UefiCpuPkg: Avoid assuming only one smmbasehob", free allocate= d buffer when error returning case happen. >> >> Dun Tan (6): >> UefiCpuPkg: Create gMpInformationHobGuid2 in UefiCpuPkg >> UefiCpuPkg: Build MpInfo2HOB in CpuMpPei >> UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe >> UefiCpuPkg: Add a new field in MpInfo2 HOB >> UefiCpuPkg: Cache core type in MpInfo2 HOB >> UefiCpuPkg: Avoid assuming only one smmbasehob >> >> UefiCpuPkg/CpuMpPei/CpuMpPei.c | 146 ++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++ >> UefiCpuPkg/CpuMpPei/CpuMpPei.h | 6 +++++- >> UefiCpuPkg/CpuMpPei/CpuMpPei.inf | 3 ++- >> UefiCpuPkg/Include/Guid/MpInformation2.h | 58 ++++++++++++++++++++= ++++++++++++++++++++++++++++++++++++++ >> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 354 ++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++--------------------------= ---------------------------------- >> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 2 +- >> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 8 ++++---- >> UefiCpuPkg/UefiCpuPkg.dec | 3 +++ >> 8 files changed, 513 insertions(+), 67 deletions(-) create mode=20 >> 100644 UefiCpuPkg/Include/Guid/MpInformation2.h >> >> -- >> 2.31.1.windows.1 >> >> >> >>=20 >> >> >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112446): https://edk2.groups.io/g/devel/message/112446 Mute This Topic: https://groups.io/mt/103052268/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-