From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web10.838.1624496056970526834 for ; Wed, 23 Jun 2021 17:54:18 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 24 Jun 2021 08:54:06 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'manickavasakam karpagavinayagam'" , , , , , , References: <20210618153734.11983-1-manickavasakamk@ami.com> <008101d7663f$a0a85c40$e1f914c0$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0g5Zue5aSNOiBbZWRrMl1bUEFUQ0ggVjNdIE1kZVBrZyA6IEFkZCBJUE1JIE1hY3JvIGFuZCBTdHJ1Y3R1cmUgRGVmaW50aW9ucyB0byByZXNvbHZlIGJ1aWxkIGVycm9ycw==?= Date: Thu, 24 Jun 2021 08:54:06 +0800 Message-ID: <015701d76893$6faba4c0$4f02ee40$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKnQ/fofiCCKF3z1d0NqyaDwGwf0AHmU43KAORKmXOpbEmpMA== Content-Type: multipart/alternative; boundary="----=_NextPart_000_0158_01D768D6.7DD06B60" Content-Language: zh-cn ------=_NextPart_000_0158_01D768D6.7DD06B60 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable AbduL: This is same to the definition of UINT8 CompletionCode without bitfield. =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 AbduL Lateef =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B46=E6=9C=8823=E6=97=A5 1= 9:43 =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.com.c= n =E6=8A=84=E9=80=81: manickavasakam karpagavinayagam ; isaac.w.oram@intel.com; nathaniel.l.desimone@intel.com; Felixp@ami.com= ; Harikrishnad@ami.com; manishj@ami.com; zacharyb@ami.com =E4=B8=BB=E9=A2=98: Re: [edk2-devel] =E5=9B=9E=E5=A4=8D: [edk2][PATCH V3] = MdePkg : Add IPMI Macro and Structure Defintions to resolve build errors =20 whats the use of bitfield:8 for UINT8 variable type? +typedef struct { + UINT8 CompletionCode:8; +} IPMI_SET_BOOT_OPTIONS_RESPONSE; =20 Thanks AbduL =20 On Mon, Jun 21, 2021 at 7:19 AM gaoliming > wrote: Thanks for you update.=20 Reviewed-by: Liming Gao > Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: manickavasakam karpagavinayagam > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B46=E6=9C=8818=E6=97=A5= 23:38 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =20 > =E6=8A=84=E9=80=81: isaac.w.oram@intel.com ; nathaniel.l.desimone@intel.com = ; > Felixp@ami.com ; Harikrishnad@ami.com ; manishj@ami.com ; > zacharyb@ami.com ; manickavasakamk@ami.com ; > gaoliming@byosoft.com.cn =20 > =E4=B8=BB=E9=A2=98: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structu= re Defintions > to resolve build errors >=20 > Build error reported for missing structures > IPMI_SET_BOOT_OPTIONS_RESPONSE, > EFI_IPMI_MSG_GET_BMC_EXEC_RSP and > macros EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCE > D_UPDATE_MODE > when using > edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg >=20 > MdePkg : Rename IPMI Macro and Structure Defintions >=20 > Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB, > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to > IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT > IPMI_BMC_IN_FORCED_UPDATE_MODE >=20 > Notes: > V1 : > Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB, > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to > IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT > IPMI_BMC_IN_FORCED_UPDATE_MODE >=20 > V2: >=20 > Remove 0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch >=20 > V3: >=20 > Add Signed-off-by information >=20 > Signed-off-by: Manickavasakam Karpagavinayagam > > > --- > .../IndustryStandard/IpmiNetFnChassis.h | 4 ++++ > .../IndustryStandard/IpmiNetFnFirmware.h | 18 > ++++++++++++++++++ > 2 files changed, 22 insertions(+) >=20 > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > index 79db55523d..d7cdd3a865 100644 > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > @@ -186,6 +186,10 @@ typedef struct { > UINT8 ParameterData[0]; >=20 > } IPMI_SET_BOOT_OPTIONS_REQUEST; >=20 >=20 >=20 > +typedef struct { >=20 > + UINT8 CompletionCode:8; >=20 > +} IPMI_SET_BOOT_OPTIONS_RESPONSE; >=20 > + >=20 > // >=20 > // Definitions for Get System Boot options command >=20 > // >=20 > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > index 2d892dbd5a..c4cbe2349b 100644 > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > @@ -17,4 +17,22 @@ > // All Firmware commands and their structure definitions to follow here >=20 > // >=20 >=20 >=20 > +// --------------------------------------------------------------------------= -- ------------ >=20 > +// Definitions for Get BMC Execution Context >=20 > +// --------------------------------------------------------------------------= -- ------------ >=20 > +#define IPMI_GET_BMC_EXECUTION_CONTEXT 0x23 >=20 > + >=20 > +// >=20 > +// Constants and Structure definitions for "Get Device ID" command to > follow here >=20 > +// >=20 > +typedef struct { >=20 > + UINT8 CurrentExecutionContext; >=20 > + UINT8 PartitionPointer; >=20 > +} IPMI_MSG_GET_BMC_EXEC_RSP; >=20 > + >=20 > +// >=20 > +// Current Execution Context responses >=20 > +// >=20 > +#define IPMI_BMC_IN_FORCED_UPDATE_MODE 0x11 >=20 > + >=20 > #endif >=20 > -- > 2.25.0.windows.1 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intende= d > to be read only by the individual or entity to whom it is addressed or b= y their > designee. If the reader of this message is not the intended recipient, y= ou are > on notice that any distribution of this message, in any form, is strictl= y > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission. =20 --=20 Thanks and Regards Abdul Lateef Attar Bangalore ------=_NextPart_000_0158_01D768D6.7DD06B60 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

AbduL:

= =C2=A0This is same to the definition of UINT8 CompletionCode without bitfi= eld.

 

Thanks

<= span lang=3DEN-US style=3D'font-size:10.5pt;font-family:=E7=AD=89=E7=BA=BF'= >Liming

<= span style=3D'font-size:11.0pt;font-family:=E7=AD=89=E7=BA=BF'>=E5=8F=91=E4= = =BB=B6=E4=BA=BA: devel@edk2.groups.= io <devel@edk2.groups.io> =E4=BB=A3=E8=A1=A8 AbduL Lateef=
=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B46=E6=9C=8823=E6=97=A5 19:43
=E6=94=B6=E4=BB= =B6=E4=BA=BA: devel@edk2.= groups.io; gaoliming@byosoft.com.cn
=E6=8A=84=E9=80=81: manickavasakam karpagavinayagam = <manickavasakamk@ami.com>; isaac.w.oram@intel.com; nathaniel.l.desimo= ne@intel.com; Felixp@ami.com; Harikrishnad@ami.com; manishj@ami.com; zachar= yb@ami.com
=E4=B8=BB=E9=A2=98: Re: [edk2-devel] =E5=9B=9E=E5=A4=8D: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defintions to = resolve build errors

 

whats the use of bitfield:8 for UINT8 variable type= ?

+ty= pedef struct {
+ UINT8 CompletionCode:8;
+} IPMI_SET_BOOT_OPTI= ONS_RESPONSE;

 

Thanks<= o:p>

Ab= duL

 

On Mon, Jun 21, 2021 at 7:19 AM gaoliming = <gaoliming@byosoft.com.cn> wrote:

Thanks for you update.

Reviewed-by: Liming Gao <gaoliming@byosof= t.com.cn>

Thanks
Liming
> -----=E9=82=AE=E4= =BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91= =E4=BB=B6=E4=BA=BA: manickavasakam karpagavinayagam <= ;manickavasaka= mk@ami.com>
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B46=E6=9C=8818=E6=97=A5 23:38
> = = =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io
> =E6= = =8A=84=E9=80=81: isaac.w.oram@intel.com; nathaniel.l.desimone@intel.com;
> Felixp@ami.= com; Harikris= hnad@ami.com; mani= shj@ami.com;
> zacharyb@ami.com; manickavasakamk@ami.com;
> gaoliming@byosoft.com.cn
> <= /span>=E4=B8=BB=E9=A2=98: [edk2][PATCH V3] MdePkg : Add = IPMI Macro and Structure Defintions
> to resolve build errors
>=
> Build error reported for missing structures
> IPMI_SET_BOOT= _OPTIONS_RESPONSE,
> EFI_IPMI_MSG_GET_BMC_EXEC_RSP and
> macros= EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> EFI_FIRMWARE_BMC_IN_FULL_RU= NTIME/EFI_FIRMWARE_BMC_IN_FORCE
> D_UPDATE_MODE
> when using> edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg
&= gt;
> MdePkg : Rename IPMI Macro and Structure Defintions
> > Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB,
> EFI_FIRMWARE_GET_= BMC_EXECUTION_CONTEXT
> EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to
= > IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT
> IPMI= _BMC_IN_FORCED_UPDATE_MODE
>
> Notes:
> V1 :
> Ren= ame the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB,
> EFI_FIRMWARE_GET_BMC_EXECUT= ION_CONTEXT
> EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to
> IPMI_= MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT
> IPMI_BMC_IN_FO= RCED_UPDATE_MODE
>
> V2:
>
> Remove 0001-MdePkg-A= dd-IPMI-Macro-and-Structure-Defintions-to-re.patch
>
> V3:
= >
> Add Signed-off-by information
>
> Signed-off-by:= Manickavasakam Karpagavinayagam
> <manickavasakamk@ami.com>
> ---<= br>>  .../IndustryStandard/IpmiNetFnChassis.h      &= nbsp; |  4 ++++
>  .../IndustryStandard/IpmiNetFnFirmware.h=        | 18
> ++++++++++++++++++
>  2 = files changed, 22 insertions(+)
>
> diff --git a/MdePkg/Includ= e/IndustryStandard/IpmiNetFnChassis.h
> b/MdePkg/Include/IndustryStan= dard/IpmiNetFnChassis.h
> index 79db55523d..d7cdd3a865 100644
>= --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
> +++ b/Mde= Pkg/Include/IndustryStandard/IpmiNetFnChassis.h
> @@ -186,6 +186,10 @= @ typedef struct {
>    UINT8        &n= bsp;                     =     ParameterData[0];
>
>  } IPMI_SET_BOOT_OPTI= ONS_REQUEST;
>
>
>
> +typedef struct {
> <= br>> +  UINT8   CompletionCode:8;
>
> +} IPM= I_SET_BOOT_OPTIONS_RESPONSE;
>
> +
>
>  //>
>  //  Definitions for Get System Boot options comm= and
>
>  //
>
> diff --git a/MdePkg/Include/= IndustryStandard/IpmiNetFnFirmware.h
> b/MdePkg/Include/IndustryStand= ard/IpmiNetFnFirmware.h
> index 2d892dbd5a..c4cbe2349b 100644
>= --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> +++ b/Md= ePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
> @@ -17,4 +17,22 @= @
>  // All Firmware commands and their structure definitions to= follow here
>
>  //
>
>
>
> += //
---------------------------------------------------------------------= -------
------------
>
> +//    Definitions for G= et BMC Execution Context
>
> +//
--------------------------= --------------------------------------------------
------------
> =
> +#define IPMI_GET_BMC_EXECUTION_CONTEXT  0x23
>
>= ; +
>
> +//
>
> +//  Constants and Structure= definitions for "Get Device ID" command to
> follow here>
> +//
>
> +typedef struct {
>
> +&n= bsp; UINT8   CurrentExecutionContext;
>
> +  UI= NT8   PartitionPointer;
>
> +} IPMI_MSG_GET_BMC_EXEC= _RSP;
>
> +
>
> +//
>
> +// Current = Execution Context responses
>
> +//
>
> +#define = IPMI_BMC_IN_FORCED_UPDATE_MODE  0x11
>
> +
>
&g= t;  #endif
>
> --
> 2.25.0.windows.1
>
&g= t;
> Please consider the environment before printing this email.
= >
> The information contained in this message may be confidential= and
> proprietary to American Megatrends (AMI).  This communica= tion is intended
> to be read only by the individual or entity to who= m it is addressed or by
their
> designee. If the reader of this me= ssage is not the intended recipient, you
are
> on notice that any = distribution of this message, in any form, is strictly
> prohibited.&= nbsp; Please promptly notify the sender by reply e-mail or by
> telep= hone at 770-246-8600, and then delete or destroy all copies of the
> = transmission.







<= /span>

 

-- =

Thanks and Regards
Abdu= l Lateef Attar
Bangalore

------=_NextPart_000_0158_01D768D6.7DD06B60--