From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web11.1187.1624498206939255821 for ; Wed, 23 Jun 2021 18:30:07 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 24 Jun 2021 09:30:03 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Xue, Shengfeng'" , "'Wang, Jian J'" Cc: "'Xue, ShengfengX'" References: <4a939b6b9a46a1b498931dd1ceb1bc62c4832ef9.1622805260.git.xueshengfeng@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIVjJdIENyeXB0b1BrZy9CYXNlQ3J5cHRMaWI6IEVuYWJsZWQgQ3J5cHRTaGE1MTIgZm9yIFNtbS9SdW50aW1lIGRyaXZlcnM=?= Date: Thu, 24 Jun 2021 09:30:04 +0800 Message-ID: <016801d76898$75cbd7d0$61638770$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQIG9Ua3ls7wOlxcbGl7DnoHputC/ADDeYkXqr0qYCA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn So far, there is no objection for this patch. How about merge it?=20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA= =B1=ED Yao, Jiewen > =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA6=D4=C29=C8=D5 11:08 > =CA=D5=BC=FE=C8=CB: Xue, Shengfeng ; > devel@edk2.groups.io; Wang, Jian J > =B3=AD=CB=CD: Xue, ShengfengX > =D6=F7=CC=E2: Re: [edk2-devel] [PATCHV2] CryptoPkg/BaseCryptLib: Enabled > CryptSha512 for Smm/Runtime drivers >=20 > Thank you! Shengfeng >=20 > Reviewed-by: Jiewen Yao >=20 > I recommend to wait for *1 week*, to see if anyone has concern on size > change. >=20 > Thank you > Yao Jiewen >=20 >=20 > > -----Original Message----- > > From: xueshengfeng > > Sent: Tuesday, June 8, 2021 12:31 PM > > To: devel@edk2.groups.io; Yao, Jiewen ; Wang, > Jian J > > > > Cc: Xue, ShengfengX > > Subject: [PATCHV2] CryptoPkg/BaseCryptLib: Enabled CryptSha512 for > > Smm/Runtime drivers > > > > Intel Platform utility Syscfg/sysfwupdt will trigger SMI > > to enter BIOS interface. then BIOS invoke EncodePassword > > in SMM mode to check password. > > it's need sha384(in CryptSha512.c) in SMM mode. > > > > the origin SmmCryptLib.lib size is 1389KB, > > after changed, the size is 1391KB. > > > > the origin RuntimeCryptLib.lib size is 911KB, > > after changed,the size is 913KB. > > > > in SmmCryptLib.inf and RuntimeCryptLib.inf, > > change CryptSha512NULL.c to CryptSha512.c. > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=3D3423 > > > > Signed-off-by: xueshengfeng > > --- > > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 6 +++--- > > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 4 ++-- > > 2 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > > b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > > index 3d3a6fb94a..fdbb6edfd2 100644 > > --- a/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > > +++ b/CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > > @@ -11,8 +11,8 @@ > > # functions, PKCS#7 SignedData sign functions, Diffie-Hellman functions, > and > > # authenticode signature verification functions are not supported in this > > instance. > > # > > -# Copyright (c) 2009 - 2020, Intel Corporation. All rights reserved.
> > -# Copyright (c) 2020, Hewlett Packard Enterprise Development LP. All > rights > > reserved.
> > +# Copyright (c) 2009 - 2021, Intel Corporation. All rights reserved.
> > +# Copyright (c) 2021, Hewlett Packard Enterprise Development LP. All > rights > > reserved.
> > # SPDX-License-Identifier: BSD-2-Clause-Patent > > # > > ## > > @@ -39,7 +39,7 @@ > > Hash/CryptSha1.c > > Hash/CryptSha256.c > > Hash/CryptSm3.c > > - Hash/CryptSha512Null.c > > + Hash/CryptSha512.c > > Hmac/CryptHmacSha256.c > > Kdf/CryptHkdf.c > > Cipher/CryptAes.c > > diff --git a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > index 07c376ce04..e6470d7a21 100644 > > --- a/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > +++ b/CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf > > @@ -10,7 +10,7 @@ > > # RSA external functions, PKCS#7 SignedData sign functions, > Diffie-Hellman > > functions, and > > # authenticode signature verification functions are not supported in this > > instance. > > # > > -# Copyright (c) 2010 - 2020, Intel Corporation. All rights reserved.
> > +# Copyright (c) 2010 - 2021, Intel Corporation. All rights reserved.
> > # SPDX-License-Identifier: BSD-2-Clause-Patent > > # > > ## > > @@ -37,7 +37,7 @@ > > Hash/CryptSha1.c > > Hash/CryptSha256.c > > Hash/CryptSm3.c > > - Hash/CryptSha512Null.c > > + Hash/CryptSha512.c > > Hmac/CryptHmacSha256.c > > Kdf/CryptHkdfNull.c > > Cipher/CryptAes.c > > -- > > 2.31.1.windows.1 > > >=20 >=20 >=20 >=20 >=20