From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <Pierre.Gondois@arm.com>, <devel@edk2.groups.io>,
"'Sean Brogan'" <sean.brogan@microsoft.com>,
"'Bret Barkelew'" <Bret.Barkelew@microsoft.com>,
"'Michael D Kinney'" <michael.d.kinney@intel.com>,
"'Sami Mujawar'" <sami.mujawar@arm.com>
Subject: 回复: [PATCH v1 4/4] .pytool/EccCheck: Set PACKAGES_PATH env var in Ecc
Date: Thu, 24 Jun 2021 09:52:22 +0800 [thread overview]
Message-ID: <016d01d7689b$935611f0$ba0235d0$@byosoft.com.cn> (raw)
In-Reply-To: <20210623072250.3277-5-Pierre.Gondois@arm.com>
Pierre:
> -----邮件原件-----
> 发件人: Pierre.Gondois@arm.com <Pierre.Gondois@arm.com>
> 发送时间: 2021年6月23日 15:23
> 收件人: devel@edk2.groups.io; Sean Brogan <sean.brogan@microsoft.com>;
> Bret Barkelew <Bret.Barkelew@microsoft.com>; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Sami Mujawar <sami.mujawar@arm.com>
> 主题: [PATCH v1 4/4] .pytool/EccCheck: Set PACKAGES_PATH env var in Ecc
>
> From: Pierre Gondois <Pierre.Gondois@arm.com>
>
> When running Ecc on other repositories (e.g.: edk2-platforms with
> edk2 as a submodule), edk2 modules are referenced.
> E.g.: MdePkg/..
> The PACKAGES_PATH env var can be used to reference other directories
> containing packages. Set it so that Ecc can find these packages.
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
> .pytool/Plugin/EccCheck/EccCheck.py | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/.pytool/Plugin/EccCheck/EccCheck.py
> b/.pytool/Plugin/EccCheck/EccCheck.py
> index 87f0e65a140f..49d143b32f91 100644
> --- a/.pytool/Plugin/EccCheck/EccCheck.py
> +++ b/.pytool/Plugin/EccCheck/EccCheck.py
> @@ -67,6 +67,7 @@ class EccCheck(ICiBuildPlugin):
> env = shell_environment.GetEnvironment()
> env.set_shell_var('PYTHONPATH', python_path)
> env.set_shell_var('WORKSPACE', workspace_path)
> + env.set_shell_var('PACKAGES_PATH',
> ":".join(Edk2pathObj.PackagePathList))
":" is Linux OS path separator. Windows OS path separator is ";".
Thanks
Liming
> self.ECC_PASS = True
> self.ApplyConfig(pkgconfig, workspace_path, basetools_path,
> packagename)
> modify_dir_list = self.GetModifyDir(packagename)
> --
> 2.17.1
next prev parent reply other threads:[~2021-06-24 1:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-23 7:22 [PATCH v1 0/4] Allow EccCheck to run on other repositories PierreGondois
2021-06-23 7:22 ` [PATCH v1 1/4] .pytool/EccCheck: Locate BaseTools dir with EDK_TOOLS_PATH PierreGondois
2021-06-23 7:22 ` [PATCH v1 2/4] .pytool/EccCheck: Rename edk2_path as workspace_path PierreGondois
2021-06-23 7:22 ` [PATCH v1 3/4] .pytool/EccCheck: Check ecc_csv exists PierreGondois
2021-06-23 7:22 ` [PATCH v1 4/4] .pytool/EccCheck: Set PACKAGES_PATH env var in Ecc PierreGondois
2021-06-24 1:52 ` gaoliming [this message]
2021-06-23 7:47 ` [edk2-devel] [PATCH v1 0/4] Allow EccCheck to run on other repositories PierreGondois
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='016d01d7689b$935611f0$ba0235d0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox