From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web08.19335.1661393113309066579 for ; Wed, 24 Aug 2022 19:05:14 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=dLiZiqfS; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id D4BBACD1F692 for ; Thu, 25 Aug 2022 10:05:10 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1661393110; bh=SGOgMTTNJ5Sk88Hk+GFu5HsDjbn6MqLZLkmGq4obtOA=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=dLiZiqfS9Wq+2KOIv9PMmMMN7OYc5c9H8O5LqXwJkQW8GZT0xAJqZxOnL/ZOsdwB9 x+onjxdQacqyyX+oHtCzzdu/g4kqr9PmTU+kzZoHOvBKBFvucq4mJGZjRyiRiKgvvH ijeVkVve2FDRdjormHMSm9v7Ff8qt6YpC4qeX2qQ= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id D0F50CD1F6D5 for ; Thu, 25 Aug 2022 10:05:10 +0800 (CST) X-Virus-Scanned: by SpamTitan at intel-email.com Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 902D0CD1F6A2 for ; Thu, 25 Aug 2022 10:05:10 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id 28B08CD1F73D for ; Thu, 25 Aug 2022 10:05:06 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 25 Aug 2022 10:04:57 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , , "'Andrew Fish'" , , "'Kinney, Michael D'" Cc: , "'Chen, Christine'" , "'Wang, Jian J'" References: <41a26d57-4fae-f53f-29ae-d6c7b258eaee@bsdio.com> <000a01d8b693$58d87c60$0a897520$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF1bZWRrMi1zdGFibGUyMDIyMDhdIE1kZU1vZHVsZVBrZyBidWlsZCBmYWlscyBmb3IgQUFSQ0g2NCBvbiBVYnVudHUgMjIuMDQ=?= Date: Thu, 25 Aug 2022 10:04:59 +0800 Message-ID: <017301d8b827$14bee600$3e3cb200$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: Adi4JS8hMky89D+vRKaSUA/QgdAlHw== Sender: "gaoliming" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Bob: I mean this change brings the behavior change, but this patch doesn't hig= hlight its impact and give the suggestion to modify the impacted DSC file. = Otherwise, this impact can be raised and discussed early. Now, we are near = to create edk2-stable202208. There is no enough time to discuss this change= . So, I suggest to revert this change for stable tag 202208.=20 Andrew, Lefi and Mike: The commit 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 (BaseTools: Fix DSC L= ibraryClass precedence rule) introduces this issue. This commit was merged = into Edk2 on Last month (2022 July 17th). But, its impact was reported on l= ast week. Because we are near for the stable tag edk2-stable202208, we need= to make the decision to keep this change or revert this change for this st= able tag. Can you give your comments on this change? Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Ard > Biesheuvel > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B48=E6=9C=8824=E6=97=A5 = 18:14 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; bob.c.feng@intel.com > =E6=8A=84=E9=80=81: Gao, Liming ; rebecca@bsdio= .com; Chen, > Christine ; Andrew Fish ; Leif > Lindholm ; Kinney, Michael D > ; Wang, Jian J > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] MdeModulePkg build fails for AARCH64= on Ubuntu > 22.04 >=20 > On Wed, 24 Aug 2022 at 09:49, Ard Biesheuvel wrote: > > > > On Tue, 23 Aug 2022 at 09:41, Bob Feng wrote: > > > > > > Hi Liming, > > > > > > Reverting patch may not a good idea, some platforms have done the > implementation based on the DSC spec, if revert, those platforms build wi= ll > break. > > > > Platforms implemented against the DSC spec would have never worked if > > they relied on behavior that BaseTools currently does not implement. > > > > > This commit 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 make the > Basetools behavior be consistent with DSC spec so I don't think it's a > regression bug. > > > > > > > Platforms built against the current behavior that used to work might > > break after this change. MdeModulePkg.dsc for ARM/AARCH64 no longer > > builds due to this change. > > > > Also, as I pointed out, the DSC spec is far from ambiguous. >=20 > Ugh I did it again ... >=20 > "far from *un*ambiguous" >=20 > Will use less difficult words from now on - I obviously cannot be > trusted with them. >=20 > > This means > > that platforms implemented against the spec will rely on one of > > several possible interpretations of that ambiguous set of rules. > > > > So let's revert this change now. Let's fix the DSC spec next, And only > > then, let's fix the code (assuming it still needs to be fixed) > > > > -- > > Ard. >=20 >=20 >=20 >=20