From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <jian.j.wang@intel.com>,
"'Mistry, Nishant C'" <nishant.c.mistry@intel.com>
Cc: <gaoliming@byosoft.com.cn>
Subject: 回复: [edk2-devel] [PATCH] SecurityPkg: Add RPMC Index to the RpmcLib
Date: Fri, 20 Nov 2020 14:26:30 +0800 [thread overview]
Message-ID: <017b01d6bf06$1558f9f0$400aedd0$@byosoft.com.cn> (raw)
In-Reply-To: <SN6PR11MB331243B51CCEDA1EF8B2459EB6E10@SN6PR11MB3312.namprd11.prod.outlook.com>
Jian:
This change is like a feature instead of bug fix. Now, we are in soft
feature freeze phase.
According to SFF definition
https://github.com/tianocore/tianocore.github.io/wiki/SoftFeatureFreeze,
this feature should be deferred to next stable tag.
So, I suggest to revert this change, and merge it after the stable tag
202011.
Thanks
Liming
> -----邮件原件-----
> 发件人: bounce+27952+67669+4905953+8761045@groups.io
> <bounce+27952+67669+4905953+8761045@groups.io> 代表 Wang, Jian J
> 发送时间: 2020年11月18日 11:35
> 收件人: devel@edk2.groups.io; Mistry, Nishant C
> <nishant.c.mistry@intel.com>
> 主题: Re: [edk2-devel] [PATCH] SecurityPkg: Add RPMC Index to the RpmcLib
>
>
> Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
>
> Regards,
> Jian
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nishant
> > Mistry
> > Sent: Thursday, November 12, 2020 2:49 AM
> > To: devel@edk2.groups.io
> > Subject: [edk2-devel] [PATCH] SecurityPkg: Add RPMC Index to the RpmcLib
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2594
> >
> > The re-design requires multiple RPMC counter usages.
> > The consumer will be capable of selecting amongst multiple counters.
> >
> > Signed-off-by: Nishant C Mistry <nishant.c.mistry@intel.com>
> > ---
> > SecurityPkg/Include/Library/RpmcLib.h | 6 +++++-
> > SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 6 +++++-
> > 2 files changed, 10 insertions(+), 2 deletions(-)
> >
> > diff --git a/SecurityPkg/Include/Library/RpmcLib.h
> > b/SecurityPkg/Include/Library/RpmcLib.h
> > index 5882bfae2f..3c15bce1ce 100644
> > --- a/SecurityPkg/Include/Library/RpmcLib.h
> > +++ b/SecurityPkg/Include/Library/RpmcLib.h
> > @@ -14,6 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> > /**
> > Requests the monotonic counter from the designated RPMC counter.
> >
> > + @param[in] CounterIndex The RPMC index
> > @param[out] CounterValue A pointer to a buffer to
> store the RPMC
> > value.
> >
> > @retval EFI_SUCCESS The operation completed
> successfully.
> > @@ -23,12 +24,15 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> > EFI_STATUS
> > EFIAPI
> > RequestMonotonicCounter (
> > + IN UINT8 CounterIndex,
> > OUT UINT32 *CounterValue
> > );
> >
> > /**
> > Increments the monotonic counter in the SPI flash device by 1.
> >
> > + @param[in] CounterIndex The RPMC index
> > +
> > @retval EFI_SUCCESS The operation completed
> successfully.
> > @retval EFI_DEVICE_ERROR A device error occurred
> while attempting
> > to update the counter.
> > @retval EFI_UNSUPPORTED The operation is
> un-supported.
> > @@ -36,7 +40,7 @@ RequestMonotonicCounter (
> > EFI_STATUS
> > EFIAPI
> > IncrementMonotonicCounter (
> > - VOID
> > + IN UINT8 CounterIndex
> > );
> >
> > #endif
> > diff --git a/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c
> > b/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c
> > index e1dd09eb10..697e493a7c 100644
> > --- a/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c
> > +++ b/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c
> > @@ -12,6 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> > /**
> > Requests the monotonic counter from the designated RPMC counter.
> >
> > + @param[in] CounterIndex The RPMC index
> > @param[out] CounterValue A pointer to a buffer to
> store the RPMC
> > value.
> >
> > @retval EFI_SUCCESS The operation completed
> successfully.
> > @@ -21,6 +22,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
> > EFI_STATUS
> > EFIAPI
> > RequestMonotonicCounter (
> > + IN UINT8 CounterIndex,
> > OUT UINT32 *CounterValue
> > )
> > {
> > @@ -31,6 +33,8 @@ RequestMonotonicCounter (
> > /**
> > Increments the monotonic counter in the SPI flash device by 1.
> >
> > + @param[in] CounterIndex The RPMC index
> > +
> > @retval EFI_SUCCESS The operation completed
> successfully.
> > @retval EFI_DEVICE_ERROR A device error occurred
> while attempting
> > to update the counter.
> > @retval EFI_UNSUPPORTED The operation is
> un-supported.
> > @@ -38,7 +42,7 @@ RequestMonotonicCounter (
> > EFI_STATUS
> > EFIAPI
> > IncrementMonotonicCounter (
> > - VOID
> > + IN UINT8 CounterIndex
> > )
> > {
> > ASSERT (FALSE);
> > --
> > 2.16.2.windows.1
> >
> >
> >
> >
> >
>
>
>
>
>
next prev parent reply other threads:[~2020-11-20 6:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-11 18:49 [PATCH] SecurityPkg: Add RPMC Index to the RpmcLib Nishant Mistry
2020-11-18 3:35 ` [edk2-devel] " Wang, Jian J
2020-11-20 6:26 ` gaoliming [this message]
2020-11-20 6:32 ` Wang, Jian J
2020-11-20 6:54 ` 回复: " gaoliming
2020-11-20 7:11 ` Yao, Jiewen
2020-11-20 11:02 ` Laszlo Ersek
2020-11-23 1:00 ` 回复: " gaoliming
2020-11-23 5:23 ` Wang, Jian J
2020-11-23 6:58 ` Yao, Jiewen
2020-11-20 7:38 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='017b01d6bf06$1558f9f0$400aedd0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox