From: "gaoliming via groups.io" <gaoliming=byosoft.com.cn@groups.io>
To: <devel@edk2.groups.io>, <yuwei.chen@intel.com>
Cc: "'Rebecca Cran'" <rebecca@bsdio.com>,
"'Bob Feng'" <bob.c.feng@intel.com>
Subject: 回复: [edk2-devel] [PATCH 1/1] BaseTools: trim warning to error
Date: Tue, 24 Oct 2023 09:04:35 +0800 [thread overview]
Message-ID: <017b01da0616$0e09a050$2a1ce0f0$@byosoft.com.cn> (raw)
In-Reply-To: <20230922064708.1843-1-yuwei.chen@intel.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Yuwei Chen
> 发送时间: 2023年9月22日 14:47
> 收件人: devel@edk2.groups.io
> 抄送: Rebecca Cran <rebecca@bsdio.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Bob Feng <bob.c.feng@intel.com>
> 主题: [edk2-devel] [PATCH 1/1] BaseTools: trim warning to error
>
> As the error is changed to warning, Trim.py will skip the build
> error when the source code have exactly issue.
> This patch change warning to error to opens the checking.
>
> Cc: Rebecca Cran <rebecca@bsdio.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Bob Feng <bob.c.feng@intel.com>
> Signed-off-by: Yuwei Chen <yuwei.chen@intel.com>
> ---
> BaseTools/Source/Python/Trim/Trim.py | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/BaseTools/Source/Python/Trim/Trim.py
> b/BaseTools/Source/Python/Trim/Trim.py
> index c479f7d2b2e7..416935df5e90 100644
> --- a/BaseTools/Source/Python/Trim/Trim.py
> +++ b/BaseTools/Source/Python/Trim/Trim.py
> @@ -281,10 +281,10 @@ def DoInclude(Source, Indent='', IncludePathList=[],
> LocalSearchPath=None, Inclu
> F = File.readlines()
> break
> else:
> - EdkLogger.warn("Trim", "Failed to find include file %s" %
> Source)
> + EdkLogger.error("Trim", "Failed to find include file %s" %
> Source)
> return []
> except:
> - EdkLogger.warn("Trim", FILE_OPEN_FAILURE, ExtraData=Source)
> + EdkLogger.error("Trim", FILE_OPEN_FAILURE, ExtraData=Source)
> return []
>
>
> --
> 2.27.0.windows.1
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109969): https://edk2.groups.io/g/devel/message/109969
Mute This Topic: https://groups.io/mt/102149316/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2023-10-24 1:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 6:47 [edk2-devel] [PATCH 1/1] BaseTools: trim warning to error Yuwei Chen
2023-10-18 17:16 ` Rebecca Cran
2023-10-24 1:04 ` gaoliming via groups.io [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='017b01da0616$0e09a050$2a1ce0f0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox