From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.21764.1605855280098755699 for ; Thu, 19 Nov 2020 22:54:41 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 20 Nov 2020 14:54:30 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Wang, Jian J'" , , "'Mistry, Nishant C'" Cc: , , "'Leif Lindholm'" , References: <661e44cf628ae7315fc738b64a52736f6b5b5285.1605047447.git.nishant.c.mistry@intel.com> <017b01d6bf06$1558f9f0$400aedd0$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBTZWN1cml0eVBrZzogQWRkIFJQTUMgSW5kZXggdG8gdGhlIFJwbWNMaWI=?= Date: Fri, 20 Nov 2020 14:54:33 +0800 Message-ID: <017e01d6bf0a$00882970$01987c50$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQLDCQW5h9LemGh3lNy4fUTd8kAVyQGGQFvOApQqmkoBicNa/afK3q4w Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Jian: The commit message mentions that the re-design requires multiple RPMC counter usages. The library API is also updated to support multiple RPMC. So, I think thi= s is new feature.=20 But, this is just my idea. I would like to collect more feedback from the mail list.=20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: Wang, Jian J > =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA11=D4=C220=C8=D5 14:33 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; gaoliming@byosoft.com.cn; Mist= ry, Nishant C > > =D6=F7=CC=E2: RE: [edk2-devel] [PATCH] SecurityPkg: Add RPMC Index to th= e RpmcLib >=20 > Liming, >=20 > Sorry, I didn't notice it. But the patch was just updating the existing code. It'd > be > more like bug fix than feature, I think. >=20 > Regards, > Jian >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > gaoliming > > Sent: Friday, November 20, 2020 2:27 PM > > To: devel@edk2.groups.io; Wang, Jian J ; Mistry= , > > Nishant C > > Cc: gaoliming@byosoft.com.cn > > Subject: =BB=D8=B8=B4: [edk2-devel] [PATCH] SecurityPkg: Add RPMC Inde= x to the > > RpmcLib > > > > Jian: > > This change is like a feature instead of bug fix. Now, we are in soft > > feature freeze phase. > > According to SFF definition > > https://github.com/tianocore/tianocore.github.io/wiki/SoftFeatureFreez= e, > > this feature should be deferred to next stable tag. > > > > So, I suggest to revert this change, and merge it after the stable ta= g > > 202011. > > > > Thanks > > Liming > > > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > > > =B7=A2=BC=FE=C8=CB: bounce+27952+67669+4905953+8761045@groups.io > > > =B4=FA=B1=ED Wang, > Jian J > > > =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA11=D4=C218=C8=D5 11:35 > > > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; Mistry, Nishant C > > > > > > =D6=F7=CC=E2: Re: [edk2-devel] [PATCH] SecurityPkg: Add RPMC Index t= o the > RpmcLib > > > > > > > > > Reviewed-by: Jian J Wang > > > > > > Regards, > > > Jian > > > > > > > -----Original Message----- > > > > From: devel@edk2.groups.io On Behalf Of > Nishant > > > > Mistry > > > > Sent: Thursday, November 12, 2020 2:49 AM > > > > To: devel@edk2.groups.io > > > > Subject: [edk2-devel] [PATCH] SecurityPkg: Add RPMC Index to the > RpmcLib > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2594 > > > > > > > > The re-design requires multiple RPMC counter usages. > > > > The consumer will be capable of selecting amongst multiple counter= s. > > > > > > > > Signed-off-by: Nishant C Mistry > > > > --- > > > > SecurityPkg/Include/Library/RpmcLib.h | 6 +++++- > > > > SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c | 6 +++++- > > > > 2 files changed, 10 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/SecurityPkg/Include/Library/RpmcLib.h > > > > b/SecurityPkg/Include/Library/RpmcLib.h > > > > index 5882bfae2f..3c15bce1ce 100644 > > > > --- a/SecurityPkg/Include/Library/RpmcLib.h > > > > +++ b/SecurityPkg/Include/Library/RpmcLib.h > > > > @@ -14,6 +14,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > > > /** > > > > Requests the monotonic counter from the designated RPMC > counter. > > > > > > > > + @param[in] CounterIndex The RPMC index > > > > @param[out] CounterValue A pointer to a buffer > to > > > store the RPMC > > > > value. > > > > > > > > @retval EFI_SUCCESS The operation > completed > > > successfully. > > > > @@ -23,12 +24,15 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > > > EFI_STATUS > > > > EFIAPI > > > > RequestMonotonicCounter ( > > > > + IN UINT8 CounterIndex, > > > > OUT UINT32 *CounterValue > > > > ); > > > > > > > > /** > > > > Increments the monotonic counter in the SPI flash device by 1. > > > > > > > > + @param[in] CounterIndex The RPMC index > > > > + > > > > @retval EFI_SUCCESS The operation > completed > > > successfully. > > > > @retval EFI_DEVICE_ERROR A device error > occurred > > > while attempting > > > > to update the counter. > > > > @retval EFI_UNSUPPORTED The operation is > > > un-supported. > > > > @@ -36,7 +40,7 @@ RequestMonotonicCounter ( > > > > EFI_STATUS > > > > EFIAPI > > > > IncrementMonotonicCounter ( > > > > - VOID > > > > + IN UINT8 CounterIndex > > > > ); > > > > > > > > #endif > > > > diff --git a/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c > > > > b/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c > > > > index e1dd09eb10..697e493a7c 100644 > > > > --- a/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c > > > > +++ b/SecurityPkg/Library/RpmcLibNull/RpmcLibNull.c > > > > @@ -12,6 +12,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > > > /** > > > > Requests the monotonic counter from the designated RPMC > counter. > > > > > > > > + @param[in] CounterIndex The RPMC index > > > > @param[out] CounterValue A pointer to a buffer > to > > > store the RPMC > > > > value. > > > > > > > > @retval EFI_SUCCESS The operation > completed > > > successfully. > > > > @@ -21,6 +22,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > > > EFI_STATUS > > > > EFIAPI > > > > RequestMonotonicCounter ( > > > > + IN UINT8 CounterIndex, > > > > OUT UINT32 *CounterValue > > > > ) > > > > { > > > > @@ -31,6 +33,8 @@ RequestMonotonicCounter ( > > > > /** > > > > Increments the monotonic counter in the SPI flash device by 1. > > > > > > > > + @param[in] CounterIndex The RPMC index > > > > + > > > > @retval EFI_SUCCESS The operation > completed > > > successfully. > > > > @retval EFI_DEVICE_ERROR A device error > occurred > > > while attempting > > > > to update the counter. > > > > @retval EFI_UNSUPPORTED The operation is > > > un-supported. > > > > @@ -38,7 +42,7 @@ RequestMonotonicCounter ( > > > > EFI_STATUS > > > > EFIAPI > > > > IncrementMonotonicCounter ( > > > > - VOID > > > > + IN UINT8 CounterIndex > > > > ) > > > > { > > > > ASSERT (FALSE); > > > > -- > > > > 2.16.2.windows.1 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > >