From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web08.22049.1605856834406641422 for ; Thu, 19 Nov 2020 23:20:35 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 20 Nov 2020 15:20:22 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Andrei Warkentin'" , =?gb2312?B?J1BoaWxpcHBlIE1hdGhpZXUtRGF1ZKimJw==?= , "'Andrei Warkentin'" , , "'Bret Barkelew'" , "'Dandan Bi'" , "'Jian J Wang'" , Cc: , References: <20201119000145.1234-1-andrey.warkentin@gmail.com> <7947adcb-e711-f52e-087a-096f52d40686@akeo.ie> <894fb881-eb07-8a91-d7f0-7fe372c87359@redhat.com>,<634feced-94f9-d61d-99f9-13451a1d1507@akeo.ie> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW2VkazItcGxhdGZvcm1zXVtQQVRDSCAxLzFdIFJhc3BiZXJyeVBpOiBnZXQgUlBpNCBhbmQgUlBpMyBidWlsZGluZyBhZ2Fpbi4=?= Date: Fri, 20 Nov 2020 15:20:24 +0800 Message-ID: <017f01d6bf0d$9d537220$d7fa5660$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJFPc44TzHS/Zz9+wGegOQGoN0l9AIlqHHBAXTEZbwB96bKowK6tFNhqLE2jKA= Content-Type: multipart/alternative; boundary="----=_NextPart_000_0180_01D6BF50.AB785FD0" Content-Language: zh-cn ------=_NextPart_000_0180_01D6BF50.AB785FD0 Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Andrei: If you know the broken platforms, you can also contribute the patch to fi= x them.=20 =20 For this patch, it has passed the code review. The comment is to update t= he commit message with below. =20 Fixes: tianocore/edk2@b6490426e320 ("MdeModulePkg: Connect=20 VariablePolicy business logic to VariableServices") =20 Thanks Liming =B7=A2=BC=FE=C8=CB: Andrei Warkentin =20 =B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA11=D4=C220=C8=D5 3:53 =CA=D5=BC=FE=C8=CB: Philippe Mathieu-Daud=A8=A6 ; Andre= i Warkentin ; devel@edk2.groups.io; Bret Barkelew ; Dandan Bi ; Jian J Wang ; pete@akeo.ie =B3=AD=CB=CD: ard.biesheuvel@arm.com; leif@nuviainc.com; Liming Gao =D6=F7=CC=E2: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RaspberryPi: ge= t RPi4 and RPi3 building again. =20 Sorry, folks, is there anything actionable for me here to do? =20 It does appear that all the other edk2-platforms are broken/affected as well. =20 A _____ From: devel@edk2.groups.io > on behalf of Pete Batard via groups.io > Sent: Thursday, November 19, 2020 11:33 AM To: Philippe Mathieu-Daud=A8=A6 >; Andrei Warkentin >; devel@edk2.groups.io >; Bret Barkelew >; Dandan Bi >; Jian J Wang > Cc: ard.biesheuvel@arm.com >; leif@nuviainc.c= om = >; Liming Gao > Subject: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi= 4 and RPi3 building again.=20 =20 Hi Philippe, On 2020.11.19 17:28, Philippe Mathieu-Daud=A8=A6 wrote: > On 11/19/20 6:14 PM, Pete Batard wrote: >> For reference, this breakage was introduced with edk2 commit >> https://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgit= hub. com%2Ftianocore%2Fedk2%2Fcommit%2Fb6490426e3208de7d6cbd756276a02e4329cd85a &data=3D04%7C01%7Cawarkentin%40vmware.com%7C912c541f65924d5c6a6108d88c= b139 b8%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637414040092341605%7CUnkno= wn %7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI= 6M n0%3D%7C1000&sdata=3DK%2Fe45o3ZvD29UaHNFzCKLBMil8lJ1adSB2mRiC0uVy0%3D&= amp; reserved=3D0 >> (MdeModulePkg: Connect VariablePolicy business logic to VariableServices). >=20 > It is better if Andrei Cc the developers involved (Cc'ed them now). Good point. >=20 >> >> It'll probably be worth adding a reference to it in the commit message >> during integration. >=20 > This can be added before the S-o-b: >=20 > Fixes: b6490426e320 ("MdeModulePkg: Connect VariablePolicy business > logic to VariableServices") Just going to nitpick that since we're patching in edk2-platforms and=20 referencing an edk2 commit, we'll want: Fixes: tianocore/edk2@b6490426e320 ("MdeModulePkg: Connect=20 VariablePolicy business logic to VariableServices") For GitHub to produce a clickable link. Regards, /Pete >=20 >> >> With this: >> >> On 2020.11.19 00:01, Andrei Warkentin wrote: >>> Add VariablePolicyLib and its dependency. >>> >>> Testing: Pi 4 boot. >>> >>> Signed-off-by: Andrei Warkentin > >>> --- >>> Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +++ >>> Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++ >>> 2 files changed, 6 insertions(+) >>> >>> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc >>> b/Platform/RaspberryPi/RPi3/RPi3.dsc >>> index 325d7bdb..9408138d 100644 >>> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc >>> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc >>> @@ -169,6 +169,8 @@ >>> =20 >>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNu= ll .inf >>> >>> !endif >>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib= .i nf >>> >>> + >>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Varia= bl ePolicyHelperLib.inf >>> >>> GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf >>> [LibraryClasses.common.SEC] >>> @@ -218,6 +220,7 @@ >>> =20 >>> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.in= f >>> EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf >>> ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib= Ru ntimeDxe.inf >>> >>> !if $(SECURE_BOOT_ENABLE) =3D=3D TRUE >>> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >>> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc >>> b/Platform/RaspberryPi/RPi4/RPi4.dsc >>> index c994f56d..4e5a36ed 100644 >>> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc >>> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc >>> @@ -169,6 +169,8 @@ >>> =20 >>> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNu= ll .inf >>> >>> !endif >>> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib= .i nf >>> >>> + >>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Varia= bl ePolicyHelperLib.inf >>> >>> GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf >>> # >>> @@ -226,6 +228,7 @@ >>> =20 >>> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.in= f >>> EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf >>> ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf >>> + >>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib= Ru ntimeDxe.inf >>> >>> !if $(SECURE_BOOT_ENABLE) =3D=3D TRUE >>> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf >>> >> >> Reviewed-by: Pete Batard > >> >=20 ------=_NextPart_000_0180_01D6BF50.AB785FD0 Content-Type: text/html; charset="gb2312" Content-Transfer-Encoding: quoted-printable

Andre= i:

 If you know the broken plat= forms, you can also contribute the patch to fix them.

 

 For t= his patch, it has passed the code review. The comment is to update the comm= it message with below.

 

Fixes: tianocore/edk= 2@b6490426e320 ("MdeModulePkg: Connect
VariablePolicy business log= ic to VariableServices")

=  

Thanks

Liming

=B7=A2=BC=FE=C8=CB: Andrei Warkentin <awarkentin@vmware.com>
<= span style=3D'font-family:=B5=C8=CF=DF'>=B7=A2=CB=CD=CA=B1=BC=E4: 2020=C4=EA11=D4=C220=C8=D5 3:53
=CA=D5=BC=FE=C8=CB: Philippe Mathieu-Daud=A8=A6 <= ;philmd@redhat.com>; Andrei Warkentin <andrey.warkentin@gmail.com>= ; devel@edk2.groups.io; Bret Barkelew <brbarkel@microsoft.com>; Danda= n Bi <dandan.bi@intel.com>; Jian J Wang <jian.j.wang@intel.com>= ; pete@akeo.ie
=B3=AD=CB=CD: ard.biesheuvel@arm.com; leif@nuviainc.com; Liming Gao <g= aoliming@byosoft.com.cn>
=D6=F7=CC=E2: Re: [edk2-devel] [edk2-platforms][PATCH 1/1] R= aspberryPi: get RPi4 and RPi3 building again.

<= /div>

 =

Sorry, folks, is there anything actionabl= e for me here to do?

<= span lang=3DEN-US style=3D'font-size:12.0pt;font-family:Consolas;color:blac= k'> 

It do= es appear that all the other edk2-platforms are broken/affected as well.

 

A

<= div class=3DMsoNormal align=3Dcenter style=3D'text-align:center'>

From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of Pete Batard = via groups.io <pete=3Dakeo.i= e@groups.io>
Sent: Thursday, November 19, 2020 11:33 AMTo: Philippe Mathieu-Daud=A8=A6 <philmd@redhat.com>; Andrei Warkentin <andrey.warkentin@gmail.com>; devel@edk2.groups.io <devel@edk2.groups.io>; Bret Barkelew <brbarkel@microsoft.com>; Dandan = Bi <dandan.bi@intel.com>; = Jian J Wang <jian.j.wang@intel.= com>
Cc: ard.bie= sheuvel@arm.com <ard.biesh= euvel@arm.com>; leif@nuviainc.c= om <leif@nuviainc.com>; = Liming Gao <gaoliming@byosof= t.com.cn>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH= 1/1] RaspberryPi: get RPi4 and RPi3 building again.

&nbs= p;

Hi Philippe,

On 2020.11.19= 17:28, Philippe Mathieu-Daud=A8=A6 wrote:
> On 11/19/20 6:14 PM, Pet= e Batard wrote:
>> For reference, this breakage was introduced wit= h edk2 commit
>> https= ://nam04.safelinks.protection.outlook.com/?url=3Dhttps%3A%2F%2Fgithub.com%2= Ftianocore%2Fedk2%2Fcommit%2Fb6490426e3208de7d6cbd756276a02e4329cd85a&a= mp;data=3D04%7C01%7Cawarkentin%40vmware.com%7C912c541f65924d5c6a6108d88cb13= 9b8%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C0%7C0%7C637414040092341605%7CUnkno= wn%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVC= I6Mn0%3D%7C1000&amp;sdata=3DK%2Fe45o3ZvD29UaHNFzCKLBMil8lJ1adSB2mRiC0uV= y0%3D&amp;reserved=3D0
>> (MdeModulePkg: Connect VariableP= olicy business logic to VariableServices).
>
> It is better if= Andrei Cc the developers involved (Cc'ed them now).

Good point.
=
>
>>
>> It'll probably be worth adding a referenc= e to it in the commit message
>> during integration.
>
&= gt; This can be added before the S-o-b:
>
> Fixes: b6490426e32= 0 ("MdeModulePkg: Connect VariablePolicy business
> logic to Var= iableServices")

Just going to nitpick that since we're patching= in edk2-platforms and
referencing an edk2 commit, we'll want:

F= ixes: tianocore/edk2@b6490426e320 ("MdeModulePkg: Connect
Variable= Policy business logic to VariableServices")

For GitHub to produ= ce a clickable link.

Regards,

/Pete

>
>><= br>>> With this:
>>
>> On 2020.11.19 00:01, Andrei = Warkentin wrote:
>>> Add VariablePolicyLib and its dependency.<= br>>>>
>>> Testing: Pi 4 boot.
>>>
>= >> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
>>> ---
&= gt;>>    Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +++
>= >>    Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++
>>= ;>    2 files changed, 6 insertions(+)
>>>
>= >> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc
>>> b/= Platform/RaspberryPi/RPi3/RPi3.dsc
>>> index 325d7bdb..9408138d= 100644
>>> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
>>= ;> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
>>> @@ -169,6 +1= 69,8 @@
>>>    
>>> AuthVariab= leLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
&= gt;>>
>>>    !endif
>>>   = ;   VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf<= br>>>> +
>>> VariablePolicyLib|MdeModulePkg/Library/Va= riablePolicyLib/VariablePolicyLib.inf
>>>
>>> +
= >>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHel= perLib/VariablePolicyHelperLib.inf
>>>
>>>  &n= bsp;   GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.i= nf
>>>      [LibraryClasses.common.SEC]
>&= gt;> @@ -218,6 +220,7 @@
>>>    
>= ;>> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNu= ll.inf
>>>      EfiResetSystemLib|Platform/= RaspberryPi/Library/ResetLib/ResetLib.inf
>>>    = ;  ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf
>>> +<= br>>>> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/Va= riablePolicyLibRuntimeDxe.inf
>>>
>>>    =   !if $(SECURE_BOOT_ENABLE) =3D=3D TRUE
>>>   &n= bsp;  BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf<= br>>>> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc
>>= > b/Platform/RaspberryPi/RPi4/RPi4.dsc
>>> index c994f56d..4= e5a36ed 100644
>>> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
= >>> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
>>> @@ -1= 69,6 +169,8 @@
>>>    
>>> Aut= hVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.i= nf
>>>
>>>    !endif
>>> = ;     VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckL= ib.inf
>>> +
>>> VariablePolicyLib|MdeModulePkg/Lib= rary/VariablePolicyLib/VariablePolicyLib.inf
>>>
>>>= ; +
>>> VariablePolicyHelperLib|MdeModulePkg/Library/VariablePo= licyHelperLib/VariablePolicyHelperLib.inf
>>>
>>>&n= bsp;     GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/Gp= ioLib.inf
>>>        #
>>>= @@ -226,6 +228,7 @@
>>>    
>>&g= t; CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf<= br>>>>      EfiResetSystemLib|Platform/Raspber= ryPi/Library/ResetLib/ResetLib.inf
>>>     = ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf
>>> +
>= >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariableP= olicyLibRuntimeDxe.inf
>>>
>>>      = !if $(SECURE_BOOT_ENABLE) =3D=3D TRUE
>>>    &nb= sp; BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
>= >>
>>
>> Reviewed-by: Pete Batard <pete@akeo.ie>
>>
>




------=_NextPart_000_0180_01D6BF50.AB785FD0--