回复: [edk2-devel] [PATCH V8 12/47] MdePkg: Add macro to check SEV / TDX guest

["gaoliming" <gaoliming@byosoft.com.cn>]

Min:
  This patch is good. I have no other comments in MdePkg. Reviewed-by:
Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Min Xu
> 发送时间: 2022年3月17日 13:32
> 收件人: devel@edk2.groups.io; Xu, Min M <min.m.xu@intel.com>
> 抄送: Michael Roth <michael.roth@amd.com>; Ni, Ray <ray.ni@intel.com>;
> Kumar, Rahul1 <rahul1.kumar@intel.com>; Dong, Eric <eric.dong@intel.com>;
> James Bottomley <jejb@linux.ibm.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Tom Lendacky <thomas.lendacky@amd.com>;
> Justen, Jordan L <jordan.l.justen@intel.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Aktas, Erdem <erdemaktas@google.com>;
> Gerd Hoffmann <kraxel@redhat.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> Liu, Zhiguang <zhiguang.liu@intel.com>
> 主题: Re: [edk2-devel] [PATCH V8 12/47] MdePkg: Add macro to check SEV /
> TDX guest
> 
> Hi, Liming
> Can you help to review this patch?
> https://edk2.groups.io/g/devel/message/87480
> 
> Thanks
> Min
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Min Xu
> > Sent: Saturday, March 12, 2022 9:54 AM
> > To: devel@edk2.groups.io
> > Cc: Xu, Min M <min.m.xu@intel.com>; Michael Roth
> <michael.roth@amd.com>;
> > Ni, Ray <ray.ni@intel.com>; Kumar, Rahul1 <rahul1.kumar@intel.com>;
> Dong,
> > Eric <eric.dong@intel.com>; James Bottomley <jejb@linux.ibm.com>; Yao,
> > Jiewen <jiewen.yao@intel.com>; Tom Lendacky
> <thomas.lendacky@amd.com>;
> > Justen, Jordan L <jordan.l.justen@intel.com>; Ard Biesheuvel
> > <ardb+tianocore@kernel.org>; Aktas, Erdem <erdemaktas@google.com>;
> Gerd
> > Hoffmann <kraxel@redhat.com>; Kinney, Michael D
> > <michael.d.kinney@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>;
> Liu,
> > Zhiguang <zhiguang.liu@intel.com>
> > Subject: [edk2-devel] [PATCH V8 12/47] MdePkg: Add macro to check SEV /
> > TDX guest
> >
> > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
> >
> > Add macros CC_GUEST_IS_SEV / CC_GUEST_IS_TDX to check SEV / TDX
> guest.
> >
> > Cc: Michael Roth <michael.roth@amd.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Rahul Kumar <rahul1.kumar@intel.com>
> > Cc: Eric Dong <eric.dong@intel.com>
> > Cc: James Bottomley <jejb@linux.ibm.com>
> > Cc: Min Xu <min.m.xu@intel.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Tom Lendacky <thomas.lendacky@amd.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> > Cc: Erdem Aktas <erdemaktas@google.com>
> > Cc: Gerd Hoffmann <kraxel@redhat.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> > Signed-off-by: Min Xu <min.m.xu@intel.com>
> > ---
> >  MdePkg/Include/ConfidentialComputingGuestAttr.h | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/MdePkg/Include/ConfidentialComputingGuestAttr.h
> > b/MdePkg/Include/ConfidentialComputingGuestAttr.h
> > index 6a1301801519..dd2541c6dcdf 100644
> > --- a/MdePkg/Include/ConfidentialComputingGuestAttr.h
> > +++ b/MdePkg/Include/ConfidentialComputingGuestAttr.h
> > @@ -22,4 +22,7 @@ typedef enum {
> >    CCAttrIntelTdx = 0x200,
> >  } CONFIDENTIAL_COMPUTING_GUEST_ATTR;
> >
> > +#define CC_GUEST_IS_TDX(x)  ((x) == CCAttrIntelTdx) #define
> > +CC_GUEST_IS_SEV(x)  ((x) == CCAttrAmdSev || (x) == CCAttrAmdSevEs ||
> > +(x) == CCAttrAmdSevSnp)
> > +
> >  #endif
> > --
> > 2.29.2.windows.2
> >
> >
> >
> >
> >
> 
> 
> 
> 
>