From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web09.4568.1647566013997676612 for ; Thu, 17 Mar 2022 18:13:35 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([101.224.116.119]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 18 Mar 2022 09:13:24 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 101.224.116.119 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Michael Roth'" , "'Ni, Ray'" , "'Kumar, Rahul1'" , "'Dong, Eric'" , "'James Bottomley'" , "'Yao, Jiewen'" , "'Tom Lendacky'" , "'Justen, Jordan L'" , "'Ard Biesheuvel'" , "'Aktas, Erdem'" , "'Gerd Hoffmann'" , "'Kinney, Michael D'" , "'Liu, Zhiguang'" References: <16DB7F586DEAD807.23528@groups.io> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIFY4IDEyLzQ3XSBNZGVQa2c6IEFkZCBtYWNybyB0byBjaGVjayBTRVYgLyBURFggZ3Vlc3Q=?= Date: Fri, 18 Mar 2022 09:13:27 +0800 Message-ID: <018101d83a65$5ffca390$1ff5eab0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJRDwiSV1EuublFZBUHcIW8jbAi2QLexwqkAeC8fPSrrLBPoA== Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Min: This patch is good. I have no other comments in MdePkg. Reviewed-by: Liming Gao Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED Min Xu > =B7=A2=CB=CD=CA=B1=BC=E4: 2022=C4=EA3=D4=C217=C8=D5 13:32 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; Xu, Min M > =B3=AD=CB=CD: Michael Roth ; Ni, Ray ; > Kumar, Rahul1 ; Dong, Eric ; > James Bottomley ; Yao, Jiewen > ; Tom Lendacky ; > Justen, Jordan L ; Ard Biesheuvel > ; Aktas, Erdem ; > Gerd Hoffmann ; Kinney, Michael D > ; Gao, Liming ; > Liu, Zhiguang > =D6=F7=CC=E2: Re: [edk2-devel] [PATCH V8 12/47] MdePkg: Add macro to chec= k SEV / > TDX guest >=20 > Hi, Liming > Can you help to review this patch? > https://edk2.groups.io/g/devel/message/87480 >=20 > Thanks > Min > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Min Xu > > Sent: Saturday, March 12, 2022 9:54 AM > > To: devel@edk2.groups.io > > Cc: Xu, Min M ; Michael Roth > ; > > Ni, Ray ; Kumar, Rahul1 ; > Dong, > > Eric ; James Bottomley ; Yao, > > Jiewen ; Tom Lendacky > ; > > Justen, Jordan L ; Ard Biesheuvel > > ; Aktas, Erdem ; > Gerd > > Hoffmann ; Kinney, Michael D > > ; Gao, Liming ; > Liu, > > Zhiguang > > Subject: [edk2-devel] [PATCH V8 12/47] MdePkg: Add macro to check SEV / > > TDX guest > > > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3429 > > > > Add macros CC_GUEST_IS_SEV / CC_GUEST_IS_TDX to check SEV / TDX > guest. > > > > Cc: Michael Roth > > Cc: Ray Ni > > Cc: Rahul Kumar > > Cc: Eric Dong > > Cc: James Bottomley > > Cc: Min Xu > > Cc: Jiewen Yao > > Cc: Tom Lendacky > > Cc: Jordan Justen > > Cc: Ard Biesheuvel > > Cc: Erdem Aktas > > Cc: Gerd Hoffmann > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Acked-by: Gerd Hoffmann > > Signed-off-by: Min Xu > > --- > > MdePkg/Include/ConfidentialComputingGuestAttr.h | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/MdePkg/Include/ConfidentialComputingGuestAttr.h > > b/MdePkg/Include/ConfidentialComputingGuestAttr.h > > index 6a1301801519..dd2541c6dcdf 100644 > > --- a/MdePkg/Include/ConfidentialComputingGuestAttr.h > > +++ b/MdePkg/Include/ConfidentialComputingGuestAttr.h > > @@ -22,4 +22,7 @@ typedef enum { > > CCAttrIntelTdx =3D 0x200, > > } CONFIDENTIAL_COMPUTING_GUEST_ATTR; > > > > +#define CC_GUEST_IS_TDX(x) ((x) =3D=3D CCAttrIntelTdx) #define > > +CC_GUEST_IS_SEV(x) ((x) =3D=3D CCAttrAmdSev || (x) =3D=3D CCAttrAmdSe= vEs || > > +(x) =3D=3D CCAttrAmdSevSnp) > > + > > #endif > > -- > > 2.29.2.windows.2 > > > > > > > > > > >=20 >=20 >=20 >=20 >=20