Re: [PATCH 02/22] .mailmap: add entry for Ching JenX Cheng

["Laszlo Ersek" <lersek@redhat.com>]

On 09/22/20 11:38, Philippe Mathieu-Daudé wrote:
> On 9/22/20 9:22 AM, Laszlo Ersek wrote:
>> On 09/17/20 18:45, Philippe Mathieu-Daudé wrote:
>>
>>> OK I didn't know the format has to follow the English name order.
>>> I used the Chinese name order because I found somewhere in the
>>> EDK2 archives some posts signed as "Cheng Ching Jen", so I took
>>> this order to respect the author preference.
>>
>> Thanks -- this is a convincing argument.
>>
>> Gives me the following idea: the mailmap file supports comments (see at
>> the end of git-shortlog). Thus, at least when we extend our own mailmap
>> for edk2, we should always include some references (mailing list links,
>> commit hashes, etc) near the newly added entries that justify the entries.
> 
> Ah this is an excellent idea,

Thanks!

> that way we could fix old contributions
> even if the contributor left the community.

To clarify: this was meant for our own mailmap for edk2 (out-of-tree);
that is, *not* the .mailmap file in the edk2 project root directory.

Again -- my experience with this 22-part patch set tells me that it
makes no sense to spend time improving the upstream .mailmap file.
Because, feedback has been extremely lacking. So the "use comments"
trick would apply to the mailmap file that we would maintain *outside*
of edk2, just for our particular purposes (git-dm, git-shortlog for
QEMU's edk2 submodule updates, etc).

I'll go ahead and merge the patches from this series that have been
approved by the respective email addresses' owners, and drop the rest.
(We could incorporate them into the out-of-tree mailmap file, later.)

Thanks
Laszlo