From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web09.7349.1660280048993081531 for ; Thu, 11 Aug 2022 21:54:09 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=ZEz+iXKX; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 51E1BCD1F6F5 for ; Fri, 12 Aug 2022 12:54:05 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1660280045; bh=tEHfZ9aqRaAVW4aZahb44PXKvFdo1ZEKX6Oi/7nnMaA=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=ZEz+iXKXxyyMv9U1hhdQCv2Tsa7eK+UXYWQatoweEuoZFK9pbPhS6ZKTs9pizOD1R 9yuzDCRHvIk3Sat9U7SiTlEQII2iXNNI7mTm/ighRkQHt1dof8W5IcbflkAJOENgz+ /VDp0pH0Vz2ctI4OFi3QCxZeiXHpy1ZFzbpOpBuQ= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 4D8B8CD1F6EE for ; Fri, 12 Aug 2022 12:54:05 +0800 (CST) X-Virus-Scanned: by SpamTitan at intel-email.com Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id F2F3ACD1F692 for ; Fri, 12 Aug 2022 12:54:04 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id 85FC0CD1F6F2 for ; Fri, 12 Aug 2022 12:54:02 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Fri, 12 Aug 2022 12:54:00 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , Cc: "'Zhichao Gao'" , "'Ray Ni'" , "'Jian J Wang'" References: <030701d8a890$97e31bb0$c7a95310$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIDEvM10gTWRlTW9kdWxlUGtnL0Jvb3RMb2dvTGliOiBBZGQgb3B0aW9uIHRvIGZvbGxvdyBCR1JUIHNwZWNpZmljYXRpb24=?= Date: Fri, 12 Aug 2022 12:54:01 +0800 Message-ID: <018301d8ae07$8a6923e0$9f3b6ba0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJMbIFcm0feeLs39T7bHusF0sj6tQI+jqi0AX9YjO8C+465+6yNaiQQ Sender: "gaoliming" Content-Type: multipart/alternative; boundary="----=_NextPart_000_0184_01D8AE4A.988DC370" Content-Language: zh-cn ------=_NextPart_000_0184_01D8AE4A.988DC370 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sean: According to the description, I agree with Pedro that this is a recommenda= tion and not mandatory. Do you think so? =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Pedro Falcato =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B48=E6=9C=885=E6=97=A5 15:= 04 =E6=94=B6=E4=BB=B6=E4=BA=BA: edk2-devel-groups-io ; s= ean@starlabs.systems =E6=8A=84=E9=80=81: Liming Gao ; Zhichao Gao ; Ray Ni ; Jian J Wang =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: = Add option to follow BGRT specification =20 Hi Sean, =20 I think it's clear from the wording that the 38.2% thing is a recommendatio= n and not mandatory. I was curious and checked out the ACPI spec and they a= ppear to not mention that at all. Maybe reword things to "Microsoft recomme= ndation"? =20 Thanks, Pedro =20 On Fri, 5 Aug 2022, 07:55 Sean Rhodes, > wrote: Hi Liming =20 Microsoft details about positioning can be found here: https://docs.microso= ft.com/en-us/windows-hardware/drivers/bringup/boot-screen-components =20 Thanks =20 Sean =20 On Fri, 5 Aug 2022 at 07:00, gaoliming via groups.io > wro= te: Sean: Can you give BGRT spec link? I want to check the spec description.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > =E4=BB=A3=E8= =A1=A8 Sean Rhodes > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B47=E6=9C=8826=E6=97=A5 = 16:15 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =20 > =E6=8A=84=E9=80=81: Sean Rhodes >; Zhichao Gao > >; Ray Ni >; Jian J Wang > >; Liming Gao > > =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH 1/3] MdeModulePkg/BootLogoLib: Ad= d option to > follow BGRT specification >=20 > Add an option to position the logo 38.2% from the top of the screen, > which follows the BGRT specification. >=20 > Cc: Zhichao Gao > > Cc: Ray Ni > > Cc: Jian J Wang > > Cc: Liming Gao > > Signed-off-by: Sean Rhodes > > --- > MdeModulePkg/Include/Protocol/PlatformLogo.h | 3 ++- > MdeModulePkg/Library/BootLogoLib/BootLogoLib.c | 7 ++++--- > 2 files changed, 6 insertions(+), 4 deletions(-) >=20 > diff --git a/MdeModulePkg/Include/Protocol/PlatformLogo.h > b/MdeModulePkg/Include/Protocol/PlatformLogo.h > index 08e1dc35a4..7c9ef63c66 100644 > --- a/MdeModulePkg/Include/Protocol/PlatformLogo.h > +++ b/MdeModulePkg/Include/Protocol/PlatformLogo.h > @@ -29,7 +29,8 @@ typedef enum { > EdkiiPlatformLogoDisplayAttributeCenterBottom, >=20 > EdkiiPlatformLogoDisplayAttributeLeftBottom, >=20 > EdkiiPlatformLogoDisplayAttributeCenterLeft, >=20 > - EdkiiPlatformLogoDisplayAttributeCenter >=20 > + EdkiiPlatformLogoDisplayAttributeCenter, >=20 > + EdkiiPlatformLogoDisplayAttributeBGRTSpecification >=20 > } EDKII_PLATFORM_LOGO_DISPLAY_ATTRIBUTE; >=20 >=20 >=20 > /** >=20 > diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c > b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c > index 478ec2d40e..ac086f9c79 100644 > --- a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c > +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c > @@ -169,7 +169,6 @@ BootLogoEnableLogo ( > DestX =3D SizeOfX - Image.Width; >=20 > DestY =3D 0; >=20 > break; >=20 > - >=20 > case EdkiiPlatformLogoDisplayAttributeCenterLeft: >=20 > DestX =3D 0; >=20 > DestY =3D (SizeOfY - Image.Height) / 2; >=20 > @@ -182,7 +181,6 @@ BootLogoEnableLogo ( > DestX =3D SizeOfX - Image.Width; >=20 > DestY =3D (SizeOfY - Image.Height) / 2; >=20 > break; >=20 > - >=20 > case EdkiiPlatformLogoDisplayAttributeLeftBottom: >=20 > DestX =3D 0; >=20 > DestY =3D SizeOfY - Image.Height; >=20 > @@ -195,7 +193,10 @@ BootLogoEnableLogo ( > DestX =3D SizeOfX - Image.Width; >=20 > DestY =3D SizeOfY - Image.Height; >=20 > break; >=20 > - >=20 > + case EdkiiPlatformLogoDisplayAttributeBGRTSpecification: >=20 > + DestX =3D (SizeOfX - Image.Width) / 2; >=20 > + DestY =3D (SizeOfY * 382) / 1000 - Image.Height / 2; >=20 > + break; >=20 > default: >=20 > ASSERT (FALSE); >=20 > continue; >=20 > -- > 2.34.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#91842): https://edk2.groups.io/g/devel/message/91842 > Mute This Topic: https://groups.io/mt/92623125/4905953 > Group Owner: devel+owner@edk2.groups.io =20 > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [gaoliming@byosoft.com.cn ] > -=3D-=3D-=3D-=3D-=3D-=3D >=20 ------=_NextPart_000_0184_01D8AE4A.988DC370 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

Sean:

=C2=A0A= ccording to the description, I agree with Pedro that this is a recommendati= on and not mandatory. Do you think so?

 

Thanks

Liming

=E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io <devel@edk2.groups.io> = =E4=BB= =A3=E8=A1=A8 Pedro Falcato
=E5=8F=91=E9=80=81=E6=97=B6=E9=97= =B4: 2022=E5=B9=B48=E6=9C=885=E6=97=A5 15:04=
=E6=94=B6=E4=BB=B6=E4=BA=BA: edk2-devel-groups-io <devel@edk2.groups.io>; sean@st= arlabs.systems
=E6=8A=84=E9=80=81: Liming Gao <gaoliming@byosoft.com.cn>; Zhichao = Gao <zhichao.gao@intel.com>; Ray Ni <ray.ni@intel.com>; Jian J = Wang <jian.j.wang@intel.com>
=E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH 1/3] MdeM= odulePkg/BootLogoLib: Add option to follow BGRT specification

&nb= sp;

Hi Sean,

 = ;

I thin= k it's clear from the wording that the 38.2% thing is a recommendation and = not mandatory. I was curious and checked out the ACPI spec and they appear = to not mention that at all. Maybe reword things to "Microsoft recommen= dation"?

 

Thanks,

Pedro

 

On Fri, 5 Aug 2022, 07:55 Sean Rhodes, <sean@starlabs.systems> wrote:

Hi Liming

 

=  

Thanks

 

Sean

 

On Fri, 5 Aug 2022 at 07:00, gaoliming via groups.io <gaoliming=3Dbyosoft.com.cn@groups.io>= ; wrote:

Sean:
  Can you give BGRT spec link? I want to check the s= pec description.

Thanks
Liming
> -----=E9=82=AE=E4= =BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91= =E4=BB=B6=E4=BA=BA: devel@edk2.groups.io <devel@edk2.groups.io> =E4= =BB=A3=E8=A1=A8 Sean Rhodes
> =E5=8F=91=E9= =80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B47=E6=9C=8826=E6=97=A5 16:15
> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.gr= oups.io
> =E6=8A=84=E9=80=81: Sean Rhod= es <sean@starlabs.systems&g= t;; Zhichao Gao
> <zhichao.gao@intel.com>; Ray Ni <ray.ni@intel.com>; Jian J Wang
&= gt; <jian.j.w= ang@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>
> = =E4=B8=BB=E9=A2=98: [edk2-devel] [PATCH 1/3] MdeModulePk= g/BootLogoLib: Add option to
> follow BGRT specification
>
= > Add an option to position the logo 38.2% from the top of the screen,> which follows the BGRT specification.
>
> Cc: Zhichao G= ao <zhichao.g= ao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Jian J Wang <= ;jian.j.wang@int= el.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signe= d-off-by: Sean Rhodes <sean@sta= rlabs.systems>
> ---
>  MdeModulePkg/Include/Protoc= ol/PlatformLogo.h   | 3 ++-
>  MdeModulePkg/Library/Bo= otLogoLib/BootLogoLib.c | 7 ++++---
>  2 files changed, 6 insert= ions(+), 4 deletions(-)
>
> diff --git a/MdeModulePkg/Include/= Protocol/PlatformLogo.h
> b/MdeModulePkg/Include/Protocol/PlatformLog= o.h
> index 08e1dc35a4..7c9ef63c66 100644
> --- a/MdeModulePkg/= Include/Protocol/PlatformLogo.h
> +++ b/MdeModulePkg/Include/Protocol= /PlatformLogo.h
> @@ -29,7 +29,8 @@ typedef enum {
>  &nbs= p; EdkiiPlatformLogoDisplayAttributeCenterBottom,
>
>  &n= bsp; EdkiiPlatformLogoDisplayAttributeLeftBottom,
>
>  &n= bsp; EdkiiPlatformLogoDisplayAttributeCenterLeft,
>
> -  = EdkiiPlatformLogoDisplayAttributeCenter
>
> +  EdkiiPlatf= ormLogoDisplayAttributeCenter,
>
> +  EdkiiPlatformLogoDi= splayAttributeBGRTSpecification
>
>  } EDKII_PLATFORM_LOG= O_DISPLAY_ATTRIBUTE;
>
>
>
>  /**
> <= br>> diff --git a/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
>= b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> index 478ec2d40e.= .ac086f9c79 100644
> --- a/MdeModulePkg/Library/BootLogoLib/BootLogoL= ib.c
> +++ b/MdeModulePkg/Library/BootLogoLib/BootLogoLib.c
> @= @ -169,7 +169,6 @@ BootLogoEnableLogo (
>        =   DestX =3D SizeOfX - Image.Width;
>
>     = ;     DestY =3D 0;
>
>        &n= bsp; break;
>
> -
>
>        = case EdkiiPlatformLogoDisplayAttributeCenterLeft:
>
>  &n= bsp;       DestX =3D 0;
>
>     =     DestY =3D (SizeOfY - Image.Height) / 2;
>
> @@ = -182,7 +181,6 @@ BootLogoEnableLogo (
>        &n= bsp; DestX =3D SizeOfX - Image.Width;
>
>      =     DestY =3D (SizeOfY - Image.Height) / 2;
>
> = ;         break;
>
> -
>
>&nb= sp;       case EdkiiPlatformLogoDisplayAttributeLeftBottom:<= br>>
>          DestX =3D 0;
> >          DestY =3D SizeOfY - Image.Height;>
> @@ -195,7 +193,10 @@ BootLogoEnableLogo (
>  &nb= sp;       DestX =3D SizeOfX - Image.Width;
>
>&= nbsp;         DestY =3D SizeOfY - Image.Height;
>=
>          break;
>
> -
&g= t;
> +      case EdkiiPlatformLogoDisplayAttributeBGR= TSpecification:
>
> +        DestX =3D (Si= zeOfX - Image.Width) / 2;
>
> +        Des= tY =3D (SizeOfY * 382) / 1000 - Image.Height / 2;
>
> +  =       break;
>
>        def= ault:
>
>          ASSERT (FALSE);>
>          continue;
>
>= --
> 2.34.1
>
>
>
> -=3D-=3D-=3D-=3D-=3D-= =3D
> Groups.io Links: You receive all messages sent to this group.> View/Reply Online (#91842): https://edk2.groups.io/g/devel/message/9= 1842
> Mute This Topic: https://groups.io/mt/92623125/4905953
>= ; Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/= devel/unsub
> [gaoliming@byosoft.com.cn]
> -=3D-=3D-=3D-=3D-=3D-=3D<= br>>







=

<= /div> ------=_NextPart_000_0184_01D8AE4A.988DC370--