回复: [edk2-stable202108] [PATCH] EmbeddedPkg/NonCoherentDmaLib: Avoid dereferencing unset Map field

回复: [edk2-stable202108] [PATCH] EmbeddedPkg/NonCoherentDmaLib: Avoid dereferencing unset Map field

[gaoliming]

Ard:
  Now, we enter into Hard Feature Freeze phase until edk2-stable202108 tag is created at 2021-08-27.

  In this phase, the bug fix is still allowed to be merged. This patch is a clear bug fix. I am OK to merge it for this stable tag. 

  I suggest we wait for 1 day to collect the feedback from edk2 community. If no objection, you can merge it. 

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Ard
> Biesheuvel
> 发送时间: 2021年8月16日 15:11
> 收件人: Jeremy Linton <jeremy.linton@arm.com>; Liming Gao (Byosoft
> address) <gaoliming@byosoft.com.cn>
> 抄送: edk2-devel-groups-io <devel@edk2.groups.io>; Peter Batard
> <pete@akeo.ie>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Leif
> Lindholm <leif@nuviainc.com>; Andrei Warkentin
> <awarkentin@vmware.com>; Sunny Wang <Sunny.Wang@arm.com>; Samer
> El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> 主题: Re: [edk2-devel] [PATCH] EmbeddedPkg/NonCoherentDmaLib: Avoid
> dereferencing unset Map field
> 
> On Fri, 13 Aug 2021 at 07:05, Jeremy Linton <jeremy.linton@arm.com> wrote:
> >
> > Map->Operation is used to select whether a DMA region that
> > is being bounced has the source buffer copied to it. Except
> > Map->Operation isn't yet set, so the behavior is somewhat
> > random. Instead use the passed in Operation parameter.
> >
> > Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>
> 
> Thanks for fixing this.
> 
> Liming, I am not sure what stage of the release cycle we are currently
> in, but this fix should go in right away anyway. Unless any objections
> are raised, I will merge it later today. I will leave it to you to
> decide how this affects the stable tag release schedule.
> 
> --
> Ard.
> 
> 
> > ---
> >  EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.c | 2
> +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> a/EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.c
> b/EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.c
> > index 9c8ef5bfb5..1aec86fffd 100644
> > --- a/EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.c
> > +++ b/EmbeddedPkg/Library/NonCoherentDmaLib/NonCoherentDmaLib.c
> > @@ -224,7 +224,7 @@ DmaMap (
> >        goto FreeMapInfo;
> >      }
> >
> > -    if (Map->Operation == MapOperationBusMasterRead) {
> > +    if (Operation == MapOperationBusMasterRead) {
> >        CopyMem (Map->BufferAddress, (VOID *)(UINTN)HostAddress,
> *NumberOfBytes);
> >      }
> >      mCpu->FlushDataCache (mCpu, (UINTN)Map->BufferAddress,
> AllocSize,
> > --
> > 2.13.7
> >
> 
> 
> 
>