回复: [edk2-devel] [PATCH 0/3] [RFC] consolidate compiler intrinsics

["gaoliming" <gaoliming@byosoft.com.cn>]

Gerd:
  I suggest to submit the different BZs for those tasks. This patch set is
the first stage. Future enhancement can be added later.

  If no more comment for the first stage, this patch set can be merged
first.

Thanks
Liming
> -----邮件原件-----
> 发件人: Gerd Hoffmann <kraxel@redhat.com>
> 发送时间: 2022年3月16日 17:46
> 收件人: devel@edk2.groups.io; michael.d.kinney@intel.com
> 抄送: Sean Brogan <sean.brogan@microsoft.com>; Lu, Xiaoyu1
> <xiaoyu1.lu@intel.com>; Feng, Bob C <bob.c.feng@intel.com>; Rebecca Cran
> <rebecca@bsdio.com>; James Bottomley <jejb@linux.ibm.com>; Sami
> Mujawar <Sami.Mujawar@arm.com>; Justen, Jordan L
> <jordan.l.justen@intel.com>; Aktas, Erdem <erdemaktas@google.com>; Yao,
> Jiewen <jiewen.yao@intel.com>; Supreeth Venkatesh
> <supreeth.venkatesh@arm.com>; Boeuf, Sebastien
> <sebastien.boeuf@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; Liu,
> Zhiguang <zhiguang.liu@intel.com>; Maciej Rabeda
> <maciej.rabeda@linux.intel.com>; Ma, Maurice <maurice.ma@intel.com>;
> Andrew Fish <afish@apple.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Tom Lendacky <thomas.lendacky@amd.com>;
> Peter Grehan <grehan@freebsd.org>; Jiang, Guomin
> <guomin.jiang@intel.com>; Bret Barkelew <Bret.Barkelew@microsoft.com>;
> Chen, Christine <yuwei.chen@intel.com>; You, Benjamin
> <benjamin.you@intel.com>; Schaefer, Daniel <daniel.schaefer@hpe.com>;
> Gao, Liming <gaoliming@byosoft.com.cn>; Xu, Wei6 <wei6.xu@intel.com>;
> Wang, Jian J <jian.j.wang@intel.com>; Wu, Jiaxin <jiaxin.wu@intel.com>;
Fu,
> Siyuan <siyuan.fu@intel.com>; Dong, Guo <guo.dong@intel.com>;
> kilian_kegel@hotmail.com; Chang, Abner <abner.chang@hpe.com>; Oliver
> Steffen <osteffen@redhat.com>; Leif Lindholm <quic_llindhol@quicinc.com>;
> Brijesh Singh <brijesh.singh@amd.com>; Xu, Min M <min.m.xu@intel.com>;
> Ni, Ray <ray.ni@intel.com>; Alexei Fedorov <Alexei.Fedorov@arm.com>;
> Julien Grall <julien@xen.org>; Wang, Nickle <nickle.wang@hpe.com>; Pawel
> Polawski <ppolawsk@redhat.com>; Anthony Perard
> <anthony.perard@citrix.com>
> 主题: Re: [edk2-devel] [PATCH 0/3] [RFC] consolidate compiler intrinsics
> 
> On Tue, Mar 15, 2022 at 03:27:58PM +0000, Michael D Kinney wrote:
> > Hi Gerd,
> >
> > Thanks for working on this.  I raised this topic in the new TianoCore
build
> and CI
> > meeting yesterday because the intrinsic libs are closely tied to the
> toolchains
> > supported by TianoCore.
> >
> > I agree with the concept of moving the compiler intrinsics to a library
in the
> MdePkg.
> >
> > + Sean Brogan
> >
> > Sean mentioned that he has some addition work on intrinsic libs for
Visual
> Studio
> > toolchains.  It would be good to see if this set of changes is aligned
with
> those
> > efforts.
> 
> Having a single place where all compiler intrinsics are located should
> simplify this kind of changes.
> 
> > I see a few items that might be good to clean up at some point
> > * fltused should go into its own file.  Not related to the strcmp() API
> > * I see size_t defined in multiple places using different mappings.
Would
> be good to
> >   define that in a single location.
> 
> Yes, sure.  Both are valid points.
> 
> I see this series as first step, consolidating the existing code in a
> singe place with (almost) no actual code changes.  There surely will be
> incremental improvements and cleanups later on.  I will need a few more
> intrinsic functions when moving edk2 to openssl 3.0 for example.
> 
> take care,
>   Gerd