From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web10.6473.1675307435180076643 for ; Wed, 01 Feb 2023 19:10:35 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=p+vV0HGA; spf=pass (domain: byosoft.com.cn, ip: 121.46.250.151, mailfrom: gaoliming@byosoft.com.cn) Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 39456DDA84C for ; Thu, 2 Feb 2023 11:10:32 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1675307432; bh=IQT1bavxKxSGoZIkfpP4DdXDr79tZMsd71yXJKfDjM4=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=p+vV0HGA1Iolo/eSDg03q1wQ305JOIdWTygEkwdO9grtV/ELwNReudwWpi8QPXhhc lGVc6E9h4mki9IXjpVh2Ds049gIILqh9b+GjAyK0oH682JmrEGzK0WDK3O8drM/k3J EMV85xWPQa537UT44Fq0ZI2JNQHFXctFxU2dAX/Q= Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 34CB8DDA7B1 for ; Thu, 2 Feb 2023 11:10:32 +0800 (CST) Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id 04C68DDA78A for ; Thu, 2 Feb 2023 11:10:32 +0800 (CST) Authentication-Results: cxsh.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id 944C5DDA7DC for ; Thu, 2 Feb 2023 11:10:28 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 02 Feb 2023 11:10:25 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Liu, Zhiguang'" , , "'Wang, Jian J'" Cc: "'Ni, Ray'" References: <1738869DA53A568A.3916@groups.io> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBNZGVNb2R1bGVQa2c6IERpc2FtYmlndWF0ZSB0aGUgbWVhbmluZyBvZiBQY2REeGVJcGxTd2l0Y2hUb0xvbmdNb2Rl?= Date: Thu, 2 Feb 2023 11:10:27 +0800 Message-ID: <018a01d936b3$e6716fa0$b3544ee0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQE3UZoqHR7j+zTEB7rs4vcjf56A7gLgzOsPr+e+JmA= Sender: "gaoliming" Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn It is good to me. Reviewed-by: Liming Gao > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: Liu, Zhiguang > =B7=A2=CB=CD=CA=B1=BC=E4: 2023=C4=EA2=D4=C21=C8=D5 13:28 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; Liu, Zhiguang ; Gao, > Liming ; Wang, Jian J > =B3=AD=CB=CD: Ni, Ray > =D6=F7=CC=E2: RE: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the mea= ning > of PcdDxeIplSwitchToLongMode >=20 > Hi Liming and Jian, >=20 > What do you think about this patch? >=20 > Thanks > Zhiguang >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > > Zhiguang Liu > > Sent: Monday, January 9, 2023 11:34 AM > > To: devel@edk2.groups.io > > Cc: Liu, Zhiguang ; Wang, Jian J > > ; Gao, Liming ; Ni, Ra= y > > > > Subject: [edk2-devel] [PATCH] MdeModulePkg: Disambiguate the meaning > > of PcdDxeIplSwitchToLongMode > > > > Literally, the meaning of PcdDxeIplSwitchToLongMode is clear, indicatin= g > > whether need switch to long mode when loading DxeCore. > > However, the comments in dec are confusing for the case where PEI core > > and DXE core are both in 64-bit. This patch makes it clear. > > PcdDxeIplSwitchToLongMode is true only when PEI core is 32-bit, and switch > > to long mode to load 64-bit DXE core. In other cases, this PCD is false= . > > This also aligns with current usage in OvmfPkg. > > > > Cc: Jian J Wang > > Cc: Liming Gao > > Cc: Ray Ni > > Signed-off-by: Zhiguang Liu > > --- > > MdeModulePkg/MdeModulePkg.dec | 4 +--- > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > diff --git a/MdeModulePkg/MdeModulePkg.dec > > b/MdeModulePkg/MdeModulePkg.dec index be5e829ca9..5e4535e353 > > 100644 > > --- a/MdeModulePkg/MdeModulePkg.dec > > +++ b/MdeModulePkg/MdeModulePkg.dec > > @@ -922,10 +922,8 @@ > > > > [PcdsFeatureFlag.IA32, PcdsFeatureFlag.X64] > > ## Indicates if DxeIpl should switch to long mode to enter DXE phase= . > > - # It is assumed that 64-bit DxeCore is built in firmware if it is true; > > otherwise 32-bit DxeCore > > - # is built in firmware.

> > # TRUE - DxeIpl will load a 64-bit DxeCore and switch to long > mode to hand > > over to DxeCore.
> > - # FALSE - DxeIpl will load a 32-bit DxeCore and perform stack switch > to > > hand over to DxeCore.
> > + # FALSE - DxeIpl will load a 32-bit or 64-bit DxeCore and perform > stack > > switch to hand over to DxeCore.
> > # @Prompt DxeIpl switch to long mode. > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE|B > > OOLEAN|0x0001003b > > > > -- > > 2.31.1.windows.1 > > > > > > > >=20 > >