Re: [PATCH v1 13/18] StandaloneMmPkg/Core: Implementation of Standalone MM Core Module.

[Laszlo Ersek <lersek@redhat.com>]

On 04/30/18 21:28, Ard Biesheuvel wrote:
> On 30 April 2018 at 21:19, Achin Gupta <achin.gupta@arm.com> wrote:
>> Hi Supreeth,
>>
>> I think it is worth adding a signed off by Jiewen since he originally
>> contributed the code and it has not changed much since.
> 
> I disagree. A signoff does not assert authorship, it only means that
> the contributor asserts that the license permits him to contribute
> this code under the tianocore contribution agreement. Adding a signoff
> on behalf of someone else should be avoided in my opinion, because it
> suggests that code can only be contributed by the original author.
> Also, even if the author made the code available under a compatible
> license, it does not mean he subscribes to the Tianocore contribution
> agreement, and adding a signoff on behalf of someone else does imply
> that (although this should not be a problem in this particular case)
> 
> Anyone can contribute code that is available under a compatible
> license, and it is not generally possible to decide who should be
> credited as authors for code that originates in other projects.
> 
> If you want to credit the author, you can do that in the commit log.

Right, this is consistent with Ard's earlier explanation of the subject
-- it's something that's proved surprisingly difficult for me to
remember as well. Thankfully Ard keeps us in check :)

Laszlo