From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4E00A2033D1B5 for ; Tue, 1 May 2018 01:18:57 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 68D49406C753; Tue, 1 May 2018 08:18:56 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-64.rdu2.redhat.com [10.10.120.64]) by smtp.corp.redhat.com (Postfix) with ESMTP id 71BDA215CDA7; Tue, 1 May 2018 08:18:54 +0000 (UTC) To: Ard Biesheuvel , Achin Gupta , "Kinney, Michael D" , Leif Lindholm , Andrew Fish Cc: Supreeth Venkatesh , "edk2-devel@lists.01.org" , "Gao, Liming" , "Yao, Jiewen" , nd References: <20180406144223.10931-1-supreeth.venkatesh@arm.com> <20180406144223.10931-14-supreeth.venkatesh@arm.com> <20180430191942.GX663@e104320-lin> From: Laszlo Ersek Message-ID: <018aef53-a29b-0496-9777-b0bdd920eced@redhat.com> Date: Tue, 1 May 2018 10:18:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 01 May 2018 08:18:56 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.5]); Tue, 01 May 2018 08:18:56 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH v1 13/18] StandaloneMmPkg/Core: Implementation of Standalone MM Core Module. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 May 2018 08:18:58 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 04/30/18 21:28, Ard Biesheuvel wrote: > On 30 April 2018 at 21:19, Achin Gupta wrote: >> Hi Supreeth, >> >> I think it is worth adding a signed off by Jiewen since he originally >> contributed the code and it has not changed much since. > > I disagree. A signoff does not assert authorship, it only means that > the contributor asserts that the license permits him to contribute > this code under the tianocore contribution agreement. Adding a signoff > on behalf of someone else should be avoided in my opinion, because it > suggests that code can only be contributed by the original author. > Also, even if the author made the code available under a compatible > license, it does not mean he subscribes to the Tianocore contribution > agreement, and adding a signoff on behalf of someone else does imply > that (although this should not be a problem in this particular case) > > Anyone can contribute code that is available under a compatible > license, and it is not generally possible to decide who should be > credited as authors for code that originates in other projects. > > If you want to credit the author, you can do that in the commit log. Right, this is consistent with Ard's earlier explanation of the subject -- it's something that's proved surprisingly difficult for me to remember as well. Thankfully Ard keeps us in check :) Laszlo