回复: [PATCH V2 1/1] BaseTools/tools_def.template: Update -march parameter for RISC-V

["gaoliming" <gaoliming@byosoft.com.cn>]

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> 发送时间: 2023年2月22日 10:39
> 收件人: Sunil V L <sunilvl@ventanamicro.com>; devel@edk2.groups.io
> 抄送: Bob Feng <bob.c.feng@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Yuwei Chen <yuwei.chen@intel.com>; Andrei
> Warkentin <andrei.warkentin@intel.com>; Gerd Hoffmann
> <kraxel@redhat.com>
> 主题: Re: [PATCH V2 1/1] BaseTools/tools_def.template: Update -march
> parameter for RISC-V
> 
> 
> 
> On 2/22/23 03:37, Sunil V L wrote:
> > Replace rv64imafdc with rv64gc so that it works for gcc 12.
> >
> > "g" means imafd in gcc < 12 and imafd_zifencei_zicsr in gcc >= 12.
> > So, replacing rv64imafdc with rv64gc will work for both gcc <12
> > and gcc >=12.
> >
> > Cc: Bob Feng <bob.c.feng@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Yuwei Chen <yuwei.chen@intel.com>
> > Cc: Andrei Warkentin <andrei.warkentin@intel.com>
> > Cc: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> > Signed-off-by: Sunil V L <sunilvl@ventanamicro.com>
> > Tested-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> Tested-by: Heinrich Schuchardt <heinrich.schuchardt@canonical.com>
> 
> > ---
> > Changes since V1:
> > 	1) Updated commit message
> > 	2) Added Tested-by tag from Gerd
> >
> >   BaseTools/Conf/tools_def.template | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/BaseTools/Conf/tools_def.template
> b/BaseTools/Conf/tools_def.template
> > index f77e936c0453..471eb67c0c83 100755
> > --- a/BaseTools/Conf/tools_def.template
> > +++ b/BaseTools/Conf/tools_def.template
> > @@ -1965,7 +1965,7 @@ DEFINE
> GCC5_RISCV_ALL_CC_FLAGS_WARNING_DISABLE    =
> -Wno-tautological-compare -W
> >
> >   DEFINE GCC5_RISCV_OPENSBI_TYPES                   =
> -DOPENSBI_EXTERNAL_SBI_TYPES=OpensbiTypes.h
> >
> > -DEFINE GCC5_RISCV64_ARCH                   = rv64imafdc
> > +DEFINE GCC5_RISCV64_ARCH                   = rv64gc
> >   DEFINE GCC5_RISCV32_RISCV64_ASLDLINK_FLAGS =
> DEF(GCC5_RISCV_ALL_DLINK_COMMON) -Wl,--entry,ReferenceAcpiTable -u
> ReferenceAcpiTable
> >   DEFINE GCC5_RISCV64_CC_FLAGS               =
> DEF(GCC5_RISCV_ALL_CC_FLAGS)
> DEF(GCC5_RISCV_ALL_CC_FLAGS_WARNING_DISABLE)
> DEF(GCC5_RISCV_OPENSBI_TYPES) -march=DEF(GCC5_RISCV64_ARCH)
> -fno-builtin -fno-builtin-memcpy -fno-stack-protector -Wno-address
> -fno-asynchronous-unwind-tables -Wno-unused-but-set-variable
> -fpack-struct=8 -mcmodel=medany -mabi=lp64 -mno-relax
> >   DEFINE GCC5_RISCV64_DLINK_FLAGS            =
> DEF(GCC5_RISCV_ALL_DLINK_FLAGS)
> -Wl,-melf64lriscv,--oformat=elf64-littleriscv,--no-relax