From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 48D5F226085A5 for ; Tue, 3 Apr 2018 05:57:31 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F1A1976FBA; Tue, 3 Apr 2018 12:57:30 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-185.rdu2.redhat.com [10.10.120.185]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2524AD7DFB; Tue, 3 Apr 2018 12:57:27 +0000 (UTC) From: Laszlo Ersek To: edk2-devel-01 Cc: Michael D Kinney , Eric Dong , Liming Gao References: <20180323211504.22434-1-lersek@redhat.com> Message-ID: <018e77df-3d76-a1f4-d265-33a9c4e3b6c8@redhat.com> Date: Tue, 3 Apr 2018 14:57:21 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180323211504.22434-1-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Tue, 03 Apr 2018 12:57:31 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.1]); Tue, 03 Apr 2018 12:57:31 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH v2 00/15] rid PiSmmCpuDxeSmm of DB-encoded instructions X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 03 Apr 2018 12:57:32 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Mike, Liming, Eric, On 03/23/18 22:14, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: patch_insn_x86_v2 > > This is version 2 of the series originally posted at > . > The changes are documented per patch. > > I retested the test cases listed in the v1 blurb. > > Cc: Eric Dong > Cc: Liming Gao > Cc: Michael D Kinney do you have any comments? Thank you! Laszlo > Laszlo Ersek (15): > MdePkg/BaseLib.h: state preprocessing conditions in comments after > #endifs > MdePkg/BaseLib: add PatchInstructionX86() > UefiCpuPkg/PiSmmCpuDxeSmm: remove *.S and *.asm assembly files > UefiCpuPkg/PiSmmCpuDxeSmm: patch "gSmbase" with PatchInstructionX86() > UefiCpuPkg/PiSmmCpuDxeSmm: patch "gSmiStack" with > PatchInstructionX86() > UefiCpuPkg/PiSmmCpuDxeSmm: patch "gSmiCr3" with PatchInstructionX86() > UefiCpuPkg/PiSmmCpuDxeSmm: patch "XdSupported" with > PatchInstructionX86() > UefiCpuPkg/PiSmmCpuDxeSmm: remove unneeded DBs from X64 SmmStartup() > UefiCpuPkg/PiSmmCpuDxeSmm: patch "gSmmCr3" with PatchInstructionX86() > UefiCpuPkg/PiSmmCpuDxeSmm: patch "gSmmCr4" with PatchInstructionX86() > UefiCpuPkg/PiSmmCpuDxeSmm: patch "gSmmCr0" with PatchInstructionX86() > UefiCpuPkg/PiSmmCpuDxeSmm: eliminate "gSmmJmpAddr" and related DBs > UefiCpuPkg/PiSmmCpuDxeSmm: patch "gSmmInitStack" with > PatchInstructionX86() > UefiCpuPkg/PiSmmCpuDxeSmm: remove DBs from > SmmRelocationSemaphoreComplete32() > UefiCpuPkg/PiSmmCpuDxeSmm: use mnemonics for FXSAVE(64)/FXRSTOR(64) > > MdePkg/Include/Library/BaseLib.h | 76 ++- > MdePkg/Library/BaseLib/BaseLib.inf | 2 + > MdePkg/Library/BaseLib/X86PatchInstruction.c | 89 +++ > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 4 +- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.S | 165 ----- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.asm | 168 ----- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.S | 215 ------ > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.asm | 223 ------ > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.nasm | 25 +- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiException.S | 696 ------------------- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiException.asm | 713 -------------------- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiException.nasm | 8 +- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmInit.S | 84 --- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmInit.asm | 94 --- > UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmInit.nasm | 30 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c | 27 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h | 21 +- > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf | 20 - > UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 7 + > UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfileInternal.h | 1 + > UefiCpuPkg/PiSmmCpuDxeSmm/SmramSaveState.c | 20 +- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.S | 204 ------ > UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.asm | 206 ------ > UefiCpuPkg/PiSmmCpuDxeSmm/X64/Semaphore.c | 16 +- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.S | 243 ------- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.asm | 242 ------- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 31 +- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiException.S | 365 ---------- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiException.asm | 383 ----------- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiException.nasm | 4 +- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.S | 141 ---- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.asm | 132 ---- > UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.nasm | 76 +-- > 33 files changed, 295 insertions(+), 4436 deletions(-) > create mode 100644 MdePkg/Library/BaseLib/X86PatchInstruction.c > delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.S > delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/MpFuncs.asm > delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.S > delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.asm > delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiException.S > delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiException.asm > delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmInit.S > delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmInit.asm > delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.S > delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/X64/MpFuncs.asm > delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.S > delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.asm > delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiException.S > delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiException.asm > delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.S > delete mode 100644 UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmInit.asm >