回复: 回复: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and Library Matching

["gaoliming via groups.io" <gaoliming=byosoft.com.cn@groups.io>]

Taylor:
  Thanks for you detail information. I understand this problem. I agree your fix. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Taylor Beebe
> 发送时间: 2024年3月29日 8:28
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: 'Rebecca Cran' <rebecca@bsdio.com>; 'Bob Feng'
> <bob.c.feng@intel.com>; 'Yuwei Chen' <yuwei.chen@intel.com>
> 主题: Re: 回复: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include
> and Library Matching
> 
> Hi Liming,
> 
> Each patch describes the issue being fixed with an example.
> 
> I created a bugzilla and assigned it to me for Patch 1:
> https://bugzilla.tianocore.org/show_bug.cgi?id=4744
> 
> GitHub PR: https://github.com/tianocore/edk2/pull/5365
> 
> Thanks :)
> 
> -Taylor
> 
> On 3/27/24 6:00 PM, gaoliming wrote:
> > Can you submit a Bugzilla for this problem?
> >
> > Can you give one example to explain the incorrect usage?
> >
> > Thanks
> > Liming
> >> -----邮件原件-----
> >> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Taylor
> Beebe
> >> 发送时间: 2024年3月23日 3:19
> >> 收件人: devel@edk2.groups.io
> >> 抄送: Rebecca Cran <rebecca@bsdio.com>; Liming Gao
> >> <gaoliming@byosoft.com.cn>; Bob Feng <bob.c.feng@intel.com>; Yuwei
> Chen
> >> <yuwei.chen@intel.com>
> >> 主题: [edk2-devel] [PATCH v2 0/2] Update BaseTools NULL Include and
> >> Library Matching
> >>
> >> v1:
> >>    - Initial patch series
> >> v2:
> >>    - Simplified the check for if the currently evaluated inf is a module or
> >> library.
> >>    - Added a commit to use stronger matching of NULL includes (check
> for
> >> pattern "NULL<n>")
> >>
> >> Cc: Rebecca Cran <rebecca@bsdio.com>
> >> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> >> Cc: Bob Feng <bob.c.feng@intel.com>
> >> Cc: Yuwei Chen <yuwei.chen@intel.com>
> >>
> >> Taylor Beebe (2):
> >>    BaseTools: Don't Recurse NULL Includes Not Linked to Module
> >>    BaseTools: Use Stronger Matching for NULL Linked Libraries
> >>
> >>   BaseTools/Source/Python/GenFds/FfsInfStatement.py    | 4 ++--
> >>   BaseTools/Source/Python/Workspace/WorkspaceCommon.py | 8
> +++++---
> >>   2 files changed, 7 insertions(+), 5 deletions(-)
> >>
> >> --
> >> 2.40.1.vfs.0.0
> >>
> >>
> >>
> >>
> >>
> >
> >
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#117304): https://edk2.groups.io/g/devel/message/117304
Mute This Topic: https://groups.io/mt/105280288/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-