public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Liming Gao <liming.gao@intel.com>, edk2-devel@lists.01.org
Subject: Re: [Patch] BaseTools: Remove unused txt files
Date: Sat, 16 Feb 2019 00:00:27 +0100	[thread overview]
Message-ID: <019225eb-afb0-8683-438f-34050c95a4c0@redhat.com> (raw)
In-Reply-To: <20190215143218.18100-1-liming.gao@intel.com>

On 02/15/19 15:32, Liming Gao wrote:
> externals.txt is to refer to the binary Win32. It is not used any longer.
> BuildNotes.txt is to freeze BaseTools python. It is not used any longer.
> BinaryFiles.txt is to list the file in Bin directory. But, Bin dir is empty.
> building-gcc.txt and gcc is for mingw-gcc. It is not used any longer.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  BaseTools/Bin/externals.txt      |   1 -
>  BaseTools/BuildNotes.txt         |  83 ------
>  BaseTools/Source/BinaryFiles.txt |  79 ------
>  BaseTools/building-gcc.txt       |  15 --
>  BaseTools/gcc/README.txt         |  71 -----
>  BaseTools/gcc/mingw-gcc-build.py | 565 ---------------------------------------
>  6 files changed, 814 deletions(-)
>  delete mode 100644 BaseTools/Bin/externals.txt
>  delete mode 100644 BaseTools/BuildNotes.txt
>  delete mode 100644 BaseTools/Source/BinaryFiles.txt
>  delete mode 100644 BaseTools/building-gcc.txt
>  delete mode 100644 BaseTools/gcc/README.txt
>  delete mode 100755 BaseTools/gcc/mingw-gcc-build.py

Sounds reasonable. I don't remember looking at these files, ever.

Acked-by: Laszlo Ersek <lersek@redhat.com>

Thanks,
Laszlo


  reply	other threads:[~2019-02-15 23:00 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-15 14:32 [Patch] BaseTools: Remove unused txt files Liming Gao
2019-02-15 23:00 ` Laszlo Ersek [this message]
2019-02-19 13:58 ` Feng, Bob C

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=019225eb-afb0-8683-438f-34050c95a4c0@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox