From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from walk.intel-email.com (walk.intel-email.com [101.227.64.242]) by mx.groups.io with SMTP id smtpd.web10.490.1667794987959476984 for ; Sun, 06 Nov 2022 20:23:08 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@byosoft.com.cn header.s=cloud-union header.b=Ke/3VlXw; spf=pass (domain: byosoft.com.cn, ip: 101.227.64.242, mailfrom: gaoliming@byosoft.com.cn) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 91AFDCD1F6D4 for ; Mon, 7 Nov 2022 12:23:05 +0800 (CST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=byosoft.com.cn; s=cloud-union; t=1667794985; bh=oHxFlQxeea+hTaYyVFC/ByLMhS5yQUCFIQGl0tWr2As=; h=From:To:Cc:References:In-Reply-To:Subject:Date; b=Ke/3VlXwYv5N5v9BpCamoC4WG4A6kRlaTpfbb4Ei2RSozA9OIzIfzxeHj0C4wQf++ RsgRCI7iXkByyrk13BTmQ8jQksfpgGW/xuSACwrLxlnr/vW/NX1RZDd2bWbEUYl24n VDqR7dLoceBdToND1iuSLSwgtjJbcCAzMO9qctH0= Received: from localhost (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 8CFDDCD1F683 for ; Mon, 7 Nov 2022 12:23:05 +0800 (CST) Received: from walk.intel-email.com (localhost [127.0.0.1]) by walk.intel-email.com (Postfix) with ESMTP id 604CDCD1F6EE for ; Mon, 7 Nov 2022 12:23:05 +0800 (CST) Authentication-Results: walk.intel-email.com; none Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by walk.intel-email.com (Postfix) with SMTP id D4A4CCD1F6DF for ; Mon, 7 Nov 2022 12:23:02 +0800 (CST) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 07 Nov 2022 12:23:01 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: "'Michael D Kinney'" , Cc: "'Bob Feng'" , "'Yuwei Chen'" References: <20221105203536.1559-1-michael.d.kinney@intel.com> In-Reply-To: <20221105203536.1559-1-michael.d.kinney@intel.com> Subject: =?UTF-8?B?5Zue5aSNOiBbUGF0Y2ggMS8xXSBCYXNlVG9vbHMvU291cmNlL0M6IFVzZSAvWjcgaW5zdGVhZCBvZiAvWmkgZm9yIGhvc3QgdG9vbHM=?= Date: Mon, 7 Nov 2022 12:23:00 +0800 Message-ID: <019501d8f260$9f2194f0$dd64bed0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQI3bM1RRZg3F7dM/jU9dlifsWhGVK115t+w Sender: "gaoliming" Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Mike: I suggest to remove /Zi and /DEBUG option for BaseTools C tool = generation, because only tool developer may require the debug version C tool.=20 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: Michael D Kinney > =B7=A2=CB=CD=CA=B1=BC=E4: 2022=C4=EA11=D4=C26=C8=D5 4:36 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Bob Feng ; Liming Gao > ; Yuwei Chen > =D6=F7=CC=E2: [Patch 1/1] BaseTools/Source/C: Use /Z7 instead of /Zi = for host tools >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D4139 >=20 > Update ms.common and *.mak files to use /Z7 instead of /Zi to embed > symbol information in obj files for host tools built with VS = compilers. > This prevents vcxxx.pdb files from being generated in the root of > the local edk2 repository or in BaseTools directories. >=20 > Cc: Bob Feng > Cc: Liming Gao > Cc: Yuwei Chen > Signed-off-by: Michael D Kinney > --- > BaseTools/Source/C/Makefiles/ms.common | 5 ++--- > BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrDDK.mak | 4 ++-- > BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrMS.mak | 6 +++--- > BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgDDK.mak | 4 ++-- > BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgMS.mak | 7 +++---- > 5 files changed, 12 insertions(+), 14 deletions(-) >=20 > diff --git a/BaseTools/Source/C/Makefiles/ms.common > b/BaseTools/Source/C/Makefiles/ms.common > index b2dbcf376c04..8391f10d5dd2 100644 > --- a/BaseTools/Source/C/Makefiles/ms.common > +++ b/BaseTools/Source/C/Makefiles/ms.common > @@ -57,6 +57,5 @@ LINKER =3D $(LD) >=20 > INC =3D $(INC) -I . -I $(SOURCE_PATH)\Include -I $(ARCH_INCLUDE) -I > $(SOURCE_PATH)\Common >=20 > -CFLAGS =3D $(CFLAGS) /nologo /Zi /c /O2 /MT /W4 /WX /D > _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE > -CPPFLAGS =3D $(CPPFLAGS) /EHsc /nologo /Zi /c /O2 /MT /D > _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE > - > +CFLAGS =3D $(CFLAGS) /nologo /Z7 /c /O2 /MT /W4 /WX /D > _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE > +CPPFLAGS =3D $(CPPFLAGS) /EHsc /nologo /Z7 /c /O2 /MT /D > _CRT_SECURE_NO_DEPRECATE /D _CRT_NONSTDC_NO_DEPRECATE > diff --git a/BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrDDK.mak > b/BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrDDK.mak > index 71b7c6b0b141..cde91a47159e 100644 > --- a/BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrDDK.mak > +++ b/BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrDDK.mak > @@ -16,7 +16,7 @@ SET=3D$(PCCTS_HOME)\support\set > # Compiler stuff > CC =3D cl > CFLAGS =3D /nologo -I "." -I "$(PCCTS_H)" -I "$(SET)" -D "USER_ZZSYN" = -D "PC" > \ > - -D "ZZLEXBUFSIZE=3D65536" -D "LONGFILENAMES" /Zi /W3 > -D__USE_PROTOS /wd4700 > + -D "ZZLEXBUFSIZE=3D65536" -D "LONGFILENAMES" /Z7 /W3 > -D__USE_PROTOS /wd4700 >=20 > ANTLR_OBJS =3D antlr.obj scan.obj err.obj bits.obj build.obj = fset2.obj \ > fset.obj gen.obj globals.obj hash.obj lex.obj main.obj \ > @@ -225,7 +225,7 @@ set.obj: $(SET)\set.c \ >=20 > $(CC) -c $(CFLAGS) $(SET)\set.c >=20 > -clean: > +clean: > del *.obj >=20 > distclean: > diff --git a/BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrMS.mak > b/BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrMS.mak > index b30a73bb7424..6fc4d5c15d6c 100644 > --- a/BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrMS.mak > +++ b/BaseTools/Source/C/VfrCompile/Pccts/antlr/AntlrMS.mak > @@ -16,8 +16,8 @@ SET=3D$(PCCTS_HOME)\support\set > # Compiler stuff > CC =3D cl > CFLAGS =3D /nologo -I "." -I "$(PCCTS_H)" -I "$(SET)" -D "USER_ZZSYN" = -D "PC" > \ > - -D "ZZLEXBUFSIZE=3D65536" /D "LONGFILENAMES" /Zi /W3 > -D__USE_PROTOS /wd4700 \ > - /D _CRT_SECURE_NO_DEPRECATE /D > _CRT_NONSTDC_NO_DEPRECATE > + -D "ZZLEXBUFSIZE=3D65536" /D "LONGFILENAMES" /Z7 /W3 > -D__USE_PROTOS /wd4700 \ > + /D _CRT_SECURE_NO_DEPRECATE /D > _CRT_NONSTDC_NO_DEPRECATE >=20 > ANTLR_OBJS =3D antlr.obj scan.obj err.obj bits.obj build.obj = fset2.obj \ > fset.obj gen.obj globals.obj hash.obj lex.obj main.obj \ > @@ -226,7 +226,7 @@ set.obj: $(SET)\set.c \ >=20 > $(CC) -c $(CFLAGS) $(SET)\set.c >=20 > -clean: > +clean: > -del *.obj > -del *.ilk > -del *.pdb > diff --git a/BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgDDK.mak > b/BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgDDK.mak > index 156d524acc94..dcc259543c4c 100644 > --- a/BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgDDK.mak > +++ b/BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgDDK.mak > @@ -16,7 +16,7 @@ SET=3D$(PCCTS_HOME)\support\set > # Compiler stuff > CC =3D cl > CFLAGS =3D /nologo -I "." -I "$(PCCTS_H)" -I "$(SET)" -D "USER_ZZSYN" = -D "PC" > \ > - -D "ZZLEXBUFSIZE=3D65536" /D "LONGFILENAMES" /W3 /Zi > + -D "ZZLEXBUFSIZE=3D65536" /D "LONGFILENAMES" /W3 /Z7 >=20 > DLG_OBJS =3D dlg_p.obj dlg_a.obj main.obj err.obj support.obj \ > output.obj relabel.obj automata.obj > @@ -113,7 +113,7 @@ set.obj: $(SET)\set.c \ >=20 > $(CC) -c $(CFLAGS) $(SET)\set.c >=20 > -clean: > +clean: > del *.obj >=20 > distclean: > diff --git a/BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgMS.mak > b/BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgMS.mak > index 2714308d4fa0..c2cac00f53df 100644 > --- a/BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgMS.mak > +++ b/BaseTools/Source/C/VfrCompile/Pccts/dlg/DlgMS.mak > @@ -16,8 +16,8 @@ SET=3D$(PCCTS_HOME)\support\set > # Compiler stuff > CC =3D cl > CFLAGS =3D /nologo -I "." -I "$(PCCTS_H)" -I "$(SET)" -D "USER_ZZSYN" = -D "PC" > \ > - -D "ZZLEXBUFSIZE=3D65536" /D "LONGFILENAMES" /W3 /Zi \ > - /D _CRT_SECURE_NO_DEPRECATE /D > _CRT_NONSTDC_NO_DEPRECATE > + -D "ZZLEXBUFSIZE=3D65536" /D "LONGFILENAMES" /W3 /Z7 \ > + /D _CRT_SECURE_NO_DEPRECATE /D > _CRT_NONSTDC_NO_DEPRECATE >=20 > DLG_OBJS =3D dlg_p.obj dlg_a.obj main.obj err.obj support.obj \ > output.obj relabel.obj automata.obj > @@ -112,7 +112,7 @@ set.obj: $(SET)\set.c \ >=20 > $(CC) -c $(CFLAGS) $(SET)\set.c >=20 > -clean: > +clean: > -del *.obj > -del *.ilk > -del *.pdb > @@ -123,4 +123,3 @@ cleanall: > -del *.pdb > -del *.exe > -del $(EDK_TOOLS_PATH)\Bin\Win32\dlg.exe > - > -- > 2.37.1.windows.1