[PATCH 1/1] MdePkg: Label CreateEvent NotifyFunction and NotifyContext optional

[PATCH 1/1] MdePkg: Label CreateEvent NotifyFunction and NotifyContext optional

[Rebecca Cran]

According to the UEFI 2.10 Specification, the EFI_BOOT_SERVICES_TABLE
CreateEvent function has the following signature:

typedef
EFI_STATUS
(EFIAPI *EFI_CREATE_EVENT) (
  IN UINT32           Type,
  IN EFI_TPL          NotifyTpl,
  IN EFI_EVENT_NOTIFY NotifyFunction, OPTIONAL
  IN VOID             *NotifyContext, OPTIONAL
  OUT EFI_EVENT       *Event
);

Fix the prototype in UefiSpec.h to match, by labeling the NotifyFunction
and NotifyContext parameters as OPTIONAL.

Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
---
 MdePkg/Include/Uefi/UefiSpec.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/MdePkg/Include/Uefi/UefiSpec.h b/MdePkg/Include/Uefi/UefiSpec.h
index 3abebbb8d904..7dfe35b4990b 100644
--- a/MdePkg/Include/Uefi/UefiSpec.h
+++ b/MdePkg/Include/Uefi/UefiSpec.h
@@ -465,8 +465,8 @@ EFI_STATUS
 (EFIAPI *EFI_CREATE_EVENT)(
   IN  UINT32                       Type,
   IN  EFI_TPL                      NotifyTpl,
-  IN  EFI_EVENT_NOTIFY             NotifyFunction,
-  IN  VOID                         *NotifyContext,
+  IN  EFI_EVENT_NOTIFY             NotifyFunction OPTIONAL,
+  IN  VOID                         *NotifyContext OPTIONAL,
   OUT EFI_EVENT                    *Event
   );
 
-- 
2.25.1

回复: [PATCH 1/1] MdePkg: Label CreateEvent NotifyFunction and NotifyContext optional

[gaoliming]

Rebecca:
  CreateEvent implementation in DxeMain has followed this definition. So,
only this change is required. 

  Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn> for this patch. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Rebecca Cran <rebecca@bsdio.com>
> 发送时间: 2022年12月24日 7:48
> 收件人: devel@edk2.groups.io; Michael D Kinney
> <michael.d.kinney@intel.com>; Liming Gao <gaoliming@byosoft.com.cn>;
> Zhiguang Liu <zhiguang.liu@intel.com>
> 抄送: Rebecca Cran <rebecca@bsdio.com>
> 主题: [PATCH 1/1] MdePkg: Label CreateEvent NotifyFunction and
> NotifyContext optional
> 
> According to the UEFI 2.10 Specification, the EFI_BOOT_SERVICES_TABLE
> CreateEvent function has the following signature:
> 
> typedef
> EFI_STATUS
> (EFIAPI *EFI_CREATE_EVENT) (
>   IN UINT32           Type,
>   IN EFI_TPL          NotifyTpl,
>   IN EFI_EVENT_NOTIFY NotifyFunction, OPTIONAL
>   IN VOID             *NotifyContext, OPTIONAL
>   OUT EFI_EVENT       *Event
> );
> 
> Fix the prototype in UefiSpec.h to match, by labeling the NotifyFunction
> and NotifyContext parameters as OPTIONAL.
> 
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  MdePkg/Include/Uefi/UefiSpec.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MdePkg/Include/Uefi/UefiSpec.h
> b/MdePkg/Include/Uefi/UefiSpec.h
> index 3abebbb8d904..7dfe35b4990b 100644
> --- a/MdePkg/Include/Uefi/UefiSpec.h
> +++ b/MdePkg/Include/Uefi/UefiSpec.h
> @@ -465,8 +465,8 @@ EFI_STATUS
>  (EFIAPI *EFI_CREATE_EVENT)(
>    IN  UINT32                       Type,
>    IN  EFI_TPL                      NotifyTpl,
> -  IN  EFI_EVENT_NOTIFY             NotifyFunction,
> -  IN  VOID                         *NotifyContext,
> +  IN  EFI_EVENT_NOTIFY             NotifyFunction OPTIONAL,
> +  IN  VOID                         *NotifyContext OPTIONAL,
>    OUT EFI_EVENT                    *Event
>    );
> 
> --
> 2.25.1