Openssl submodule

Openssl submodule

[TVKR]

Hi,

It is not clear if the recent change to add OpenSSL as a submodule will
pull the code from the master branch of "https://github.com/openssl/openssl"
or any other branch like "OpenSSL_1_1_0-stable" or "OpenSSL_1_1_1-stable".
Can some one please clarify?

Thanks

Re: Openssl submodule

[Knop, Ryszard]

Hi,
Git submodules generally point at a specific commit, so if you go to https://github.com/tianocore/edk2/tree/master/CryptoPkg/Library/OpensslLib and click on the openssl submodule, you'll go to the exact referenced commit (currently d4e4bd2, pointing at the 1.1.0h release). It doesn't point at any specific branch because it's a moving target.
Richard

-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of TVKR
Sent: Friday, October 5, 2018 16:55
To: edk2-devel@lists.01.org
Subject: [edk2] Openssl submodule

Hi,

It is not clear if the recent change to add OpenSSL as a submodule will pull the code from the master branch of "https://github.com/openssl/openssl"
or any other branch like "OpenSSL_1_1_0-stable" or "OpenSSL_1_1_1-stable".
Can some one please clarify?

Thanks
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
--------------------------------------------------------------------

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.

Re: Openssl submodule

[Laszlo Ersek]

On 10/05/18 17:53, Knop, Ryszard wrote:
> Hi,
> Git submodules generally point at a specific commit, so if you go to https://github.com/tianocore/edk2/tree/master/CryptoPkg/Library/OpensslLib and click on the openssl submodule, you'll go to the exact referenced commit (currently d4e4bd2, pointing at the 1.1.0h release). It doesn't point at any specific branch because it's a moving target.

Right.

See the "OpenSSL-Version" section in the file
"CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt". It explains how
CryptoPkg maintainers advance edk2's reference inside OpenSSL's git history.

Thanks
Laszlo

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of TVKR
> Sent: Friday, October 5, 2018 16:55
> To: edk2-devel@lists.01.org
> Subject: [edk2] Openssl submodule
> 
> Hi,
> 
> It is not clear if the recent change to add OpenSSL as a submodule will pull the code from the master branch of "https://github.com/openssl/openssl"
> or any other branch like "OpenSSL_1_1_0-stable" or "OpenSSL_1_1_1-stable".
> Can some one please clarify?
> 
> Thanks
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> --------------------------------------------------------------------
> 
> Intel Technology Poland sp. z o.o.
> ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
> 
> Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
> przegladanie lub rozpowszechnianie jest zabronione.
> This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
> others is strictly prohibited.
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
> 

Re: Openssl submodule

[Laszlo Ersek]

On 10/05/18 23:02, Laszlo Ersek wrote:
> On 10/05/18 17:53, Knop, Ryszard wrote:
>> Hi,
>> Git submodules generally point at a specific commit, so if you go to https://github.com/tianocore/edk2/tree/master/CryptoPkg/Library/OpensslLib and click on the openssl submodule, you'll go to the exact referenced commit (currently d4e4bd2, pointing at the 1.1.0h release). It doesn't point at any specific branch because it's a moving target.
> 
> Right.
> 
> See the "OpenSSL-Version" section in the file
> "CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt". It explains how
> CryptoPkg maintainers advance edk2's reference inside OpenSSL's git history.

Apologies, I forgot to mention:

https://bugzilla.tianocore.org/show_bug.cgi?id=1089

Laszlo

>> -----Original Message-----
>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of TVKR
>> Sent: Friday, October 5, 2018 16:55
>> To: edk2-devel@lists.01.org
>> Subject: [edk2] Openssl submodule
>>
>> Hi,
>>
>> It is not clear if the recent change to add OpenSSL as a submodule will pull the code from the master branch of "https://github.com/openssl/openssl"
>> or any other branch like "OpenSSL_1_1_0-stable" or "OpenSSL_1_1_1-stable".
>> Can some one please clarify?
>>
>> Thanks
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
>> --------------------------------------------------------------------
>>
>> Intel Technology Poland sp. z o.o.
>> ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.
>>
>> Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
>> przegladanie lub rozpowszechnianie jest zabronione.
>> This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
>> others is strictly prohibited.
>>
>> _______________________________________________
>> edk2-devel mailing list
>> edk2-devel@lists.01.org
>> https://lists.01.org/mailman/listinfo/edk2-devel
>>
>