From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web10.27869.1606092601744270017 for ; Sun, 22 Nov 2020 16:50:03 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 23 Nov 2020 08:49:53 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Kun Qin'" Cc: "'Wang, Jian J'" , "'Lu, XiaoyuX'" , "'Jiang, Guomin'" , , "'Leif Lindholm'" , , References: <20201021023228.1884-1-kun.q@outlook.com> ,<017801d6beff$73c708d0$5b551a70$@byosoft.com.cn> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYxIDEvMV0gQ3J5cHRvUGtnOiBCYXNlQ3J5cHRMaWI6IEZpeCBidWZmZXIgZG91YmxlIGZyZWUgaW4gQ3J5cHRQa2NzN1ZlcmlmeUVrdQ==?= Date: Mon, 23 Nov 2020 08:49:53 +0800 Message-ID: <01af01d6c132$8eba2de0$ac2e89a0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQLkMfLYb5oyIz28ygMtzxfRzLN82QIvQlwQAcnWPaEC6c/d1wHmBlQYA1vwkj+nWNnS8A== Content-Type: multipart/alternative; boundary="----=_NextPart_000_01B0_01D6C175.9CDF69B0" Content-Language: zh-cn ------=_NextPart_000_01B0_01D6C175.9CDF69B0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Jiewen: I am OK to merge this bug fix into this stable tag. If no objection, you = can merge it tomorrow.=20 =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+67779+4905953+8761045@groups.io = =E4=BB=A3=E8=A1=A8 Yao, Jiew= en =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B411=E6=9C=8822=E6=97=A5 = 20:26 =E6=94=B6=E4=BB=B6=E4=BA=BA: Kun Qin ; gaoliming ; devel@edk2.groups.io =E6=8A=84=E9=80=81: Wang, Jian J ; Lu, XiaoyuX ; Jiang, Guomin =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLi= b: Fix buffer double free in CryptPkcs7VerifyEku =20 I can help to merge if it is approved. =20 I will add reviewed-by tag when I merge it. =20 Thank you Yao Jiewen =20 From: Kun Qin >=20 Sent: Sunday, November 22, 2020 3:10 PM To: gaoliming = >; devel@edk2.groups.io ; Yao, Jiewen > Cc: Wang, Jian J >; = Lu, XiaoyuX >; Jiang, G= uomin > Subject: RE: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Fix buff= er double free in CryptPkcs7VerifyEku =20 Hi Liming, =20 It will be great if we can get this in. But I have been having trouble sen= ding a v2 patch that incorporates Jiewen=E2=80=99s =E2=80=9CReviewed-by=E2= =80=9D tag through git command line for the past week (no other changes). = It kept giving me an error of "No host provider available to service this r= equest". Please let me know if you have any suggestions. =20 Thanks, Kun =20 =20 From: gaoliming =20 Sent: Thursday, November 19, 2020 9:39 PM To: devel@edk2.groups.io ; jiewen.yao@intel.= com ; 'Kun Qin' =20 Cc: 'Wang, Jian J' ; 'Lu, XiaoyuX' ; 'Jiang, Guomin' =20 Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCr= yptLib: Fix buffer double free in CryptPkcs7VerifyEku =20 Kun: This is a bug fix. It passed code review. Do you request to merge it for this stable tag 202011? Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+67567+4905953+8761045@groups.i= o =20 > > =E4=BB=A3=E8=A1=A8 Yao, Jiewen > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2020=E5=B9=B411=E6=9C=8814=E6=97= =A5 8:32 > =E6=94=B6=E4=BB=B6=E4=BA=BA: Kun Qin >; devel@edk2.groups.io =20 > =E6=8A=84=E9=80=81: Wang, Jian J >; Lu, XiaoyuX > >; Jiang, Guomin >; Yao, > Jiewen > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCrypt= Lib: Fix buffer > double free in CryptPkcs7VerifyEku >=20 > Sorry, I missed this email. >=20 > Reviewed-by: Jiewen Yao > >=20 >=20 > > -----Original Message----- > > From: Kun Qin > > > Sent: Wednesday, October 21, 2020 10:32 AM > > To: devel@edk2.groups.io =20 > > Cc: Wang, Jian J = >; Lu, XiaoyuX > > >; Yao, Jiewen >; Jiang, > > Guomin > > > Subject: [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Fix buffer double fre= e in > > CryptPkcs7VerifyEku > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2459 > > > > SignerCert is part of Pkcs7 instance when both have valid content. OpenSLL > > PKCS7_free function will release the memory of SignerCert when applicable. > > Freeing SignerCert with X509_free again might cause page fault if use- > > after-free guard is enabled. > > > > Cc: Jian J Wang = > > > Cc: Xiaoyu Lu > > > Cc: Jiewen Yao > > > Cc: Guomin Jiang > > > > > Signed-off-by: Kun Qin > > > --- > > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c > > b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c > > index c9fdb65b99d1..40cc39afe7dd 100644 > > --- a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c > > +++ b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c > > @@ -508,10 +508,6 @@ Exit: > > free (SignedData); > > > > } > > > > > > > > - if (SignerCert !=3D NULL) { > > > > - X509_free (SignerCert); > > > > - } > > > > - > > > > if (Pkcs7 !=3D NULL) { > > > > PKCS7_free (Pkcs7); > > > > } > > > > -- > > 2.28.0.windows.1 >=20 >=20 >=20 >=20 >=20 =20 ------=_NextPart_000_01B0_01D6C175.9CDF69B0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: quoted-printable
Jiewen:

= =C2=A0I am OK to merge this bug fix into this stable tag. If no objection,= you can merge it tomorrow.

 

Thanks

Liming

=E5=8F=91= =E4=BB=B6=E4=BA=BA: bounce+27952+67779+4905953+87610= 45@groups.io <bounce+27952+67779+4905953+8761045@groups.io> =E4=BB=A3=E8=A1=A8 <= /b>Yao, Jiewen<= br>=E5=8F=91=E9=80= = =81=E6=97=B6=E9=97=B4: 2020=E5=B9=B411=E6=9C=88= 22=E6=97=A5 20:26
=E6=94=B6=E4=BB=B6=E4=BA=BA: Kun Qin <kun.q@outlook.com>; gaoliming <gaoliming@byosoft.com.= cn>; devel@edk2.groups.io
=E6=8A=84=E9=80=81: Wang, Jian J <jian.j.wang@intel.com&= gt;; Lu, XiaoyuX <xiaoyux.lu@intel.com>; Jiang, Guomin <guomin.jia= ng@intel.com>
=E4=B8=BB=E9=A2=98:= Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryp= tLib: Fix buffer double free in CryptPkcs7VerifyEku

 <= /span>

I can help to merge if it= is approved.

=  

I will = add reviewed-by tag when I merge it.

 

Thank you

Yao Jiewen

 

From: Kun Qin <= kun.q@outlook.com>
Sent:= Sunday, November 22, 2020 3:10 PM
To: gaoliming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io; Yao, Jiewen = <jiewen.yao@intel.com>Cc: Wang, Jian J <jian.= j.wang@intel.com>; Lu, XiaoyuX <xiaoyux.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>
Subject: RE:= [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Fix buffer double fre= e in CryptPkcs7VerifyEku

 

Hi Liming,

 

It will be great if we can get this in. But I have been having troubl= e sending a v2 patch that incorporates Jiewen=E2=80=99s =E2=80=9CReviewed-b= y=E2=80=9D tag through git command line for the past week (no other changes= ). It kept giving me an error of "No host provider available to servic= e this request". Please let me know if you have any suggestions.<= /o:p>

 

Thanks,<= /p>

Kun

 

 

From: gaoliming
Sent: Thursda= y, November 19, 2020 9:39 PM
To: devel@edk2.groups.io; j= iewen.yao@intel.com; 'Kun Qin'=
Cc: 'Wang, Jian J';= 'Lu, XiaoyuX'; 'Jiang, Guomin'
Subject: =E5=9B=9E=E5=A4=8D: [edk2-devel] [PATCH v1 1/1] CryptoPkg: BaseCryptLib: Fix bu= ffer double free in CryptPkcs7VerifyEku

 

Kun:
 This= is a bug fix. It passed code review. Do you request to merge it for
thi= s stable tag 202011?

Thanks
Liming
> -----=E9=82= =AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: bounce+27952+67567+490595= 3+8761045@groups.io
> <bounce+27952+67567+4905953+8761045@groups.io&g= t; =E4=BB=A3=E8=A1=A8 Yao, Jiewen
&g= t; =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4= : 2020=E5=B9=B411=E6=9C= =8814=E6=97=A5 8:32
> =E6=94=B6=E4=BB=B6=E4=BA=BA: Kun Qin <kun.q@outlook.= com>; devel@edk2.groups.io
> =E6=8A=84=E9=80=81: Wang,= Jian J <jian.j.wang@intel.com<= /a>>; Lu, XiaoyuX
> <xi= aoyux.lu@intel.com>; Jiang, Guomin <guomin.jiang@intel.com>; Yao,
> Jiewen <jiewen.yao@intel.com>
> =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH= v1 1/1] CryptoPkg: BaseCryptLib: Fix buffer
> double free in CryptPk= cs7VerifyEku
>
> Sorry, I missed this email.
>
> = Reviewed-by: Jiewen Yao <Jiewen.= yao@intel.com>
>
>
> > -----Original Message-= ----
> > From: Kun Qin <ku= n.q@outlook.com>
> > Sent: Wednesday, October 21, 2020 10:3= 2 AM
> > To: devel@edk2.gr= oups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Lu, XiaoyuX
> > <xiaoyux.lu@intel.com>; Yao, Jie= wen <jiewen.yao@intel.com>= ;; Jiang,
> > Guomin <guomin.jiang@intel.com>
> > Subject: [PATCH v1 1/1] Crypto= Pkg: BaseCryptLib: Fix buffer double free
in
> > CryptPkcs7Veri= fyEku
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id= =3D2459
> >
> > SignerCert is part of Pkcs7 instance= when both have valid content.
OpenSLL
> > PKCS7_free function = will release the memory of SignerCert when
applicable.
> > Free= ing SignerCert with X509_free again might cause page fault if use-
> = > after-free guard is enabled.
> >
> > Cc: Jian J Wang= <jian.j.wang@intel.com>=
> > Cc: Xiaoyu Lu <xia= oyux.lu@intel.com>
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Guomin= Jiang <guomin.jiang@intel.com= >
> >
> > Signed-off-by: Kun Qin <kun.q@outlook.com>
> > ---
> = >  CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c | 4 ----=
> >  1 file changed, 4 deletions(-)
> >
> >= ; diff --git a/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c
&= gt; > b/CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c
> = > index c9fdb65b99d1..40cc39afe7dd 100644
> > --- a/CryptoPkg/L= ibrary/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c
> > +++ b/CryptoPkg/L= ibrary/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c
> > @@ -508,10 +508,6= @@ Exit:
> >      free (SignedData);
= > >
> >    }
> >
> >
>= ; >
> > -  if (SignerCert !=3D NULL) {
> >
>= ; > -    X509_free (SignerCert);
> >
> >= ; -  }
> >
> > -
> >
> > &nbs= p;  if (Pkcs7 !=3D NULL) {
> >
> >   =    PKCS7_free (Pkcs7);
> >
> >   = ; }
> >
> > --
> > 2.28.0.windows.1
>
= >
>
>
>

=  

------=_NextPart_000_01B0_01D6C175.9CDF69B0--