From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 48474D802EC for ; Tue, 11 Feb 2025 04:17:19 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Cqj3+1Hy9ElFC0hTtcyh0Tnpq8LT7JQaoFULWOWpgJ0=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20240830; t=1739247438; v=1; x=1739506637; b=BfLt/BAEn+3R9/fj+z2urJNNSReetPHLbyDvWh6lEU/kRuL2IltGooAbMEHiKcNdsZkgMEIB eiC88sE+PTqI/HNYl4d4GZDhizqwlqHBbxb20QieG5CLJHpEbqacnDZiV0rgm77TDPLnfeS8Cty utn1vxDdT5Aiu5SE1WXUrG7KtLS9W47kqnhOE/u8LDXW/vvE8rlogFLy1PyjS+IdO60rSkO9oly 2aUcCsmpGP3qXK0v/C1JviVRjGDiubaXGjtvm+QzNB7+qs1Q+x7SWBXNga/Iji5hGVlZpFNKcup gbC35uXoX14nMxvoahfjwgR91ULi9CFAuJZ3LcuzfDJeA== X-Received: by 127.0.0.2 with SMTP id V6YfYY7687511xwZHhJSPKAy; Mon, 10 Feb 2025 20:17:17 -0800 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web10.4524.1739247435542726812 for ; Mon, 10 Feb 2025 20:17:16 -0800 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 442D4A32E007 for ; Tue, 11 Feb 2025 12:17:10 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 30FF7A32DFFC for ; Tue, 11 Feb 2025 12:17:10 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id 6271BA32DFFA for ; Tue, 11 Feb 2025 12:17:06 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Tue, 11 Feb 2025 12:16:51 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , Cc: "'Kinney, Michael D'" , "'Ray Ni'" , "'Ard Biesheuvel'" References: In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gVmFyaW91cyBjb25mdXNpbmcgYml0cyBhcm91bmQgVVNCIGhvc3QgY29udHJvbGxlciBwcm90b2NvbHM=?= Date: Tue, 11 Feb 2025 12:16:51 +0800 Message-ID: <01b601db7c3b$c8181de0$584859a0$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQJFhRAdmVX0uqDlxLmDmWGT++ATVLJtbPpA Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 10 Feb 2025 20:17:16 -0800 Resent-From: gaoliming@byosoft.com.cn Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: V8Ct3EfGblsr7qEKdadTjYsHx7686176AA= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b="BfLt/BAE"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=pass (policy=none) header.from=groups.io Lefi: EFI_USB_HC_PROTOCOL is defined in EFI 1.10. I think it can be deprecated.= At least, its consumer code in UsbBusDxe should be removed.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Leif Lindholm > via groups.io > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2025=E5=B9=B42=E6=9C=8811=E6=97=A5 = 1:02 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > =E6=8A=84=E9=80=81: Kinney, Michael D ; Limin= g Gao > ; Ray Ni ; Ard Biesheuvel > > =E4=B8=BB=E9=A2=98: [edk2-devel] Various confusing bits around USB host c= ontroller > protocols >=20 > Spotted while looking into https://github.com/tianocore/edk2/pull/10593 >=20 > This starts with > https://github.com/tianocore/edk2/blob/master/MdeModulePkg/Include/Ppi > /Usb2HostController.h#L244, > which states that PEI_USB2_HOST_CONTROLLER_PPI is modelled after > EFI_USB2_HOST_CONTROLLER_PROTOCOL as described by UEFI 2.3. >=20 > The problem is that > 1) UEFI 2.3 does not describe any EFI_USB2_HOST_CONTROLLER_PROTOCOL > (it describes a EFI_USB2_HC_PROTOCOL, which thankfully is what edk2 > uses elsewhere). > 2) EFI_USB2_HC_PROTOCOL does not contain a GetRootHubPortNumber(). > 3) The specification still references GetRootHubPortNumber() in three > locations. > 4) > https://github.com/tianocore/edk2/blob/master/MdePkg/Include/Protocol/U > sbHostController.h#L464 > defines a EFI_USB_HC_PROTOCOL that is not described by the UEFI > specification version 2.0 or later. >=20 > As far as I can tell there is one clear errata in the UEFI > speficiation: the references to GetRootHubPortNumber(). > Which presumably should be updated to reflect that the information > should be retrieved from GetCapability() instead (which UsbBusDxe > does). > Are there any other implications? >=20 > But that leaves the support for the extra-spec EFI_USB_HC_PROTOCOL. > Why is it still there, in UsbBusDxe, and is anyone actually using it? > Relying on it? > Could we delete it? Deprecate it? >=20 > I don't know what if anything should be done about the > PEI_USB*_HOST_CONTROLLER_PPI structs, but the comments describing > them > are actively misleading and should be updated *somehow*. >=20 > / > Leif >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#121115): https://edk2.groups.io/g/devel/message/121115 Mute This Topic: https://groups.io/mt/111116998/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-