From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web11.411.1589923348129645558 for ; Tue, 19 May 2020 14:22:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=MhDxHfqD; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1589923347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fbJO0+5rdBHJ7iMpg1IQqQqeNy4kLPEQL/SxdKsOa2o=; b=MhDxHfqDxVyN9ZD0B1jyu8u0BfSz39ddpRYguPaTaSegJKC0+TnOq6+1xiZ1OIOzgUvbU8 pYd3yG9+m0k9TNqKatkXIl+iJEh1GXkKRgkDtRFnWN6B5sJJsA5YjbeGOknaLSFfWL9Alo 0NnBAxqL1Cir+5fb2VVgGXsyJSVRrrI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-326-8L3bdYo3PIOLlUvgotgg4g-1; Tue, 19 May 2020 17:22:23 -0400 X-MC-Unique: 8L3bdYo3PIOLlUvgotgg4g-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id CCEA4460; Tue, 19 May 2020 21:22:21 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-149.ams2.redhat.com [10.36.114.149]) by smtp.corp.redhat.com (Postfix) with ESMTP id EB49A649D5; Tue, 19 May 2020 21:22:19 +0000 (UTC) Subject: Re: [edk2-devel] [edk2-rfc] GitHub Pull Request based Code Review Process To: Bret Barkelew , "devel@edk2.groups.io" , "Desimone, Nathaniel L" , "spbrogan@outlook.com" , "rfc@edk2.groups.io" , "Kinney, Michael D" , "Leif Lindholm (Nuvia address)" , Andrew Fish References: From: "Laszlo Ersek" Message-ID: <01b731f7-80be-3671-de3d-18c6b288581f@redhat.com> Date: Tue, 19 May 2020 23:22:19 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: 8bit On 05/19/20 21:34, Bret Barkelew wrote: > Nate, I believe you missed Sean’s point. > > Each one of those packages should have been a separate PR. And then we get to wrangle inter-PR dependencies. Even if github.com supports that, it's a heavy-weight tool, and should be used sparingly. Patches in a patch series are almost always inter-dependent in some way, which indicates that many normal patch sets would have to be split into multiple PRs. > Ergo, no information would have been lost in the squash. > > Also, it’s not so much that we *can’t* learn. It’s that we choose not to. Around here, it’s a mark of prestige to not open doors with your face if it seems like there’s a better way. Makes it easier to focus on the work. Wrt. "open doors with your face", which I understand to be a retort to Nate associating prestige with conforming to the current workflow: I think the expression breaks the Code of Conduct: https://www.tianocore.org/coc.html "Do not insult or put down other participants" (... Before anyone suggests that I did the same when I called maintainers & people en bloc "irrepairably lazy and undisciplined" in my previous mail: that's a fact about humans. People on average perform the minimum of work they can get away with, for satisfying requirements and for reaching goals. It's natural. That's why we have to set high standards. So that covers "lazy". And "undisciplined" (= ignoring rules and good practices) is evidenced frequently, with fixed BZs left open, posted patches not referenced in the BZs they address, BZs ignored / left un-triaged for months and years, pending patches ignored for weeks, reviewed patches left unmerged for days or weeks, etc. I'm not throwing around accusations, just showing that my statement was factual, hardly an insult. OTOH "open doors with your face" is figurative speech, and I do consider it an insult.) Thanks, Laszlo