public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Nhi Pham via groups.io" <nhi=os.amperecomputing.com@groups.io>
To: Taylor Beebe <taylor.d.beebe@gmail.com>, devel@edk2.groups.io
Cc: Chuong Tran <chuong@os.amperecomputing.com>,
	Leif Lindholm <quic_llindhol@quicinc.com>,
	Rebecca Cran <rebecca@os.amperecomputing.com>
Subject: Re: [edk2-devel] [PATCH v1 16/17] Silicon/Ampere/AmpereAltraPkg: Add ImagePropertiesRecordLib Instance
Date: Fri, 1 Dec 2023 09:39:31 +0700	[thread overview]
Message-ID: <01b9dc95-dfea-41ff-a0f1-69e386bec725@os.amperecomputing.com> (raw)
In-Reply-To: <20231201003440.807-17-taylor.d.beebe@gmail.com>

Thanks for update.

Reviewed-by: Nhi Pham <nhi@os.amperecomputing.com>

On 12/1/2023 7:34 AM, Taylor Beebe wrote:
> ImagePropertiesRecordLib is used by DxeMain and PiSmmCore, so it
> needs to be added to most platforms.
> 
> Signed-off-by: Taylor Beebe <taylor.d.beebe@gmail.com>
> Cc: Nhi Pham <nhi@os.amperecomputing.com>
> Cc: Chuong Tran <chuong@os.amperecomputing.com>
> Cc: Leif Lindholm <quic_llindhol@quicinc.com>
> Cc: Rebecca Cran <rebecca@os.amperecomputing.com>
> ---
>   Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> index 8cb2a3fe6422..eb6caf37a3c5 100644
> --- a/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> +++ b/Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc
> @@ -46,6 +46,7 @@
>     HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
>     UefiHiiServicesLib|MdeModulePkg/Library/UefiHiiServicesLib/UefiHiiServicesLib.inf
>     UefiRuntimeLib|MdePkg/Library/UefiRuntimeLib/UefiRuntimeLib.inf
> +  ImagePropertiesRecordLib|MdeModulePkg/Library/ImagePropertiesRecordLib/ImagePropertiesRecordLib.inf
>   
>     #
>     # Allow dynamic PCDs


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111963): https://edk2.groups.io/g/devel/message/111963
Mute This Topic: https://groups.io/mt/102906521/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  reply	other threads:[~2023-12-01  2:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-01  0:34 [edk2-devel] [PATCH v1 00/17] Add ImagePropertiesRecordLib Instances Taylor Beebe
2023-12-01  0:34 ` [edk2-devel] [PATCH v1 01/17] Platform/AMD/OverdriveBoard: Add ImagePropertiesRecordLib Instance Taylor Beebe
2023-12-01  1:24   ` Chang, Abner via groups.io
2023-12-01  0:34 ` [edk2-devel] [PATCH v1 02/17] Platform/ARM/Morello: " Taylor Beebe
2023-12-01  0:34 ` [edk2-devel] [PATCH v1 03/17] Platform/BeagleBoard/BeagleBoardPkg: " Taylor Beebe
2023-12-01  0:34 ` [edk2-devel] [PATCH v1 04/17] Platform/Intel/Vlv2TbltDevicePkg: " Taylor Beebe
2023-12-01  0:34 ` [edk2-devel] [PATCH v1 05/17] Platform/LeMaker/CelloBoard: " Taylor Beebe
2023-12-01  0:34 ` [edk2-devel] [PATCH v1 06/17] Platform/RaspberryPi: " Taylor Beebe
2023-12-01  0:34 ` [edk2-devel] [PATCH v1 07/17] Platform/Loongson/LoongArchQemuPkg: " Taylor Beebe
2023-12-01  6:28   ` Chao Li
2023-12-01  8:08   ` xianglai
2023-12-01  0:34 ` [edk2-devel] [PATCH v1 08/17] Platform/Qemu/SbsaQemu: " Taylor Beebe
2023-12-01  0:34 ` [edk2-devel] [PATCH v1 09/17] Platform/SiFive/U5SeriesPkg: " Taylor Beebe
2023-12-01  0:34 ` [edk2-devel] [PATCH v1 10/17] Platform/Socionext: " Taylor Beebe
2023-12-01  0:34 ` [edk2-devel] [PATCH v1 11/17] Platform/SoftIron/Overdrive1000Board: " Taylor Beebe
2023-12-01  0:34 ` [edk2-devel] [PATCH v1 12/17] Silicon/NXP: " Taylor Beebe
2023-12-01  0:34 ` [edk2-devel] [PATCH v1 13/17] Silicon/Hisilicon: " Taylor Beebe
2023-12-01  0:34 ` [edk2-devel] [PATCH v1 14/17] Silicon/Marvell/Armada7k8k: " Taylor Beebe
2023-12-08 16:22   ` Marcin Wojtas via groups.io
2023-12-01  0:34 ` [edk2-devel] [PATCH v1 15/17] Platform/Sophgo/SG2042_EVB_Board: " Taylor Beebe
2023-12-01  0:34 ` [edk2-devel] [PATCH v1 16/17] Silicon/Ampere/AmpereAltraPkg: " Taylor Beebe
2023-12-01  2:39   ` Nhi Pham via groups.io [this message]
2023-12-01  0:34 ` [edk2-devel] [PATCH v1 17/17] Silicon/Phytium/PhytiumCommonPkg: " Taylor Beebe
2023-12-01  8:18 ` [edk2-devel] [PATCH v1 00/17] Add ImagePropertiesRecordLib Instances Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01b9dc95-dfea-41ff-a0f1-69e386bec725@os.amperecomputing.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox