From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.7466.1644479083941643921 for ; Wed, 09 Feb 2022 23:44:44 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 10 Feb 2022 15:44:38 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , "'Wang, Jian J'" Cc: "'Bi, Dandan'" , "'Lou, Yun'" References: <20220110151253.3848-1-yun.lou@intel.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHYyIDEvNl0gTWRlTW9kdWxlUGtnOiBSZXBsYWNlIE9wY29kZSB3aXRoIHRoZSBjb3JyZXNwb25kaW5nIGluc3RydWN0aW9ucy4=?= Date: Thu, 10 Feb 2022 15:44:40 +0800 Message-ID: <01c201d81e52$0f93ddd0$2ebb9970$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGty4+LFNH6YMmOEgyXPH+3Bo9tzwF3kOdirNVQNfA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Ray,=20 I have given my reviewed-by for the whole patch set.=20 https://edk2.groups.io/g/devel/message/85499?p=3D%2C%2C%2C20%2C0%2C0%2C0%3A= %3A created%2C0%2Ccorresponding%2C20%2C2%2C20%2C88339058 Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED Ni, Ray > =B7=A2=CB=CD=CA=B1=BC=E4: 2022=C4=EA2=D4=C210=C8=D5 13:37 > =CA=D5=BC=FE=C8=CB: Gao, Liming ; Wang, Jian J > > =B3=AD=CB=CD: Bi, Dandan ; Lou, Yun ; > devel@edk2.groups.io > =D6=F7=CC=E2: Re: [edk2-devel] [PATCH v2 1/6] MdeModulePkg: Replace Opcod= e with > the corresponding instructions. >=20 > Reviewed-by: Ray Ni >=20 > Liming, Jian, can you give R-b as the package maintainers? >=20 > -----Original Message----- > From: Lou, Yun > Sent: Monday, January 10, 2022 11:13 PM > To: devel@edk2.groups.io > Cc: Lou, Yun ; Ni, Ray ; Bi, Dandan > ; Gao, Liming > Subject: [PATCH v2 1/6] MdeModulePkg: Replace Opcode with the > corresponding instructions. >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3790 >=20 > Replace Opcode with the corresponding instructions. > The code changes have been verified with CompareBuild.py tool, which > can be used to compare the results of two different EDK II builds to > determine if they generate the same binaries. > (tool link: https://github.com/mdkinney/edk2/tree/sandbox/CompareBuild) >=20 > Signed-off-by: Jason Lou > Cc: Ray Ni > Cc: Dandan Bi > Cc: Liming Gao > --- > MdeModulePkg/Universal/DebugSupportDxe/Ia32/AsmFuncs.nasm | 20 > +++---------------- > MdeModulePkg/Universal/DebugSupportDxe/X64/AsmFuncs.nasm | 21 > +++----------------- > 2 files changed, 6 insertions(+), 35 deletions(-) >=20 > diff --git > a/MdeModulePkg/Universal/DebugSupportDxe/Ia32/AsmFuncs.nasm > b/MdeModulePkg/Universal/DebugSupportDxe/Ia32/AsmFuncs.nasm > index cfb418748f..07fc912fe8 100644 > --- a/MdeModulePkg/Universal/DebugSupportDxe/Ia32/AsmFuncs.nasm > +++ b/MdeModulePkg/Universal/DebugSupportDxe/Ia32/AsmFuncs.nasm > @@ -1,7 +1,7 @@ > ;/** @file >=20 > ; Low leve IA32 specific debug support functions. >=20 > ; >=20 > -; Copyright (c) 2006 - 2011, Intel Corporation. All rights reserved. >=20 > +; Copyright (c) 2006 - 2022, Intel Corporation. All rights reserved. >=20 > ; SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > ; >=20 > ;**/ >=20 > @@ -26,20 +26,6 @@ >=20 >=20 > %define FXSTOR_FLAG 0x1000000 ; bit cpuid 24 of feature flags >=20 >=20 >=20 > -;; The FXSTOR and FXRSTOR commands are used for saving and restoring the > x87, >=20 > -;; MMX, SSE, SSE2, etc registers. The initialization of the debugsuppor= t > driver >=20 > -;; MUST check the CPUID feature flags to see that these instructions are > available >=20 > -;; and fail to init if they are not. >=20 > - >=20 > -;; fxstor [edi] >=20 > -%macro FXSTOR_EDI 0 >=20 > - db 0xf, 0xae, 00000111y ; mod =3D 00, reg/op = =3D > 000, r/m =3D 111 =3D [edi] >=20 > -%endmacro >=20 > - >=20 > -;; fxrstor [esi] >=20 > -%macro FXRSTOR_ESI 0 >=20 > - db 0xf, 0xae, 00001110y ; mod =3D 00, reg/op = =3D > 001, r/m =3D 110 =3D [esi] >=20 > -%endmacro >=20 > SECTION .data >=20 >=20 >=20 > global ASM_PFX(OrigVector) >=20 > @@ -348,7 +334,7 @@ ExtraPushDone: > ; IMPORTANT!! The debug stack has been carefully > constructed to >=20 > ; insure that esp and edi are 16 byte aligned when we > get here. >=20 > ; They MUST be. If they are not, a GP fault will occur. >=20 > - FXSTOR_EDI >=20 > + fxsave [edi] >=20 >=20 >=20 > ;; UEFI calling convention for IA32 requires that Direction flag in EFLAGs is > clear >=20 > cld >=20 > @@ -372,7 +358,7 @@ ExtraPushDone: >=20 >=20 > ;; FX_SAVE_STATE_IA32 FxSaveState; >=20 > mov esi, esp >=20 > - FXRSTOR_ESI >=20 > + fxrstor [esi] >=20 > add esp, 512 >=20 >=20 >=20 > ;; UINT32 Dr0, Dr1, Dr2, Dr3, Dr6, Dr7; >=20 > diff --git a/MdeModulePkg/Universal/DebugSupportDxe/X64/AsmFuncs.nasm > b/MdeModulePkg/Universal/DebugSupportDxe/X64/AsmFuncs.nasm > index 9cc38a3128..c6c5e49189 100644 > --- a/MdeModulePkg/Universal/DebugSupportDxe/X64/AsmFuncs.nasm > +++ b/MdeModulePkg/Universal/DebugSupportDxe/X64/AsmFuncs.nasm > @@ -1,7 +1,7 @@ > ;/** @file >=20 > ; Low level x64 routines used by the debug support driver. >=20 > ; >=20 > -; Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved. >=20 > +; Copyright (c) 2007 - 2022, Intel Corporation. All rights reserved. >=20 > ; SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > ; >=20 > ;**/ >=20 > @@ -26,21 +26,6 @@ >=20 >=20 > %define FXSTOR_FLAG 0x1000000 ; bit cpuid 24 of feature flags >=20 >=20 >=20 > -;; The FXSTOR and FXRSTOR commands are used for saving and restoring the > x87, >=20 > -;; MMX, SSE, SSE2, etc registers. The initialization of the debugsuppor= t > driver >=20 > -;; MUST check the CPUID feature flags to see that these instructions are > available >=20 > -;; and fail to init if they are not. >=20 > - >=20 > -;; fxstor [rdi] >=20 > -%macro FXSTOR_RDI 0 >=20 > - db 0xf, 0xae, 00000111y ; mod =3D 00, reg/op = =3D > 000, r/m =3D 111 =3D [rdi] >=20 > -%endmacro >=20 > - >=20 > -;; fxrstor [rsi] >=20 > -%macro FXRSTOR_RSI 0 >=20 > - db 0xf, 0xae, 00001110y ; mod =3D 00, reg/op = =3D > 001, r/m =3D 110 =3D [rsi] >=20 > -%endmacro >=20 > - >=20 > SECTION .data >=20 >=20 >=20 > global ASM_PFX(OrigVector) >=20 > @@ -381,7 +366,7 @@ ExtraPushDone: > ; IMPORTANT!! The debug stack has been carefully > constructed to >=20 > ; insure that rsp and rdi are 16 byte aligned when we ge= t > here. >=20 > ; They MUST be. If they are not, a GP fault will occur. >=20 > - FXSTOR_RDI >=20 > + fxsave [rdi] >=20 >=20 >=20 > ;; UEFI calling convention for x64 requires that Direction flag in EFLAG= s is > clear >=20 > cld >=20 > @@ -404,7 +389,7 @@ ExtraPushDone: >=20 >=20 > ;; FX_SAVE_STATE_X64 FxSaveState; >=20 > mov rsi, rsp >=20 > - FXRSTOR_RSI >=20 > + fxrstor [rsi] >=20 > add rsp, 512 >=20 >=20 >=20 > ;; UINT64 Dr0, Dr1, Dr2, Dr3, Dr6, Dr7; >=20 > -- > 2.28.0.windows.1 >=20 >=20 >=20 >=20 >=20