[edk2-devel] [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 Specification

[edk2-devel] [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 Specification

[Sachin Ganesh via groups.io]

This series of patches are for general updates to MdePkg and MdeModulePkg based on
UEFI 2.10 and PI 1.8 Specifications

Sachin Ganesh (7):
  MdePkg: Add definition for NVMe Over Fabric Device Path
  MdePkg: Add new Resource Attributes defined in PI 1.8 Spec
  MdePkg: Define Unaccepted Memory Type
  MdeModulePkg: Use newly defined Unaccepted Memory Type
  MdePkg: Update Delayed Dispatch PPI as per PI 1.8 Spec
  MdePkg: Update to PI 1.8 Revision
  OvmfPkg: Use newly defined Unaccepted Memory Type

 MdeModulePkg/Core/Dxe/Gcd/Gcd.c              | 10 +++---
 MdeModulePkg/Core/Dxe/Mem/Page.c             | 38 ++++++++++----------
 MdeModulePkg/Include/Pi/PrePiDxeCis.h        | 25 -------------
 MdeModulePkg/Include/Pi/PrePiHob.h           | 20 -----------
 MdePkg/Include/Pi/PiDxeCis.h                 | 19 +++++-----
 MdePkg/Include/Pi/PiHob.h                    | 14 +++-----
 MdePkg/Include/Pi/PiMmCis.h                  |  6 ++--
 MdePkg/Include/Pi/PiMultiPhase.h             |  6 ++++
 MdePkg/Include/Pi/PiPeiCis.h                 |  6 ++--
 MdePkg/Include/Pi/PiSmmCis.h                 |  2 +-
 MdePkg/Include/Ppi/DelayedDispatch.h         | 24 ++++++++++++-
 MdePkg/Include/Protocol/DevicePath.h         | 22 ++++++++++++
 OvmfPkg/AmdSevDxe/AmdSevDxe.c                |  4 +--
 OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c |  8 ++---
 OvmfPkg/Library/PeilessStartupLib/Hob.c      |  4 +--
 OvmfPkg/Library/PlatformInitLib/IntelTdx.c   |  8 ++---
 OvmfPkg/PlatformPei/AmdSev.c                 |  4 +--
 17 files changed, 108 insertions(+), 112 deletions(-)
 delete mode 100644 MdeModulePkg/Include/Pi/PrePiDxeCis.h
 delete mode 100644 MdeModulePkg/Include/Pi/PrePiHob.h

--
2.24.1.windows.2
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118040): https://edk2.groups.io/g/devel/message/118040
Mute This Topic: https://groups.io/mt/105630618/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 1/7] MdePkg: Add definition for NVMe Over Fabric Device Path

[Sachin Ganesh via groups.io]

In accordance with UEFI 2.10 Specification:
Adding definition for NVMe Over Fabric (NVMe-oF) Device Path
of Messaging Sub-Type.

Cc: Felix Polyudov <felixp@ami.com>
Cc: Dhanaraj V <vdhanaraj@ami.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Sachin Ganesh <sachinganesh@ami.com>
---
 MdePkg/Include/Protocol/DevicePath.h | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)

diff --git a/MdePkg/Include/Protocol/DevicePath.h b/MdePkg/Include/Protocol/DevicePath.h
index 9060dd782e..35008ddcdf 100644
--- a/MdePkg/Include/Protocol/DevicePath.h
+++ b/MdePkg/Include/Protocol/DevicePath.h
@@ -837,6 +837,26 @@ typedef struct {
   UINT64                      NamespaceUuid;

 } NVME_NAMESPACE_DEVICE_PATH;



+///

+/// NVMe over Fabric (NVMe-oF) Namespace Device Path SubType.

+///

+#define MSG_NVME_OF_NAMESPACE_DP  0x22

+typedef struct {

+  EFI_DEVICE_PATH_PROTOCOL    Header;

+  ///

+  /// Namespace Identifier Type (NIDT)

+  ///

+  UINT8                       NamespaceIdType;

+  ///

+  /// Namespace Identifier (NID)

+  ///

+  UINT8                       NamespaceId[16];

+  ///

+  /// Unique identifier of an NVM subsystem

+  ///

+  CHAR8                       SubsystemNqn[];

+} NVME_OF_NAMESPACE_DEVICE_PATH;

+

 ///

 /// DNS Device Path SubType

 ///

@@ -1287,6 +1307,7 @@ typedef union {
   SAS_DEVICE_PATH                            Sas;

   SASEX_DEVICE_PATH                          SasEx;

   NVME_NAMESPACE_DEVICE_PATH                 NvmeNamespace;

+  NVME_OF_NAMESPACE_DEVICE_PATH              NvmeOfNamespace;

   DNS_DEVICE_PATH                            Dns;

   URI_DEVICE_PATH                            Uri;

   BLUETOOTH_DEVICE_PATH                      Bluetooth;

@@ -1343,6 +1364,7 @@ typedef union {
   SAS_DEVICE_PATH                            *Sas;

   SASEX_DEVICE_PATH                          *SasEx;

   NVME_NAMESPACE_DEVICE_PATH                 *NvmeNamespace;

+  NVME_OF_NAMESPACE_DEVICE_PATH              *NvmeOfNamespace;

   DNS_DEVICE_PATH                            *Dns;

   URI_DEVICE_PATH                            *Uri;

   BLUETOOTH_DEVICE_PATH                      *Bluetooth;

--
2.24.1.windows.2
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118041): https://edk2.groups.io/g/devel/message/118041
Mute This Topic: https://groups.io/mt/105630619/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 2/7] MdePkg: Add new Resource Attributes defined in PI 1.8 Spec

[Sachin Ganesh via groups.io]

Defined Encrypted and Special Purpose resource attributes as
defined in PI 1.8 Specification

Cc: Felix Polyudov <felixp@ami.com>
Cc: Dhanaraj V <vdhanaraj@ami.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Sachin Ganesh <sachinganesh@ami.com>
---
 MdePkg/Include/Pi/PiHob.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/MdePkg/Include/Pi/PiHob.h b/MdePkg/Include/Pi/PiHob.h
index 4605da56e2..f730520e8c 100644
--- a/MdePkg/Include/Pi/PiHob.h
+++ b/MdePkg/Include/Pi/PiHob.h
@@ -297,6 +297,8 @@ typedef UINT32 EFI_RESOURCE_ATTRIBUTE_TYPE;
 #define EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTED    0x00040000

 #define EFI_RESOURCE_ATTRIBUTE_READ_ONLY_PROTECTABLE  0x00080000



+#define EFI_RESOURCE_ATTRIBUTE_ENCRYPTED        0x04000000

+#define EFI_RESOURCE_ATTRIBUTE_SPECIAL_PURPOSE  0x08000000

 //

 // Physical memory relative reliability attribute. This

 // memory provides higher reliability relative to other

--
2.24.1.windows.2
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118042): https://edk2.groups.io/g/devel/message/118042
Mute This Topic: https://groups.io/mt/105630620/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 3/7] MdePkg: Define Unaccepted Memory Type

[Sachin Ganesh via groups.io]

EFI_RESOURCE_MEMORY_UNACCEPTED has been officially defined in the PI
1.8 specification. So all temporary solutions have been replaced with
the actual definition.

Cc: Felix Polyudov <felixp@ami.com>
Cc: Dhanaraj V <vdhanaraj@ami.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Sachin Ganesh <sachinganesh@ami.com>
---
 MdePkg/Include/Pi/PiDxeCis.h | 13 +++++--------
 MdePkg/Include/Pi/PiHob.h    | 12 ++----------
 2 files changed, 7 insertions(+), 18 deletions(-)

diff --git a/MdePkg/Include/Pi/PiDxeCis.h b/MdePkg/Include/Pi/PiDxeCis.h
index bb7fb2c38a..04410c5a1a 100644
--- a/MdePkg/Include/Pi/PiDxeCis.h
+++ b/MdePkg/Include/Pi/PiDxeCis.h
@@ -56,14 +56,11 @@ typedef enum {
   /// system. If all memory has the same reliability, then this bit is not used.

   ///

   EfiGcdMemoryTypeMoreReliable,

-  // ///

-  // /// A memory region that describes system memory that has not been accepted

-  // /// by a corresponding call to the underlying isolation architecture.

-  // ///

-  // /// Please be noted:

-  // /// EfiGcdMemoryTypeUnaccepted is defined in PrePiDxeCis.h because it has not been

-  // /// defined in PI spec.

-  // EfiGcdMemoryTypeUnaccepted,

+  ///

+  /// A memory region that describes system memory that has not been accepted

+  /// by a corresponding call to the underlying isolation architecture.

+  ///

+  EfiGcdMemoryTypeUnaccepted,

   EfiGcdMemoryTypeMaximum = 7

 } EFI_GCD_MEMORY_TYPE;



diff --git a/MdePkg/Include/Pi/PiHob.h b/MdePkg/Include/Pi/PiHob.h
index f730520e8c..9e49421afa 100644
--- a/MdePkg/Include/Pi/PiHob.h
+++ b/MdePkg/Include/Pi/PiHob.h
@@ -232,16 +232,8 @@ typedef UINT32 EFI_RESOURCE_TYPE;
 #define EFI_RESOURCE_MEMORY_MAPPED_IO_PORT  0x00000004

 #define EFI_RESOURCE_MEMORY_RESERVED        0x00000005

 #define EFI_RESOURCE_IO_RESERVED            0x00000006

-//

-// BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED is defined for unaccepted memory.

-// But this defitinion has not been officially in the PI spec. Base

-// on the code-first we define BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED at

-// MdeModulePkg/Include/Pi/PrePiHob.h and update EFI_RESOURCE_MAX_MEMORY_TYPE

-// to 8. After BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED is officially published

-// in PI spec, we will re-visit here.

-//

-// #define BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED      0x00000007

-#define EFI_RESOURCE_MAX_MEMORY_TYPE  0x00000008

+#define EFI_RESOURCE_MEMORY_UNACCEPTED      0x00000007

+#define EFI_RESOURCE_MAX_MEMORY_TYPE        0x00000008



 ///

 /// A type of recount attribute type.

--
2.24.1.windows.2
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118043): https://edk2.groups.io/g/devel/message/118043
Mute This Topic: https://groups.io/mt/105630622/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 4/7] MdeModulePkg: Use newly defined Unaccepted Memory Type

[Sachin Ganesh via groups.io]

EFI_RESOURCE_MEMORY_UNACCEPTED has been officially defined in the PI
1.8 specification. So all temporary solutions have been replaced with
the actual definition.

Cc: Felix Polyudov <felixp@ami.com>
Cc: Dhanaraj V <vdhanaraj@ami.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Sachin Ganesh <sachinganesh@ami.com>
---
 MdeModulePkg/Core/Dxe/Gcd/Gcd.c       | 10 +++----
 MdeModulePkg/Core/Dxe/Mem/Page.c      | 38 +++++++++++++--------------
 MdeModulePkg/Include/Pi/PrePiDxeCis.h | 25 ------------------
 MdeModulePkg/Include/Pi/PrePiHob.h    | 20 --------------
 4 files changed, 24 insertions(+), 69 deletions(-)
 delete mode 100644 MdeModulePkg/Include/Pi/PrePiDxeCis.h
 delete mode 100644 MdeModulePkg/Include/Pi/PrePiHob.h

diff --git a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
index c450d1bf25..fe1bbd6974 100644
--- a/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
+++ b/MdeModulePkg/Core/Dxe/Gcd/Gcd.c
@@ -8,8 +8,8 @@ SPDX-License-Identifier: BSD-2-Clause-Patent


 **/



-#include <Pi/PrePiDxeCis.h>

-#include <Pi/PrePiHob.h>

+#include <Pi/PiDxeCis.h>

+#include <Pi/PiHob.h>

 #include "DxeMain.h"

 #include "Gcd.h"

 #include "Mem/HeapGuard.h"

@@ -105,7 +105,7 @@ GLOBAL_REMOVE_IF_UNREFERENCED CONST CHAR8  *mGcdMemoryTypeNames[] = {
   "MMIO     ",  // EfiGcdMemoryTypeMemoryMappedIo

   "PersisMem",  // EfiGcdMemoryTypePersistent

   "MoreRelia",  // EfiGcdMemoryTypeMoreReliable

-  "Unaccepte",  // EFI_GCD_MEMORY_TYPE_UNACCEPTED

+  "Unaccepte",  // EfiGcdMemoryTypeUnaccepted

   "Unknown  "   // EfiGcdMemoryTypeMaximum

 };



@@ -2669,8 +2669,8 @@ CoreInitializeGcdServices (
         case EFI_RESOURCE_MEMORY_RESERVED:

           GcdMemoryType = EfiGcdMemoryTypeReserved;

           break;

-        case BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED:

-          GcdMemoryType = EFI_GCD_MEMORY_TYPE_UNACCEPTED;

+        case EFI_RESOURCE_MEMORY_UNACCEPTED:

+          GcdMemoryType = EfiGcdMemoryTypeUnaccepted;

           break;

         case EFI_RESOURCE_IO:

           GcdIoType = EfiGcdIoTypeIo;

diff --git a/MdeModulePkg/Core/Dxe/Mem/Page.c b/MdeModulePkg/Core/Dxe/Mem/Page.c
index 26584648c2..5a51d9df1a 100644
--- a/MdeModulePkg/Core/Dxe/Mem/Page.c
+++ b/MdeModulePkg/Core/Dxe/Mem/Page.c
@@ -9,7 +9,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include "DxeMain.h"

 #include "Imem.h"

 #include "HeapGuard.h"

-#include <Pi/PrePiDxeCis.h>

+#include <Pi/PiDxeCis.h>



 //

 // Entry for tracking the memory regions for each memory type to coalesce similar memory types

@@ -70,23 +70,23 @@ EFI_PHYSICAL_ADDRESS  mDefaultMaximumAddress = MAX_ALLOC_ADDRESS;
 EFI_PHYSICAL_ADDRESS  mDefaultBaseAddress    = MAX_ALLOC_ADDRESS;



 EFI_MEMORY_TYPE_INFORMATION  gMemoryTypeInformation[EfiMaxMemoryType + 1] = {

-  { EfiReservedMemoryType,          0 },

-  { EfiLoaderCode,                  0 },

-  { EfiLoaderData,                  0 },

-  { EfiBootServicesCode,            0 },

-  { EfiBootServicesData,            0 },

-  { EfiRuntimeServicesCode,         0 },

-  { EfiRuntimeServicesData,         0 },

-  { EfiConventionalMemory,          0 },

-  { EfiUnusableMemory,              0 },

-  { EfiACPIReclaimMemory,           0 },

-  { EfiACPIMemoryNVS,               0 },

-  { EfiMemoryMappedIO,              0 },

-  { EfiMemoryMappedIOPortSpace,     0 },

-  { EfiPalCode,                     0 },

-  { EfiPersistentMemory,            0 },

-  { EFI_GCD_MEMORY_TYPE_UNACCEPTED, 0 },

-  { EfiMaxMemoryType,               0 }

+  { EfiReservedMemoryType,      0 },

+  { EfiLoaderCode,              0 },

+  { EfiLoaderData,              0 },

+  { EfiBootServicesCode,        0 },

+  { EfiBootServicesData,        0 },

+  { EfiRuntimeServicesCode,     0 },

+  { EfiRuntimeServicesData,     0 },

+  { EfiConventionalMemory,      0 },

+  { EfiUnusableMemory,          0 },

+  { EfiACPIReclaimMemory,       0 },

+  { EfiACPIMemoryNVS,           0 },

+  { EfiMemoryMappedIO,          0 },

+  { EfiMemoryMappedIOPortSpace, 0 },

+  { EfiPalCode,                 0 },

+  { EfiPersistentMemory,        0 },

+  { EfiGcdMemoryTypeUnaccepted, 0 },

+  { EfiMaxMemoryType,           0 }

 };

 //

 // Only used when load module at fixed address feature is enabled. True means the memory is alreay successfully allocated

@@ -2083,7 +2083,7 @@ CoreGetMemoryMap (
       MemoryMap = MergeMemoryMapDescriptor (MemoryMapStart, MemoryMap, Size);

     }



-    if (MergeGcdMapEntry.GcdMemoryType == EFI_GCD_MEMORY_TYPE_UNACCEPTED) {

+    if (MergeGcdMapEntry.GcdMemoryType == EfiGcdMemoryTypeUnaccepted) {

       //

       // Page Align GCD range is required. When it is converted to EFI_MEMORY_DESCRIPTOR,

       // it will be recorded as page PhysicalStart and NumberOfPages.

diff --git a/MdeModulePkg/Include/Pi/PrePiDxeCis.h b/MdeModulePkg/Include/Pi/PrePiDxeCis.h
deleted file mode 100644
index 9be71d2618..0000000000
--- a/MdeModulePkg/Include/Pi/PrePiDxeCis.h
+++ /dev/null
@@ -1,25 +0,0 @@
-/** @file

-  Include file matches things in PI.

-

-Copyright (c) 2022, Intel Corporation. All rights reserved.<BR>

-SPDX-License-Identifier: BSD-2-Clause-Patent

-

-**/

-

-#ifndef MDE_MODULEPKG_PRE_PI_DXE_CIS_H_

-#define MDE_MODULEPKG_PRE_PI_DXE_CIS_H_

-

-///

-/// A memory region that describes system memory that has not been accepted

-/// by a corresponding call to the underlying isolation architecture.

-///

-/// This memory region has not been defined in PI spec, so it is defined in

-/// PrePiDxeCis.h. And it is defined in the format of captial letters

-/// because only capital letters are allowed to be used for #define declarations.

-///

-/// After this memory region is defined in PI spec, it should be a value in

-/// EFI_GCD_MEMORY_TYPE in PiDxeCis.h.

-///

-#define  EFI_GCD_MEMORY_TYPE_UNACCEPTED  6

-

-#endif

diff --git a/MdeModulePkg/Include/Pi/PrePiHob.h b/MdeModulePkg/Include/Pi/PrePiHob.h
deleted file mode 100644
index ac575e5972..0000000000
--- a/MdeModulePkg/Include/Pi/PrePiHob.h
+++ /dev/null
@@ -1,20 +0,0 @@
-/** @file

-  HOB related definitions which has not been officially published in PI.

-

-Copyright (c) 2022, Intel Corporation. All rights reserved.<BR>

-SPDX-License-Identifier: BSD-2-Clause-Patent

-

-**/

-

-#ifndef MDE_MODULEPKG_PRE_PI_HOB_H_

-#define MDE_MODULEPKG_PRE_PI_HOB_H_

-

-//

-// BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED is defined for unaccepted memory.

-// But this defitinion has not been officially in the PI spec. Base

-// on the code-first we define BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED at

-// MdeModulePkg/Include/Pi/PrePiHob.h.

-//

-#define BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED  0x00000007

-

-#endif

--
2.24.1.windows.2
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118044): https://edk2.groups.io/g/devel/message/118044
Mute This Topic: https://groups.io/mt/105630623/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 5/7] MdePkg: Update Delayed Dispatch PPI as per PI 1.8 Spec

[Sachin Ganesh via groups.io]

Added WaitOnEvent() function to EFI_DELAYTED_DISPATCH_PPI.
Modified DispatchRegister() parameter list.

Cc: Felix Polyudov <felixp@ami.com>
Cc: Dhanaraj V <vdhanaraj@ami.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Sachin Ganesh <sachinganesh@ami.com>
---
 MdePkg/Include/Ppi/DelayedDispatch.h | 24 +++++++++++++++++++++++-
 1 file changed, 23 insertions(+), 1 deletion(-)

diff --git a/MdePkg/Include/Ppi/DelayedDispatch.h b/MdePkg/Include/Ppi/DelayedDispatch.h
index f9b4fed30f..1c2068404c 100644
--- a/MdePkg/Include/Ppi/DelayedDispatch.h
+++ b/MdePkg/Include/Ppi/DelayedDispatch.h
@@ -49,6 +49,7 @@ This service is the single member function of the EFI_DELAYED_DISPATCH_PPI
   @param This           Pointer to the EFI_DELAYED_DISPATCH_PPI instance

   @param Function       Function to call back

   @param Context        Context data

+  @param UniqueId       UniqueId

   @param Delay          Delay interval



   @retval EFI_SUCCESS               Function successfully loaded

@@ -62,9 +63,29 @@ EFI_STATUS
   IN  EFI_DELAYED_DISPATCH_PPI      *This,

   IN  EFI_DELAYED_DISPATCH_FUNCTION  Function,

   IN  UINT64                     Context,

+  IN  EFI_GUID                   *UniqueId  OPTIONAL,

   OUT UINT32                     Delay

   );



+/**

+Function invoked by a PEIM to wait until all specified UniqueId events have been dispatched. The other events

+will continue to dispatch while this process is being paused

+

+  @param This           Pointer to the EFI_DELAYED_DISPATCH_PPI instance

+  @param UniqueId       Delayed dispatch request ID the caller will wait on

+

+  @retval EFI_SUCCESS               Function successfully invoked

+  @retval EFI_INVALID_PARAMETER     One of the Arguments is not supported

+

+**/

+

+typedef

+EFI_STATUS

+(EFIAPI *EFI_DELAYED_DISPATCH_WAIT_ON_EVENT)(

+  IN EFI_DELAYED_DISPATCH_PPI  *This,

+  IN EFI_GUID                  UniqueId

+  );

+

 ///

 /// This PPI is a pointer to the Delayed Dispatch Service.

 /// This service will be published by the Pei Foundation. The PEI Foundation

@@ -72,7 +93,8 @@ EFI_STATUS
 /// execution.

 ///

 struct _EFI_DELAYED_DISPATCH_PPI {

-  EFI_DELAYED_DISPATCH_REGISTER    Register;

+  EFI_DELAYED_DISPATCH_REGISTER         Register;

+  EFI_DELAYED_DISPATCH_WAIT_ON_EVENT    WaitOnEvent;

 };



 extern EFI_GUID  gEfiPeiDelayedDispatchPpiGuid;

--
2.24.1.windows.2
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118045): https://edk2.groups.io/g/devel/message/118045
Mute This Topic: https://groups.io/mt/105630624/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 6/7] MdePkg: Update to PI 1.8 Revision

[Sachin Ganesh via groups.io]

Revision macros have been updated to indicate PI 1.8 specification
support

Cc: Felix Polyudov <felixp@ami.com>
Cc: Dhanaraj V <vdhanaraj@ami.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Sachin Ganesh <sachinganesh@ami.com>
---
 MdePkg/Include/Pi/PiDxeCis.h     | 6 +++---
 MdePkg/Include/Pi/PiMmCis.h      | 6 +++---
 MdePkg/Include/Pi/PiMultiPhase.h | 6 ++++++
 MdePkg/Include/Pi/PiPeiCis.h     | 6 +++---
 MdePkg/Include/Pi/PiSmmCis.h     | 2 +-
 5 files changed, 16 insertions(+), 10 deletions(-)

diff --git a/MdePkg/Include/Pi/PiDxeCis.h b/MdePkg/Include/Pi/PiDxeCis.h
index 04410c5a1a..9afeaddeae 100644
--- a/MdePkg/Include/Pi/PiDxeCis.h
+++ b/MdePkg/Include/Pi/PiDxeCis.h
@@ -5,7 +5,7 @@ Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
 SPDX-License-Identifier: BSD-2-Clause-Patent



   @par Revision Reference:

-  PI Version 1.7

+  PI Version 1.8



 **/



@@ -691,8 +691,8 @@ EFI_STATUS
 // DXE Services Table

 //

 #define DXE_SERVICES_SIGNATURE            0x565245535f455844ULL

-#define DXE_SPECIFICATION_MAJOR_REVISION  1

-#define DXE_SPECIFICATION_MINOR_REVISION  70

+#define DXE_SPECIFICATION_MAJOR_REVISION  PI_SPECIFICATION_MAJOR_REVISION

+#define DXE_SPECIFICATION_MINOR_REVISION  PI_SPECIFICATION_MINOR_REVISION

 #define DXE_SERVICES_REVISION             ((DXE_SPECIFICATION_MAJOR_REVISION<<16) | (DXE_SPECIFICATION_MINOR_REVISION))



 typedef struct {

diff --git a/MdePkg/Include/Pi/PiMmCis.h b/MdePkg/Include/Pi/PiMmCis.h
index 01340952d8..7a9f151e59 100644
--- a/MdePkg/Include/Pi/PiMmCis.h
+++ b/MdePkg/Include/Pi/PiMmCis.h
@@ -20,10 +20,10 @@ typedef struct _EFI_MM_SYSTEM_TABLE EFI_MM_SYSTEM_TABLE;
 ///

 #define MM_MMST_SIGNATURE  SIGNATURE_32 ('S', 'M', 'S', 'T')

 ///

-/// The Management Mode System Table (MMST) revision is 1.6

+/// The Management Mode System Table (MMST) revision

 ///

-#define MM_SPECIFICATION_MAJOR_REVISION  1

-#define MM_SPECIFICATION_MINOR_REVISION  60

+#define MM_SPECIFICATION_MAJOR_REVISION  PI_SPECIFICATION_MAJOR_REVISION

+#define MM_SPECIFICATION_MINOR_REVISION  PI_SPECIFICATION_MINOR_REVISION

 #define EFI_MM_SYSTEM_TABLE_REVISION     ((MM_SPECIFICATION_MAJOR_REVISION<<16) | (MM_SPECIFICATION_MINOR_REVISION))



 /**

diff --git a/MdePkg/Include/Pi/PiMultiPhase.h b/MdePkg/Include/Pi/PiMultiPhase.h
index a7e95820ef..863a839601 100644
--- a/MdePkg/Include/Pi/PiMultiPhase.h
+++ b/MdePkg/Include/Pi/PiMultiPhase.h
@@ -20,6 +20,12 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
 #include <Pi/PiStatusCode.h>

 #include <Pi/PiS3BootScript.h>



+//

+// PI Specification Revision information

+//

+#define PI_SPECIFICATION_MAJOR_REVISION  1

+#define PI_SPECIFICATION_MINOR_REVISION  80

+

 /**

   Produces an error code in the range reserved for use by the Platform Initialization

   Architecture Specification.

diff --git a/MdePkg/Include/Pi/PiPeiCis.h b/MdePkg/Include/Pi/PiPeiCis.h
index 69eec2c473..0ba013e664 100644
--- a/MdePkg/Include/Pi/PiPeiCis.h
+++ b/MdePkg/Include/Pi/PiPeiCis.h
@@ -5,7 +5,7 @@ Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
 SPDX-License-Identifier: BSD-2-Clause-Patent



   @par Revision Reference:

-  PI Version 1.7.

+  PI Version 1.8.



 **/



@@ -846,8 +846,8 @@ EFI_STATUS
 //

 // PEI Specification Revision information

 //

-#define PEI_SPECIFICATION_MAJOR_REVISION  1

-#define PEI_SPECIFICATION_MINOR_REVISION  70

+#define PEI_SPECIFICATION_MAJOR_REVISION  PI_SPECIFICATION_MAJOR_REVISION

+#define PEI_SPECIFICATION_MINOR_REVISION  PI_SPECIFICATION_MINOR_REVISION

 ///

 /// Specification inconsistency here:

 /// In the PI1.0 spec, PEI_SERVICES_SIGNATURE is defined as 0x5652455320494550. But

diff --git a/MdePkg/Include/Pi/PiSmmCis.h b/MdePkg/Include/Pi/PiSmmCis.h
index bf5b580c32..886b5e4a38 100644
--- a/MdePkg/Include/Pi/PiSmmCis.h
+++ b/MdePkg/Include/Pi/PiSmmCis.h
@@ -15,7 +15,7 @@


 typedef struct _EFI_SMM_SYSTEM_TABLE2 EFI_SMM_SYSTEM_TABLE2;

 //

-// Define new MM related definition introduced by PI 1.5.

+// MM related definitions

 //

 #define  SMM_SMST_SIGNATURE                MM_MMST_SIGNATURE

 #define  SMM_SPECIFICATION_MAJOR_REVISION  MM_SPECIFICATION_MAJOR_REVISION

--
2.24.1.windows.2
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118046): https://edk2.groups.io/g/devel/message/118046
Mute This Topic: https://groups.io/mt/105630625/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH 7/7] OvmfPkg: Use newly defined Unaccepted Memory Type

[Sachin Ganesh via groups.io]

EFI_RESOURCE_MEMORY_UNACCEPTED has been officially defined in the PI
1.8 specification. So all temporary solutions have been replaced with
the actual definition.

Cc: Felix Polyudov <felixp@ami.com>
Cc: Dhanaraj V <vdhanaraj@ami.com>
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Signed-off-by: Sachin Ganesh <sachinganesh@ami.com>
---
 OvmfPkg/AmdSevDxe/AmdSevDxe.c                | 4 ++--
 OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c | 8 ++++----
 OvmfPkg/Library/PeilessStartupLib/Hob.c      | 4 ++--
 OvmfPkg/Library/PlatformInitLib/IntelTdx.c   | 8 ++++----
 OvmfPkg/PlatformPei/AmdSev.c                 | 4 ++--
 5 files changed, 14 insertions(+), 14 deletions(-)

diff --git a/OvmfPkg/AmdSevDxe/AmdSevDxe.c b/OvmfPkg/AmdSevDxe/AmdSevDxe.c
index db3675ae86..d497a343d3 100644
--- a/OvmfPkg/AmdSevDxe/AmdSevDxe.c
+++ b/OvmfPkg/AmdSevDxe/AmdSevDxe.c
@@ -20,7 +20,7 @@
 #include <Library/UefiBootServicesTableLib.h>

 #include <Guid/ConfidentialComputingSevSnpBlob.h>

 #include <Library/PcdLib.h>

-#include <Pi/PrePiDxeCis.h>

+#include <Pi/PiDxeCis.h>

 #include <Protocol/SevMemoryAcceptance.h>

 #include <Protocol/MemoryAccept.h>

 #include <Uefi/UefiSpec.h>

@@ -119,7 +119,7 @@ AcceptAllMemory (
     CONST EFI_GCD_MEMORY_SPACE_DESCRIPTOR  *Desc;



     Desc = &AllDescMap[Index];

-    if (Desc->GcdMemoryType != EFI_GCD_MEMORY_TYPE_UNACCEPTED) {

+    if (Desc->GcdMemoryType != EfiGcdMemoryTypeUnaccepted) {

       continue;

     }



diff --git a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c
index 3372cee2f7..b6085eab44 100644
--- a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c
+++ b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c
@@ -19,7 +19,7 @@
 #include <Library/TdxLib.h>

 #include <Library/TdxMailboxLib.h>

 #include <Library/SynchronizationLib.h>

-#include <Pi/PrePiHob.h>

+#include <Pi/PiHob.h>

 #include <WorkArea.h>

 #include <ConfidentialComputingGuestAttr.h>

 #include <Library/TdxHelperLib.h>

@@ -351,7 +351,7 @@ AcceptMemoryForAPsStack (
     if (Hob.Header->HobType == EFI_HOB_TYPE_RESOURCE_DESCRIPTOR) {

       DEBUG ((DEBUG_INFO, "\nResourceType: 0x%x\n", Hob.ResourceDescriptor->ResourceType));



-      if (Hob.ResourceDescriptor->ResourceType == BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED) {

+      if (Hob.ResourceDescriptor->ResourceType == EFI_RESOURCE_MEMORY_UNACCEPTED) {

         ResourceLength = Hob.ResourceDescriptor->ResourceLength;

         PhysicalStart  = Hob.ResourceDescriptor->PhysicalStart;

         PhysicalEnd    = PhysicalStart + ResourceLength;

@@ -427,7 +427,7 @@ AcceptMemory (
   //

   while (!END_OF_HOB_LIST (Hob)) {

     if (Hob.Header->HobType == EFI_HOB_TYPE_RESOURCE_DESCRIPTOR) {

-      if (Hob.ResourceDescriptor->ResourceType == BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED) {

+      if (Hob.ResourceDescriptor->ResourceType == EFI_RESOURCE_MEMORY_UNACCEPTED) {

         PhysicalStart = Hob.ResourceDescriptor->PhysicalStart;

         PhysicalEnd   = PhysicalStart + Hob.ResourceDescriptor->ResourceLength;



@@ -563,7 +563,7 @@ ValidateHobList (
     EFI_RESOURCE_MEMORY_MAPPED_IO_PORT,

     EFI_RESOURCE_MEMORY_RESERVED,

     EFI_RESOURCE_IO_RESERVED,

-    BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED

+    EFI_RESOURCE_MEMORY_UNACCEPTED

   };



   if (VmmHobList == NULL) {

diff --git a/OvmfPkg/Library/PeilessStartupLib/Hob.c b/OvmfPkg/Library/PeilessStartupLib/Hob.c
index 318b74c95d..725927da73 100644
--- a/OvmfPkg/Library/PeilessStartupLib/Hob.c
+++ b/OvmfPkg/Library/PeilessStartupLib/Hob.c
@@ -20,7 +20,7 @@
 #include <IndustryStandard/UefiTcgPlatform.h>

 #include <Library/PlatformInitLib.h>

 #include <OvmfPlatforms.h>

-#include <Pi/PrePiHob.h>

+#include <Pi/PiHob.h>

 #include "PeilessStartupInternal.h"



 /**

@@ -92,7 +92,7 @@ ConstructFwHobList (
   //

   while (!END_OF_HOB_LIST (Hob)) {

     if (Hob.Header->HobType == EFI_HOB_TYPE_RESOURCE_DESCRIPTOR) {

-      if (Hob.ResourceDescriptor->ResourceType == BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED) {

+      if (Hob.ResourceDescriptor->ResourceType == EFI_RESOURCE_MEMORY_UNACCEPTED) {

         PhysicalEnd    = Hob.ResourceDescriptor->PhysicalStart + Hob.ResourceDescriptor->ResourceLength;

         ResourceLength = Hob.ResourceDescriptor->ResourceLength;



diff --git a/OvmfPkg/Library/PlatformInitLib/IntelTdx.c b/OvmfPkg/Library/PlatformInitLib/IntelTdx.c
index ada8592ddd..e561cee30b 100644
--- a/OvmfPkg/Library/PlatformInitLib/IntelTdx.c
+++ b/OvmfPkg/Library/PlatformInitLib/IntelTdx.c
@@ -17,7 +17,7 @@
 #include <IndustryStandard/Tdx.h>

 #include <IndustryStandard/IntelTdx.h>

 #include <Library/PeiServicesLib.h>

-#include <Pi/PrePiHob.h>

+#include <Pi/PiHob.h>

 #include <WorkArea.h>

 #include <ConfidentialComputingGuestAttr.h>



@@ -40,9 +40,9 @@ BuildResourceDescriptorHobForUnacceptedMemory (
   EFI_RESOURCE_ATTRIBUTE_TYPE  ResourceAttribute;

   UINT64                       MaxAcceptedMemoryAddress;



-  ASSERT (Hob->ResourceType == BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED);

+  ASSERT (Hob->ResourceType == EFI_RESOURCE_MEMORY_UNACCEPTED);



-  ResourceType      = BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED;

+  ResourceType      = EFI_RESOURCE_MEMORY_UNACCEPTED;

   ResourceAttribute = Hob->ResourceAttribute;

   PhysicalStart     = Hob->PhysicalStart;

   ResourceLength    = Hob->ResourceLength;

@@ -104,7 +104,7 @@ TransferTdxHobList (
         ResourceType      = Hob.ResourceDescriptor->ResourceType;

         ResourceAttribute = Hob.ResourceDescriptor->ResourceAttribute;



-        if (ResourceType == BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED) {

+        if (ResourceType == EFI_RESOURCE_MEMORY_UNACCEPTED) {

           BuildResourceDescriptorHobForUnacceptedMemory (Hob.ResourceDescriptor);

         } else {

           BuildResourceDescriptorHob (

diff --git a/OvmfPkg/PlatformPei/AmdSev.c b/OvmfPkg/PlatformPei/AmdSev.c
index e6724cf493..88ca14507f 100644
--- a/OvmfPkg/PlatformPei/AmdSev.c
+++ b/OvmfPkg/PlatformPei/AmdSev.c
@@ -17,7 +17,7 @@
 #include <Library/MemEncryptSevLib.h>

 #include <Library/MemoryAllocationLib.h>

 #include <Library/PcdLib.h>

-#include <Pi/PrePiHob.h>

+#include <Pi/PiHob.h>

 #include <PiPei.h>

 #include <Register/Amd/Msr.h>

 #include <Register/Intel/SmramSaveStateMap.h>

@@ -149,7 +149,7 @@ AmdSevSnpInitialize (


       if (ResourceHob->ResourceType == EFI_RESOURCE_SYSTEM_MEMORY) {

         if (ResourceHob->PhysicalStart >= SIZE_4GB) {

-          ResourceHob->ResourceType = BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED;

+          ResourceHob->ResourceType = EFI_RESOURCE_MEMORY_UNACCEPTED;

           continue;

         }



--
2.24.1.windows.2
-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118047): https://edk2.groups.io/g/devel/message/118047
Mute This Topic: https://groups.io/mt/105630626/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 Specification

[Yao, Jiewen]

7/7, 4/7, 3/7 - reviewed-by: Jiewen Yao <Jiewen.yao@intel.com>

> -----Original Message-----
> From: Sachin Ganesh <sachinganesh@ami.com>
> Sent: Saturday, April 20, 2024 5:46 AM
> To: devel@edk2.groups.io
> Cc: gaoliming@byosoft.com.cn; Liu, Zhiguang <zhiguang.liu@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>; ardb+tianocore@kernel.org;
> kraxel@redhat.com; Yao, Jiewen <jiewen.yao@intel.com>; Aktas, Erdem
> <erdemaktas@google.com>; Xu, Min M <min.m.xu@intel.com>;
> thomas.lendacky@amd.com; POLUDOV, FELIX <felixp@ami.com>; Dhanaraj V
> <vdhanaraj@ami.com>; Sachin Ganesh <sachinganesh@ami.com>
> Subject: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 Specification
> 
> This series of patches are for general updates to MdePkg and MdeModulePkg
> based on
> UEFI 2.10 and PI 1.8 Specifications
> 
> Sachin Ganesh (7):
>   MdePkg: Add definition for NVMe Over Fabric Device Path
>   MdePkg: Add new Resource Attributes defined in PI 1.8 Spec
>   MdePkg: Define Unaccepted Memory Type
>   MdeModulePkg: Use newly defined Unaccepted Memory Type
>   MdePkg: Update Delayed Dispatch PPI as per PI 1.8 Spec
>   MdePkg: Update to PI 1.8 Revision
>   OvmfPkg: Use newly defined Unaccepted Memory Type
> 
>  MdeModulePkg/Core/Dxe/Gcd/Gcd.c              | 10 +++---
>  MdeModulePkg/Core/Dxe/Mem/Page.c             | 38 ++++++++++----------
>  MdeModulePkg/Include/Pi/PrePiDxeCis.h        | 25 -------------
>  MdeModulePkg/Include/Pi/PrePiHob.h           | 20 -----------
>  MdePkg/Include/Pi/PiDxeCis.h                 | 19 +++++-----
>  MdePkg/Include/Pi/PiHob.h                    | 14 +++-----
>  MdePkg/Include/Pi/PiMmCis.h                  |  6 ++--
>  MdePkg/Include/Pi/PiMultiPhase.h             |  6 ++++
>  MdePkg/Include/Pi/PiPeiCis.h                 |  6 ++--
>  MdePkg/Include/Pi/PiSmmCis.h                 |  2 +-
>  MdePkg/Include/Ppi/DelayedDispatch.h         | 24 ++++++++++++-
>  MdePkg/Include/Protocol/DevicePath.h         | 22 ++++++++++++
>  OvmfPkg/AmdSevDxe/AmdSevDxe.c                |  4 +--
>  OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c |  8 ++---
>  OvmfPkg/Library/PeilessStartupLib/Hob.c      |  4 +--
>  OvmfPkg/Library/PlatformInitLib/IntelTdx.c   |  8 ++---
>  OvmfPkg/PlatformPei/AmdSev.c                 |  4 +--
>  17 files changed, 108 insertions(+), 112 deletions(-)
>  delete mode 100644 MdeModulePkg/Include/Pi/PrePiDxeCis.h
>  delete mode 100644 MdeModulePkg/Include/Pi/PrePiHob.h
> 
> --
> 2.24.1.windows.2
> -The information contained in this message may be confidential and proprietary
> to American Megatrends (AMI). This communication is intended to be read only by
> the individual or entity to whom it is addressed or by their designee. If the reader
> of this message is not the intended recipient, you are on notice that any
> distribution of this message, in any form, is strictly prohibited. Please promptly
> notify the sender by reply e-mail or by telephone at 770-246-8600, and then
> delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118049): https://edk2.groups.io/g/devel/message/118049
Mute This Topic: https://groups.io/mt/105630618/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH 7/7] OvmfPkg: Use newly defined Unaccepted Memory Type

[Lendacky, Thomas via groups.io]

On 4/19/24 16:46, Sachin Ganesh wrote:
> EFI_RESOURCE_MEMORY_UNACCEPTED has been officially defined in the PI
> 1.8 specification. So all temporary solutions have been replaced with
> the actual definition.
> 
> Cc: Felix Polyudov <felixp@ami.com>
> Cc: Dhanaraj V <vdhanaraj@ami.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Signed-off-by: Sachin Ganesh <sachinganesh@ami.com>

Reviewed-by: Tom Lendacky <thomas.lendacky@amd.com>

> ---
>   OvmfPkg/AmdSevDxe/AmdSevDxe.c                | 4 ++--
>   OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c | 8 ++++----
>   OvmfPkg/Library/PeilessStartupLib/Hob.c      | 4 ++--
>   OvmfPkg/Library/PlatformInitLib/IntelTdx.c   | 8 ++++----
>   OvmfPkg/PlatformPei/AmdSev.c                 | 4 ++--
>   5 files changed, 14 insertions(+), 14 deletions(-)
> 
> diff --git a/OvmfPkg/AmdSevDxe/AmdSevDxe.c b/OvmfPkg/AmdSevDxe/AmdSevDxe.c
> index db3675ae86..d497a343d3 100644
> --- a/OvmfPkg/AmdSevDxe/AmdSevDxe.c
> +++ b/OvmfPkg/AmdSevDxe/AmdSevDxe.c
> @@ -20,7 +20,7 @@
>   #include <Library/UefiBootServicesTableLib.h>
> 
>   #include <Guid/ConfidentialComputingSevSnpBlob.h>
> 
>   #include <Library/PcdLib.h>
> 
> -#include <Pi/PrePiDxeCis.h>
> 
> +#include <Pi/PiDxeCis.h>
> 
>   #include <Protocol/SevMemoryAcceptance.h>
> 
>   #include <Protocol/MemoryAccept.h>
> 
>   #include <Uefi/UefiSpec.h>
> 
> @@ -119,7 +119,7 @@ AcceptAllMemory (
>       CONST EFI_GCD_MEMORY_SPACE_DESCRIPTOR  *Desc;
> 
> 
> 
>       Desc = &AllDescMap[Index];
> 
> -    if (Desc->GcdMemoryType != EFI_GCD_MEMORY_TYPE_UNACCEPTED) {
> 
> +    if (Desc->GcdMemoryType != EfiGcdMemoryTypeUnaccepted) {
> 
>         continue;
> 
>       }
> 
> 
> 
> diff --git a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c
> index 3372cee2f7..b6085eab44 100644
> --- a/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c
> +++ b/OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c
> @@ -19,7 +19,7 @@
>   #include <Library/TdxLib.h>
> 
>   #include <Library/TdxMailboxLib.h>
> 
>   #include <Library/SynchronizationLib.h>
> 
> -#include <Pi/PrePiHob.h>
> 
> +#include <Pi/PiHob.h>
> 
>   #include <WorkArea.h>
> 
>   #include <ConfidentialComputingGuestAttr.h>
> 
>   #include <Library/TdxHelperLib.h>
> 
> @@ -351,7 +351,7 @@ AcceptMemoryForAPsStack (
>       if (Hob.Header->HobType == EFI_HOB_TYPE_RESOURCE_DESCRIPTOR) {
> 
>         DEBUG ((DEBUG_INFO, "\nResourceType: 0x%x\n", Hob.ResourceDescriptor->ResourceType));
> 
> 
> 
> -      if (Hob.ResourceDescriptor->ResourceType == BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED) {
> 
> +      if (Hob.ResourceDescriptor->ResourceType == EFI_RESOURCE_MEMORY_UNACCEPTED) {
> 
>           ResourceLength = Hob.ResourceDescriptor->ResourceLength;
> 
>           PhysicalStart  = Hob.ResourceDescriptor->PhysicalStart;
> 
>           PhysicalEnd    = PhysicalStart + ResourceLength;
> 
> @@ -427,7 +427,7 @@ AcceptMemory (
>     //
> 
>     while (!END_OF_HOB_LIST (Hob)) {
> 
>       if (Hob.Header->HobType == EFI_HOB_TYPE_RESOURCE_DESCRIPTOR) {
> 
> -      if (Hob.ResourceDescriptor->ResourceType == BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED) {
> 
> +      if (Hob.ResourceDescriptor->ResourceType == EFI_RESOURCE_MEMORY_UNACCEPTED) {
> 
>           PhysicalStart = Hob.ResourceDescriptor->PhysicalStart;
> 
>           PhysicalEnd   = PhysicalStart + Hob.ResourceDescriptor->ResourceLength;
> 
> 
> 
> @@ -563,7 +563,7 @@ ValidateHobList (
>       EFI_RESOURCE_MEMORY_MAPPED_IO_PORT,
> 
>       EFI_RESOURCE_MEMORY_RESERVED,
> 
>       EFI_RESOURCE_IO_RESERVED,
> 
> -    BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED
> 
> +    EFI_RESOURCE_MEMORY_UNACCEPTED
> 
>     };
> 
> 
> 
>     if (VmmHobList == NULL) {
> 
> diff --git a/OvmfPkg/Library/PeilessStartupLib/Hob.c b/OvmfPkg/Library/PeilessStartupLib/Hob.c
> index 318b74c95d..725927da73 100644
> --- a/OvmfPkg/Library/PeilessStartupLib/Hob.c
> +++ b/OvmfPkg/Library/PeilessStartupLib/Hob.c
> @@ -20,7 +20,7 @@
>   #include <IndustryStandard/UefiTcgPlatform.h>
> 
>   #include <Library/PlatformInitLib.h>
> 
>   #include <OvmfPlatforms.h>
> 
> -#include <Pi/PrePiHob.h>
> 
> +#include <Pi/PiHob.h>
> 
>   #include "PeilessStartupInternal.h"
> 
> 
> 
>   /**
> 
> @@ -92,7 +92,7 @@ ConstructFwHobList (
>     //
> 
>     while (!END_OF_HOB_LIST (Hob)) {
> 
>       if (Hob.Header->HobType == EFI_HOB_TYPE_RESOURCE_DESCRIPTOR) {
> 
> -      if (Hob.ResourceDescriptor->ResourceType == BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED) {
> 
> +      if (Hob.ResourceDescriptor->ResourceType == EFI_RESOURCE_MEMORY_UNACCEPTED) {
> 
>           PhysicalEnd    = Hob.ResourceDescriptor->PhysicalStart + Hob.ResourceDescriptor->ResourceLength;
> 
>           ResourceLength = Hob.ResourceDescriptor->ResourceLength;
> 
> 
> 
> diff --git a/OvmfPkg/Library/PlatformInitLib/IntelTdx.c b/OvmfPkg/Library/PlatformInitLib/IntelTdx.c
> index ada8592ddd..e561cee30b 100644
> --- a/OvmfPkg/Library/PlatformInitLib/IntelTdx.c
> +++ b/OvmfPkg/Library/PlatformInitLib/IntelTdx.c
> @@ -17,7 +17,7 @@
>   #include <IndustryStandard/Tdx.h>
> 
>   #include <IndustryStandard/IntelTdx.h>
> 
>   #include <Library/PeiServicesLib.h>
> 
> -#include <Pi/PrePiHob.h>
> 
> +#include <Pi/PiHob.h>
> 
>   #include <WorkArea.h>
> 
>   #include <ConfidentialComputingGuestAttr.h>
> 
> 
> 
> @@ -40,9 +40,9 @@ BuildResourceDescriptorHobForUnacceptedMemory (
>     EFI_RESOURCE_ATTRIBUTE_TYPE  ResourceAttribute;
> 
>     UINT64                       MaxAcceptedMemoryAddress;
> 
> 
> 
> -  ASSERT (Hob->ResourceType == BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED);
> 
> +  ASSERT (Hob->ResourceType == EFI_RESOURCE_MEMORY_UNACCEPTED);
> 
> 
> 
> -  ResourceType      = BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED;
> 
> +  ResourceType      = EFI_RESOURCE_MEMORY_UNACCEPTED;
> 
>     ResourceAttribute = Hob->ResourceAttribute;
> 
>     PhysicalStart     = Hob->PhysicalStart;
> 
>     ResourceLength    = Hob->ResourceLength;
> 
> @@ -104,7 +104,7 @@ TransferTdxHobList (
>           ResourceType      = Hob.ResourceDescriptor->ResourceType;
> 
>           ResourceAttribute = Hob.ResourceDescriptor->ResourceAttribute;
> 
> 
> 
> -        if (ResourceType == BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED) {
> 
> +        if (ResourceType == EFI_RESOURCE_MEMORY_UNACCEPTED) {
> 
>             BuildResourceDescriptorHobForUnacceptedMemory (Hob.ResourceDescriptor);
> 
>           } else {
> 
>             BuildResourceDescriptorHob (
> 
> diff --git a/OvmfPkg/PlatformPei/AmdSev.c b/OvmfPkg/PlatformPei/AmdSev.c
> index e6724cf493..88ca14507f 100644
> --- a/OvmfPkg/PlatformPei/AmdSev.c
> +++ b/OvmfPkg/PlatformPei/AmdSev.c
> @@ -17,7 +17,7 @@
>   #include <Library/MemEncryptSevLib.h>
> 
>   #include <Library/MemoryAllocationLib.h>
> 
>   #include <Library/PcdLib.h>
> 
> -#include <Pi/PrePiHob.h>
> 
> +#include <Pi/PiHob.h>
> 
>   #include <PiPei.h>
> 
>   #include <Register/Amd/Msr.h>
> 
>   #include <Register/Intel/SmramSaveStateMap.h>
> 
> @@ -149,7 +149,7 @@ AmdSevSnpInitialize (
> 
> 
>         if (ResourceHob->ResourceType == EFI_RESOURCE_SYSTEM_MEMORY) {
> 
>           if (ResourceHob->PhysicalStart >= SIZE_4GB) {
> 
> -          ResourceHob->ResourceType = BZ3937_EFI_RESOURCE_MEMORY_UNACCEPTED;
> 
> +          ResourceHob->ResourceType = EFI_RESOURCE_MEMORY_UNACCEPTED;
> 
>             continue;
> 
>           }
> 
> 
> 
> --
> 2.24.1.windows.2
> -The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118102): https://edk2.groups.io/g/devel/message/118102
Mute This Topic: https://groups.io/mt/105630626/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 Specification

[gaoliming via groups.io]

Except for Patch 6/7, others are good to me. Reviewed-by: Liming Gao
<gaoliming@byosoft.com.cn>

I suggest to merge others first. The patch 6/7 to update PI version from 1.7
to 1.8 can be discussed first. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Sachin Ganesh <sachinganesh@ami.com>
> 发送时间: 2024年4月20日 5:46
> 收件人: devel@edk2.groups.io
> 抄送: gaoliming@byosoft.com.cn; zhiguang.liu@intel.com;
> michael.d.kinney@intel.com; ardb+tianocore@kernel.org;
> kraxel@redhat.com; jiewen.yao@intel.com; erdemaktas@google.com;
> min.m.xu@intel.com; thomas.lendacky@amd.com; Felix Polyudov
> <Felixp@ami.com>; Dhanaraj V <vdhanaraj@ami.com>; Sachin Ganesh
> <sachinganesh@ami.com>
> 主题: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8
> Specification
> 
> This series of patches are for general updates to MdePkg and MdeModulePkg
> based on
> UEFI 2.10 and PI 1.8 Specifications
> 
> Sachin Ganesh (7):
>   MdePkg: Add definition for NVMe Over Fabric Device Path
>   MdePkg: Add new Resource Attributes defined in PI 1.8 Spec
>   MdePkg: Define Unaccepted Memory Type
>   MdeModulePkg: Use newly defined Unaccepted Memory Type
>   MdePkg: Update Delayed Dispatch PPI as per PI 1.8 Spec
>   MdePkg: Update to PI 1.8 Revision
>   OvmfPkg: Use newly defined Unaccepted Memory Type
> 
>  MdeModulePkg/Core/Dxe/Gcd/Gcd.c              | 10 +++---
>  MdeModulePkg/Core/Dxe/Mem/Page.c             | 38
> ++++++++++----------
>  MdeModulePkg/Include/Pi/PrePiDxeCis.h        | 25 -------------
>  MdeModulePkg/Include/Pi/PrePiHob.h           | 20 -----------
>  MdePkg/Include/Pi/PiDxeCis.h                 | 19 +++++-----
>  MdePkg/Include/Pi/PiHob.h                    | 14 +++-----
>  MdePkg/Include/Pi/PiMmCis.h                  |  6 ++--
>  MdePkg/Include/Pi/PiMultiPhase.h             |  6 ++++
>  MdePkg/Include/Pi/PiPeiCis.h                 |  6 ++--
>  MdePkg/Include/Pi/PiSmmCis.h                 |  2 +-
>  MdePkg/Include/Ppi/DelayedDispatch.h         | 24 ++++++++++++-
>  MdePkg/Include/Protocol/DevicePath.h         | 22 ++++++++++++
>  OvmfPkg/AmdSevDxe/AmdSevDxe.c                |  4 +--
>  OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c |  8 ++---
>  OvmfPkg/Library/PeilessStartupLib/Hob.c      |  4 +--
>  OvmfPkg/Library/PlatformInitLib/IntelTdx.c   |  8 ++---
>  OvmfPkg/PlatformPei/AmdSev.c                 |  4 +--
>  17 files changed, 108 insertions(+), 112 deletions(-)
>  delete mode 100644 MdeModulePkg/Include/Pi/PrePiDxeCis.h
>  delete mode 100644 MdeModulePkg/Include/Pi/PrePiHob.h
> 
> --
> 2.24.1.windows.2
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission=




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118147): https://edk2.groups.io/g/devel/message/118147
Mute This Topic: https://groups.io/mt/105690795/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] 回复: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 Specification

[Felix Polyudov via groups.io]

I think patch 6 can be updated to introduce unified PI specification versioning macros without incrementing the minor revision,
by changing PI_SPECIFICATION_MINOR_REVISION back to 70.
This will ensure compliance with the versioning schema introduced in PI 1.7B without changing the PI support level.
(the macros were introduced by PIWG mantis 2101)

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Tuesday, April 23, 2024 10:49 AM
To: Sachin Ganesh <sachinganesh@ami.com>; devel@edk2.groups.io
Cc: zhiguang.liu@intel.com; michael.d.kinney@intel.com; ardb+tianocore@kernel.org; kraxel@redhat.com; jiewen.yao@intel.com; erdemaktas@google.com; min.m.xu@intel.com; thomas.lendacky@amd.com; Felix Polyudov <Felixp@ami.com>; Dhanaraj V <vdhanaraj@ami.com>
Subject: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 Specification


**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**

Except for Patch 6/7, others are good to me. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

I suggest to merge others first. The patch 6/7 to update PI version from 1.7 to 1.8 can be discussed first.

Thanks
Liming
> -----邮件原件-----
> 发件人: Sachin Ganesh <sachinganesh@ami.com>
> 发送时间: 2024年4月20日 5:46
> 收件人: devel@edk2.groups.io
> 抄送: gaoliming@byosoft.com.cn; zhiguang.liu@intel.com;
> michael.d.kinney@intel.com; ardb+tianocore@kernel.org;
> kraxel@redhat.com; jiewen.yao@intel.com; erdemaktas@google.com;
> min.m.xu@intel.com; thomas.lendacky@amd.com; Felix Polyudov
> <Felixp@ami.com>; Dhanaraj V <vdhanaraj@ami.com>; Sachin Ganesh
> <sachinganesh@ami.com>
> 主题: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8
> Specification
>
> This series of patches are for general updates to MdePkg and
> MdeModulePkg based on UEFI 2.10 and PI 1.8 Specifications
>
> Sachin Ganesh (7):
>   MdePkg: Add definition for NVMe Over Fabric Device Path
>   MdePkg: Add new Resource Attributes defined in PI 1.8 Spec
>   MdePkg: Define Unaccepted Memory Type
>   MdeModulePkg: Use newly defined Unaccepted Memory Type
>   MdePkg: Update Delayed Dispatch PPI as per PI 1.8 Spec
>   MdePkg: Update to PI 1.8 Revision
>   OvmfPkg: Use newly defined Unaccepted Memory Type
>
>  MdeModulePkg/Core/Dxe/Gcd/Gcd.c              | 10 +++---
>  MdeModulePkg/Core/Dxe/Mem/Page.c             | 38
> ++++++++++----------
>  MdeModulePkg/Include/Pi/PrePiDxeCis.h        | 25 -------------
>  MdeModulePkg/Include/Pi/PrePiHob.h           | 20 -----------
>  MdePkg/Include/Pi/PiDxeCis.h                 | 19 +++++-----
>  MdePkg/Include/Pi/PiHob.h                    | 14 +++-----
>  MdePkg/Include/Pi/PiMmCis.h                  |  6 ++--
>  MdePkg/Include/Pi/PiMultiPhase.h             |  6 ++++
>  MdePkg/Include/Pi/PiPeiCis.h                 |  6 ++--
>  MdePkg/Include/Pi/PiSmmCis.h                 |  2 +-
>  MdePkg/Include/Ppi/DelayedDispatch.h         | 24 ++++++++++++-
>  MdePkg/Include/Protocol/DevicePath.h         | 22 ++++++++++++
>  OvmfPkg/AmdSevDxe/AmdSevDxe.c                |  4 +--
>  OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c |  8 ++---
>  OvmfPkg/Library/PeilessStartupLib/Hob.c      |  4 +--
>  OvmfPkg/Library/PlatformInitLib/IntelTdx.c   |  8 ++---
>  OvmfPkg/PlatformPei/AmdSev.c                 |  4 +--
>  17 files changed, 108 insertions(+), 112 deletions(-)  delete mode
> 100644 MdeModulePkg/Include/Pi/PrePiDxeCis.h
>  delete mode 100644 MdeModulePkg/Include/Pi/PrePiHob.h
>
> --
> 2.24.1.windows.2
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is
> intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient,
> you
are
> on notice that any distribution of this message, in any form, is
> strictly prohibited. Please promptly notify the sender by reply e-mail
> or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission=


-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118175): https://edk2.groups.io/g/devel/message/118175
Mute This Topic: https://groups.io/mt/105690795/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] 回复: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 Specification

[Sachin Ganesh via groups.io]

Hi Felix/ Liming,

Thank you for your comments. Patch 6 has been updated to only focus on consolidating the revision macros.

Patch Link: https://edk2.groups.io/g/devel/message/118246?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2Csachin%2C20%2C2%2C0%2C105721897
PR Link: https://github.com/tianocore/edk2/pull/5569

Thank you,
Sachin.

-----Original Message-----
From: Felix Polyudov <Felixp@ami.com>
Sent: Tuesday, April 23, 2024 10:58 PM
To: gaoliming <gaoliming@byosoft.com.cn>; Sachin Ganesh <sachinganesh@ami.com>; devel@edk2.groups.io
Cc: zhiguang.liu@intel.com; michael.d.kinney@intel.com; ardb+tianocore@kernel.org; kraxel@redhat.com; jiewen.yao@intel.com; erdemaktas@google.com; min.m.xu@intel.com; thomas.lendacky@amd.com; Dhanaraj V <vdhanaraj@ami.com>
Subject: RE: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 Specification

I think patch 6 can be updated to introduce unified PI specification versioning macros without incrementing the minor revision, by changing PI_SPECIFICATION_MINOR_REVISION back to 70.
This will ensure compliance with the versioning schema introduced in PI 1.7B without changing the PI support level.
(the macros were introduced by PIWG mantis 2101)

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Tuesday, April 23, 2024 10:49 AM
To: Sachin Ganesh <sachinganesh@ami.com>; devel@edk2.groups.io
Cc: zhiguang.liu@intel.com; michael.d.kinney@intel.com; ardb+tianocore@kernel.org; kraxel@redhat.com; jiewen.yao@intel.com; erdemaktas@google.com; min.m.xu@intel.com; thomas.lendacky@amd.com; Felix Polyudov <Felixp@ami.com>; Dhanaraj V <vdhanaraj@ami.com>
Subject: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 Specification


**CAUTION: The e-mail below is from an external source. Please exercise caution before opening attachments, clicking links, or following guidance.**

Except for Patch 6/7, others are good to me. Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

I suggest to merge others first. The patch 6/7 to update PI version from 1.7 to 1.8 can be discussed first.

Thanks
Liming
> -----邮件原件-----
> 发件人: Sachin Ganesh <sachinganesh@ami.com>
> 发送时间: 2024年4月20日 5:46
> 收件人: devel@edk2.groups.io
> 抄送: gaoliming@byosoft.com.cn; zhiguang.liu@intel.com;
> michael.d.kinney@intel.com; ardb+tianocore@kernel.org;
> kraxel@redhat.com; jiewen.yao@intel.com; erdemaktas@google.com;
> min.m.xu@intel.com; thomas.lendacky@amd.com; Felix Polyudov
> <Felixp@ami.com>; Dhanaraj V <vdhanaraj@ami.com>; Sachin Ganesh
> <sachinganesh@ami.com>
> 主题: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8
> Specification
>
> This series of patches are for general updates to MdePkg and
> MdeModulePkg based on UEFI 2.10 and PI 1.8 Specifications
>
> Sachin Ganesh (7):
>   MdePkg: Add definition for NVMe Over Fabric Device Path
>   MdePkg: Add new Resource Attributes defined in PI 1.8 Spec
>   MdePkg: Define Unaccepted Memory Type
>   MdeModulePkg: Use newly defined Unaccepted Memory Type
>   MdePkg: Update Delayed Dispatch PPI as per PI 1.8 Spec
>   MdePkg: Update to PI 1.8 Revision
>   OvmfPkg: Use newly defined Unaccepted Memory Type
>
>  MdeModulePkg/Core/Dxe/Gcd/Gcd.c              | 10 +++---
>  MdeModulePkg/Core/Dxe/Mem/Page.c             | 38
> ++++++++++----------
>  MdeModulePkg/Include/Pi/PrePiDxeCis.h        | 25 -------------
>  MdeModulePkg/Include/Pi/PrePiHob.h           | 20 -----------
>  MdePkg/Include/Pi/PiDxeCis.h                 | 19 +++++-----
>  MdePkg/Include/Pi/PiHob.h                    | 14 +++-----
>  MdePkg/Include/Pi/PiMmCis.h                  |  6 ++--
>  MdePkg/Include/Pi/PiMultiPhase.h             |  6 ++++
>  MdePkg/Include/Pi/PiPeiCis.h                 |  6 ++--
>  MdePkg/Include/Pi/PiSmmCis.h                 |  2 +-
>  MdePkg/Include/Ppi/DelayedDispatch.h         | 24 ++++++++++++-
>  MdePkg/Include/Protocol/DevicePath.h         | 22 ++++++++++++
>  OvmfPkg/AmdSevDxe/AmdSevDxe.c                |  4 +--
>  OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c |  8 ++---
>  OvmfPkg/Library/PeilessStartupLib/Hob.c      |  4 +--
>  OvmfPkg/Library/PlatformInitLib/IntelTdx.c   |  8 ++---
>  OvmfPkg/PlatformPei/AmdSev.c                 |  4 +--
>  17 files changed, 108 insertions(+), 112 deletions(-)  delete mode
> 100644 MdeModulePkg/Include/Pi/PrePiDxeCis.h
>  delete mode 100644 MdeModulePkg/Include/Pi/PrePiHob.h
>
> --
> 2.24.1.windows.2
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is
> intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient,
> you
are
> on notice that any distribution of this message, in any form, is
> strictly prohibited. Please promptly notify the sender by reply e-mail
> or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission=


-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118305): https://edk2.groups.io/g/devel/message/118305
Mute This Topic: https://groups.io/mt/105690795/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 Specification

[gaoliming via groups.io]

Felix and Sachin:
  I don't find PI_SPECIFICATION_MINOR_REVISION definition from the latest public PI 1.8A. So, this change may not be added now. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Sachin Ganesh <sachinganesh@ami.com>
> 发送时间: 2024年4月25日 17:57
> 收件人: Felix Polyudov <Felixp@ami.com>; gaoliming
> <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: zhiguang.liu@intel.com; michael.d.kinney@intel.com;
> ardb+tianocore@kernel.org; kraxel@redhat.com; jiewen.yao@intel.com;
> erdemaktas@google.com; min.m.xu@intel.com; thomas.lendacky@amd.com;
> Dhanaraj V <vdhanaraj@ami.com>
> 主题: RE: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI
> 2.10 and PI 1.8 Specification
> 
> Hi Felix/ Liming,
> 
> Thank you for your comments. Patch 6 has been updated to only focus on
> consolidating the revision macros.
> 
> Patch Link:
> https://edk2.groups.io/g/devel/message/118246?p=%2C%2C%2C20%2C0%2
> C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2Csachin%2C20%2C2%2C0%
> 2C105721897
> PR Link: https://github.com/tianocore/edk2/pull/5569
> 
> Thank you,
> Sachin.
> 
> -----Original Message-----
> From: Felix Polyudov <Felixp@ami.com>
> Sent: Tuesday, April 23, 2024 10:58 PM
> To: gaoliming <gaoliming@byosoft.com.cn>; Sachin Ganesh
> <sachinganesh@ami.com>; devel@edk2.groups.io
> Cc: zhiguang.liu@intel.com; michael.d.kinney@intel.com;
> ardb+tianocore@kernel.org; kraxel@redhat.com; jiewen.yao@intel.com;
> erdemaktas@google.com; min.m.xu@intel.com; thomas.lendacky@amd.com;
> Dhanaraj V <vdhanaraj@ami.com>
> Subject: RE: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI
> 2.10 and PI 1.8 Specification
> 
> I think patch 6 can be updated to introduce unified PI specification versioning
> macros without incrementing the minor revision, by changing
> PI_SPECIFICATION_MINOR_REVISION back to 70.
> This will ensure compliance with the versioning schema introduced in PI 1.7B
> without changing the PI support level.
> (the macros were introduced by PIWG mantis 2101)
> 
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Tuesday, April 23, 2024 10:49 AM
> To: Sachin Ganesh <sachinganesh@ami.com>; devel@edk2.groups.io
> Cc: zhiguang.liu@intel.com; michael.d.kinney@intel.com;
> ardb+tianocore@kernel.org; kraxel@redhat.com; jiewen.yao@intel.com;
> erdemaktas@google.com; min.m.xu@intel.com; thomas.lendacky@amd.com;
> Felix Polyudov <Felixp@ami.com>; Dhanaraj V <vdhanaraj@ami.com>
> Subject: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI 2.10
> and PI 1.8 Specification
> 
> 
> **CAUTION: The e-mail below is from an external source. Please exercise
> caution before opening attachments, clicking links, or following guidance.**
> 
> Except for Patch 6/7, others are good to me. Reviewed-by: Liming Gao
> <gaoliming@byosoft.com.cn>
> 
> I suggest to merge others first. The patch 6/7 to update PI version from 1.7 to
> 1.8 can be discussed first.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Sachin Ganesh <sachinganesh@ami.com>
> > 发送时间: 2024年4月20日 5:46
> > 收件人: devel@edk2.groups.io
> > 抄送: gaoliming@byosoft.com.cn; zhiguang.liu@intel.com;
> > michael.d.kinney@intel.com; ardb+tianocore@kernel.org;
> > kraxel@redhat.com; jiewen.yao@intel.com; erdemaktas@google.com;
> > min.m.xu@intel.com; thomas.lendacky@amd.com; Felix Polyudov
> > <Felixp@ami.com>; Dhanaraj V <vdhanaraj@ami.com>; Sachin Ganesh
> > <sachinganesh@ami.com>
> > 主题: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8
> > Specification
> >
> > This series of patches are for general updates to MdePkg and
> > MdeModulePkg based on UEFI 2.10 and PI 1.8 Specifications
> >
> > Sachin Ganesh (7):
> >   MdePkg: Add definition for NVMe Over Fabric Device Path
> >   MdePkg: Add new Resource Attributes defined in PI 1.8 Spec
> >   MdePkg: Define Unaccepted Memory Type
> >   MdeModulePkg: Use newly defined Unaccepted Memory Type
> >   MdePkg: Update Delayed Dispatch PPI as per PI 1.8 Spec
> >   MdePkg: Update to PI 1.8 Revision
> >   OvmfPkg: Use newly defined Unaccepted Memory Type
> >
> >  MdeModulePkg/Core/Dxe/Gcd/Gcd.c              | 10 +++---
> >  MdeModulePkg/Core/Dxe/Mem/Page.c             | 38
> > ++++++++++----------
> >  MdeModulePkg/Include/Pi/PrePiDxeCis.h        | 25 -------------
> >  MdeModulePkg/Include/Pi/PrePiHob.h           | 20 -----------
> >  MdePkg/Include/Pi/PiDxeCis.h                 | 19 +++++-----
> >  MdePkg/Include/Pi/PiHob.h                    | 14 +++-----
> >  MdePkg/Include/Pi/PiMmCis.h                  |  6 ++--
> >  MdePkg/Include/Pi/PiMultiPhase.h             |  6 ++++
> >  MdePkg/Include/Pi/PiPeiCis.h                 |  6 ++--
> >  MdePkg/Include/Pi/PiSmmCis.h                 |  2 +-
> >  MdePkg/Include/Ppi/DelayedDispatch.h         | 24 ++++++++++++-
> >  MdePkg/Include/Protocol/DevicePath.h         | 22 ++++++++++++
> >  OvmfPkg/AmdSevDxe/AmdSevDxe.c                |  4 +--
> >  OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c |  8 ++---
> >  OvmfPkg/Library/PeilessStartupLib/Hob.c      |  4 +--
> >  OvmfPkg/Library/PlatformInitLib/IntelTdx.c   |  8 ++---
> >  OvmfPkg/PlatformPei/AmdSev.c                 |  4 +--
> >  17 files changed, 108 insertions(+), 112 deletions(-)  delete mode
> > 100644 MdeModulePkg/Include/Pi/PrePiDxeCis.h
> >  delete mode 100644 MdeModulePkg/Include/Pi/PrePiHob.h
> >
> > --
> > 2.24.1.windows.2
> > -The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI). This communication is
> > intended
> to
> > be read only by the individual or entity to whom it is addressed or by
> their
> > designee. If the reader of this message is not the intended recipient,
> > you
> are
> > on notice that any distribution of this message, in any form, is
> > strictly prohibited. Please promptly notify the sender by reply e-mail
> > or by
> telephone
> > at 770-246-8600, and then delete or destroy all copies of the
> transmission=
> 
> 
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended to
> be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by telephone
> at 770-246-8600, and then delete or destroy all copies of the transmission.




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118322): https://edk2.groups.io/g/devel/message/118322
Mute This Topic: https://groups.io/mt/105747200/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] 回复: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 Specification

[Felix Polyudov via groups.io]

Liming,

In PI 1.8 macros for major and minor versions have been replaced with a single revision macro combining both version elements.
Refer to:
PEI: https://uefi.org/specs/PI/1.8/V1_PEI_Services_Table.html#related-definitions
DXE: https://uefi.org/specs/PI/1.8/V2_UEFI_System_Table.html#dxe-services
MM: https://uefi.org/specs/PI/1.8/V4_Management_Mode_System_Table.html#efi-mm-system-table

If patch is updated to literally follow the spec, the following macros will be removed:
PEI_SPECIFICATION_MAJOR_REVISION
PEI_SPECIFICATION_MINOR_REVISION
DXE_SPECIFICATION_MAJOR_REVISION
DXE_SPECIFICATION_MINOR_REVISION
MM_SPECIFICATION_MAJOR_REVISION
MM_SPECIFICATION_MINOR_REVISION

These macros exist for a long time, so their removal can break some code in the downstream projects.
That's why we thought it would be safer to honor the spirit of the spec without following it literally.

Let us know if you want us to update the patch to match the spec.

-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn>
Sent: Friday, April 26, 2024 5:23 AM
To: Sachin Ganesh <sachinganesh@ami.com>; Felix Polyudov <Felixp@ami.com>; devel@edk2.groups.io
Cc: zhiguang.liu@intel.com; michael.d.kinney@intel.com; ardb+tianocore@kernel.org; kraxel@redhat.com; jiewen.yao@intel.com; erdemaktas@google.com; min.m.xu@intel.com; thomas.lendacky@amd.com; Dhanaraj V <vdhanaraj@ami.com>
Subject: 回复: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 Specification

Felix and Sachin:
  I don't find PI_SPECIFICATION_MINOR_REVISION definition from the latest public PI 1.8A. So, this change may not be added now.

Thanks
Liming
> -----邮件原件-----
> 发件人: Sachin Ganesh <sachinganesh@ami.com>
> 发送时间: 2024年4月25日 17:57
> 收件人: Felix Polyudov <Felixp@ami.com>; gaoliming
> <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: zhiguang.liu@intel.com; michael.d.kinney@intel.com;
> ardb+tianocore@kernel.org; kraxel@redhat.com; jiewen.yao@intel.com;
> erdemaktas@google.com; min.m.xu@intel.com; thomas.lendacky@amd.com;
> Dhanaraj V <vdhanaraj@ami.com>
> 主题: RE: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI
> 2.10 and PI 1.8 Specification
>
> Hi Felix/ Liming,
>
> Thank you for your comments. Patch 6 has been updated to only focus on
> consolidating the revision macros.
>
> Patch Link:
> https://edk2.groups.io/g/devel/message/118246?p=%2C%2C%2C20%2C0%252
> C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2Csachin%2C20%2C2%2C0%
> 2C105721897
> PR Link: https://github.com/tianocore/edk2/pull/5569
>
> Thank you,
> Sachin.
>
> -----Original Message-----
> From: Felix Polyudov <Felixp@ami.com>
> Sent: Tuesday, April 23, 2024 10:58 PM
> To: gaoliming <gaoliming@byosoft.com.cn>; Sachin Ganesh
> <sachinganesh@ami.com>; devel@edk2.groups.io
> Cc: zhiguang.liu@intel.com; michael.d.kinney@intel.com;
> ardb+tianocore@kernel.org; kraxel@redhat.com; jiewen.yao@intel.com;
> erdemaktas@google.com; min.m.xu@intel.com; thomas.lendacky@amd.com;
> Dhanaraj V <vdhanaraj@ami.com>
> Subject: RE: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI
> 2.10 and PI 1.8 Specification
>
> I think patch 6 can be updated to introduce unified PI specification versioning
> macros without incrementing the minor revision, by changing
> PI_SPECIFICATION_MINOR_REVISION back to 70.
> This will ensure compliance with the versioning schema introduced in PI 1.7B
> without changing the PI support level.
> (the macros were introduced by PIWG mantis 2101)
>
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Tuesday, April 23, 2024 10:49 AM
> To: Sachin Ganesh <sachinganesh@ami.com>; devel@edk2.groups.io
> Cc: zhiguang.liu@intel.com; michael.d.kinney@intel.com;
> ardb+tianocore@kernel.org; kraxel@redhat.com; jiewen.yao@intel.com;
> erdemaktas@google.com; min.m.xu@intel.com; thomas.lendacky@amd.com;
> Felix Polyudov <Felixp@ami.com>; Dhanaraj V <vdhanaraj@ami.com>
> Subject: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI 2.10
> and PI 1.8 Specification
>
>
> **CAUTION: The e-mail below is from an external source. Please exercise
> caution before opening attachments, clicking links, or following guidance.**
>
> Except for Patch 6/7, others are good to me. Reviewed-by: Liming Gao
> <gaoliming@byosoft.com.cn>
>
> I suggest to merge others first. The patch 6/7 to update PI version from 1.7 to
> 1.8 can be discussed first.
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Sachin Ganesh <sachinganesh@ami.com>
> > 发送时间: 2024年4月20日 5:46
> > 收件人: devel@edk2.groups.io
> > 抄送: gaoliming@byosoft.com.cn; zhiguang.liu@intel.com;
> > michael.d.kinney@intel.com; ardb+tianocore@kernel.org;
> > kraxel@redhat.com; jiewen.yao@intel.com; erdemaktas@google.com;
> > min.m.xu@intel.com; thomas.lendacky@amd.com; Felix Polyudov
> > <Felixp@ami.com>; Dhanaraj V <vdhanaraj@ami.com>; Sachin Ganesh
> > <sachinganesh@ami.com>
> > 主题: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8
> > Specification
> >
> > This series of patches are for general updates to MdePkg and
> > MdeModulePkg based on UEFI 2.10 and PI 1.8 Specifications
> >
> > Sachin Ganesh (7):
> >   MdePkg: Add definition for NVMe Over Fabric Device Path
> >   MdePkg: Add new Resource Attributes defined in PI 1.8 Spec
> >   MdePkg: Define Unaccepted Memory Type
> >   MdeModulePkg: Use newly defined Unaccepted Memory Type
> >   MdePkg: Update Delayed Dispatch PPI as per PI 1.8 Spec
> >   MdePkg: Update to PI 1.8 Revision
> >   OvmfPkg: Use newly defined Unaccepted Memory Type
> >
> >  MdeModulePkg/Core/Dxe/Gcd/Gcd.c              | 10 +++---
> >  MdeModulePkg/Core/Dxe/Mem/Page.c             | 38
> > ++++++++++----------
> >  MdeModulePkg/Include/Pi/PrePiDxeCis.h        | 25 -------------
> >  MdeModulePkg/Include/Pi/PrePiHob.h           | 20 -----------
> >  MdePkg/Include/Pi/PiDxeCis.h                 | 19 +++++-----
> >  MdePkg/Include/Pi/PiHob.h                    | 14 +++-----
> >  MdePkg/Include/Pi/PiMmCis.h                  |  6 ++--
> >  MdePkg/Include/Pi/PiMultiPhase.h             |  6 ++++
> >  MdePkg/Include/Pi/PiPeiCis.h                 |  6 ++--
> >  MdePkg/Include/Pi/PiSmmCis.h                 |  2 +-
> >  MdePkg/Include/Ppi/DelayedDispatch.h         | 24 ++++++++++++-
> >  MdePkg/Include/Protocol/DevicePath.h         | 22 ++++++++++++
> >  OvmfPkg/AmdSevDxe/AmdSevDxe.c                |  4 +--
> >  OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c |  8 ++---
> >  OvmfPkg/Library/PeilessStartupLib/Hob.c      |  4 +--
> >  OvmfPkg/Library/PlatformInitLib/IntelTdx.c   |  8 ++---
> >  OvmfPkg/PlatformPei/AmdSev.c                 |  4 +--
> >  17 files changed, 108 insertions(+), 112 deletions(-)  delete mode
> > 100644 MdeModulePkg/Include/Pi/PrePiDxeCis.h
> >  delete mode 100644 MdeModulePkg/Include/Pi/PrePiHob.h
> >
> > --
> > 2.24.1.windows.2
> > -The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI). This communication is
> > intended
> to
> > be read only by the individual or entity to whom it is addressed or by
> their
> > designee. If the reader of this message is not the intended recipient,
> > you
> are
> > on notice that any distribution of this message, in any form, is
> > strictly prohibited. Please promptly notify the sender by reply e-mail
> > or by
> telephone
> > at 770-246-8600, and then delete or destroy all copies of the
> transmission=
>
>
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended to
> be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by telephone
> at 770-246-8600, and then delete or destroy all copies of the transmission.


-The information contained in this message may be confidential and proprietary to American Megatrends (AMI). This communication is intended to be read only by the individual or entity to whom it is addressed or by their designee. If the reader of this message is not the intended recipient, you are on notice that any distribution of this message, in any form, is strictly prohibited. Please promptly notify the sender by reply e-mail or by telephone at 770-246-8600, and then delete or destroy all copies of the transmission.


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118447): https://edk2.groups.io/g/devel/message/118447
Mute This Topic: https://groups.io/mt/105831210/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] 回复: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8 Specification

[gaoliming via groups.io]

Felix:
 I understand your point. I would suggest to directly add PI_SPECIFICATION_VERSION definition, and update PEI/DXE/SMM version to align with it. 
 
 Original PEI/DXE/SMM minor and major version definitions are still kept now. 

Thanks
Liming
> -----邮件原件-----
> 发件人: Felix Polyudov <Felixp@ami.com>
> 发送时间: 2024年5月1日 6:35
> 收件人: gaoliming <gaoliming@byosoft.com.cn>; Sachin Ganesh
> <sachinganesh@ami.com>; devel@edk2.groups.io
> 抄送: zhiguang.liu@intel.com; michael.d.kinney@intel.com;
> ardb+tianocore@kernel.org; kraxel@redhat.com; jiewen.yao@intel.com;
> erdemaktas@google.com; min.m.xu@intel.com; thomas.lendacky@amd.com;
> Dhanaraj V <vdhanaraj@ami.com>
> 主题: RE: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI
> 2.10 and PI 1.8 Specification
> 
> Liming,
> 
> In PI 1.8 macros for major and minor versions have been replaced with a
> single revision macro combining both version elements.
> Refer to:
> PEI:
> https://uefi.org/specs/PI/1.8/V1_PEI_Services_Table.html#related-definition
> s
> DXE: https://uefi.org/specs/PI/1.8/V2_UEFI_System_Table.html#dxe-services
> MM:
> https://uefi.org/specs/PI/1.8/V4_Management_Mode_System_Table.html#e
> fi-mm-system-table
> 
> If patch is updated to literally follow the spec, the following macros will be
> removed:
> PEI_SPECIFICATION_MAJOR_REVISION
> PEI_SPECIFICATION_MINOR_REVISION
> DXE_SPECIFICATION_MAJOR_REVISION
> DXE_SPECIFICATION_MINOR_REVISION
> MM_SPECIFICATION_MAJOR_REVISION
> MM_SPECIFICATION_MINOR_REVISION
> 
> These macros exist for a long time, so their removal can break some code in
> the downstream projects.
> That's why we thought it would be safer to honor the spirit of the spec
> without following it literally.
> 
> Let us know if you want us to update the patch to match the spec.
> 
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Friday, April 26, 2024 5:23 AM
> To: Sachin Ganesh <sachinganesh@ami.com>; Felix Polyudov
> <Felixp@ami.com>; devel@edk2.groups.io
> Cc: zhiguang.liu@intel.com; michael.d.kinney@intel.com;
> ardb+tianocore@kernel.org; kraxel@redhat.com; jiewen.yao@intel.com;
> erdemaktas@google.com; min.m.xu@intel.com; thomas.lendacky@amd.com;
> Dhanaraj V <vdhanaraj@ami.com>
> Subject: 回复: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on
> UEFI 2.10 and PI 1.8 Specification
> 
> Felix and Sachin:
>   I don't find PI_SPECIFICATION_MINOR_REVISION definition from the latest
> public PI 1.8A. So, this change may not be added now.
> 
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: Sachin Ganesh <sachinganesh@ami.com>
> > 发送时间: 2024年4月25日 17:57
> > 收件人: Felix Polyudov <Felixp@ami.com>; gaoliming
> > <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> > 抄送: zhiguang.liu@intel.com; michael.d.kinney@intel.com;
> > ardb+tianocore@kernel.org; kraxel@redhat.com; jiewen.yao@intel.com;
> > erdemaktas@google.com; min.m.xu@intel.com;
> thomas.lendacky@amd.com;
> > Dhanaraj V <vdhanaraj@ami.com>
> > 主题: RE: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI
> > 2.10 and PI 1.8 Specification
> >
> > Hi Felix/ Liming,
> >
> > Thank you for your comments. Patch 6 has been updated to only focus on
> > consolidating the revision macros.
> >
> > Patch Link:
> >
> https://edk2.groups.io/g/devel/message/118246?p=%2C%2C%2C20%2C0%2
> 52
> >
> C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2Csachin%2C20%2C2%2C0%
> > 2C105721897
> > PR Link: https://github.com/tianocore/edk2/pull/5569
> >
> > Thank you,
> > Sachin.
> >
> > -----Original Message-----
> > From: Felix Polyudov <Felixp@ami.com>
> > Sent: Tuesday, April 23, 2024 10:58 PM
> > To: gaoliming <gaoliming@byosoft.com.cn>; Sachin Ganesh
> > <sachinganesh@ami.com>; devel@edk2.groups.io
> > Cc: zhiguang.liu@intel.com; michael.d.kinney@intel.com;
> > ardb+tianocore@kernel.org; kraxel@redhat.com; jiewen.yao@intel.com;
> > erdemaktas@google.com; min.m.xu@intel.com;
> thomas.lendacky@amd.com;
> > Dhanaraj V <vdhanaraj@ami.com>
> > Subject: RE: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on
> UEFI
> > 2.10 and PI 1.8 Specification
> >
> > I think patch 6 can be updated to introduce unified PI specification
> versioning
> > macros without incrementing the minor revision, by changing
> > PI_SPECIFICATION_MINOR_REVISION back to 70.
> > This will ensure compliance with the versioning schema introduced in PI
> 1.7B
> > without changing the PI support level.
> > (the macros were introduced by PIWG mantis 2101)
> >
> > -----Original Message-----
> > From: gaoliming <gaoliming@byosoft.com.cn>
> > Sent: Tuesday, April 23, 2024 10:49 AM
> > To: Sachin Ganesh <sachinganesh@ami.com>; devel@edk2.groups.io
> > Cc: zhiguang.liu@intel.com; michael.d.kinney@intel.com;
> > ardb+tianocore@kernel.org; kraxel@redhat.com; jiewen.yao@intel.com;
> > erdemaktas@google.com; min.m.xu@intel.com;
> thomas.lendacky@amd.com;
> > Felix Polyudov <Felixp@ami.com>; Dhanaraj V <vdhanaraj@ami.com>
> > Subject: [EXTERNAL] 回复: [PATCH 0/7] General Updates based on UEFI
> 2.10
> > and PI 1.8 Specification
> >
> >
> > **CAUTION: The e-mail below is from an external source. Please exercise
> > caution before opening attachments, clicking links, or following guidance.**
> >
> > Except for Patch 6/7, others are good to me. Reviewed-by: Liming Gao
> > <gaoliming@byosoft.com.cn>
> >
> > I suggest to merge others first. The patch 6/7 to update PI version from 1.7
> to
> > 1.8 can be discussed first.
> >
> > Thanks
> > Liming
> > > -----邮件原件-----
> > > 发件人: Sachin Ganesh <sachinganesh@ami.com>
> > > 发送时间: 2024年4月20日 5:46
> > > 收件人: devel@edk2.groups.io
> > > 抄送: gaoliming@byosoft.com.cn; zhiguang.liu@intel.com;
> > > michael.d.kinney@intel.com; ardb+tianocore@kernel.org;
> > > kraxel@redhat.com; jiewen.yao@intel.com; erdemaktas@google.com;
> > > min.m.xu@intel.com; thomas.lendacky@amd.com; Felix Polyudov
> > > <Felixp@ami.com>; Dhanaraj V <vdhanaraj@ami.com>; Sachin Ganesh
> > > <sachinganesh@ami.com>
> > > 主题: [PATCH 0/7] General Updates based on UEFI 2.10 and PI 1.8
> > > Specification
> > >
> > > This series of patches are for general updates to MdePkg and
> > > MdeModulePkg based on UEFI 2.10 and PI 1.8 Specifications
> > >
> > > Sachin Ganesh (7):
> > >   MdePkg: Add definition for NVMe Over Fabric Device Path
> > >   MdePkg: Add new Resource Attributes defined in PI 1.8 Spec
> > >   MdePkg: Define Unaccepted Memory Type
> > >   MdeModulePkg: Use newly defined Unaccepted Memory Type
> > >   MdePkg: Update Delayed Dispatch PPI as per PI 1.8 Spec
> > >   MdePkg: Update to PI 1.8 Revision
> > >   OvmfPkg: Use newly defined Unaccepted Memory Type
> > >
> > >  MdeModulePkg/Core/Dxe/Gcd/Gcd.c              | 10 +++---
> > >  MdeModulePkg/Core/Dxe/Mem/Page.c             | 38
> > > ++++++++++----------
> > >  MdeModulePkg/Include/Pi/PrePiDxeCis.h        | 25 -------------
> > >  MdeModulePkg/Include/Pi/PrePiHob.h           | 20 -----------
> > >  MdePkg/Include/Pi/PiDxeCis.h                 | 19 +++++-----
> > >  MdePkg/Include/Pi/PiHob.h                    | 14 +++-----
> > >  MdePkg/Include/Pi/PiMmCis.h                  |  6 ++--
> > >  MdePkg/Include/Pi/PiMultiPhase.h             |  6 ++++
> > >  MdePkg/Include/Pi/PiPeiCis.h                 |  6 ++--
> > >  MdePkg/Include/Pi/PiSmmCis.h                 |  2 +-
> > >  MdePkg/Include/Ppi/DelayedDispatch.h         | 24 ++++++++++++-
> > >  MdePkg/Include/Protocol/DevicePath.h         | 22 ++++++++++++
> > >  OvmfPkg/AmdSevDxe/AmdSevDxe.c                |  4 +--
> > >  OvmfPkg/IntelTdx/TdxHelperLib/SecTdxHelper.c |  8 ++---
> > >  OvmfPkg/Library/PeilessStartupLib/Hob.c      |  4 +--
> > >  OvmfPkg/Library/PlatformInitLib/IntelTdx.c   |  8 ++---
> > >  OvmfPkg/PlatformPei/AmdSev.c                 |  4 +--
> > >  17 files changed, 108 insertions(+), 112 deletions(-)  delete mode
> > > 100644 MdeModulePkg/Include/Pi/PrePiDxeCis.h
> > >  delete mode 100644 MdeModulePkg/Include/Pi/PrePiHob.h
> > >
> > > --
> > > 2.24.1.windows.2
> > > -The information contained in this message may be confidential and
> > > proprietary to American Megatrends (AMI). This communication is
> > > intended
> > to
> > > be read only by the individual or entity to whom it is addressed or by
> > their
> > > designee. If the reader of this message is not the intended recipient,
> > > you
> > are
> > > on notice that any distribution of this message, in any form, is
> > > strictly prohibited. Please promptly notify the sender by reply e-mail
> > > or by
> > telephone
> > > at 770-246-8600, and then delete or destroy all copies of the
> > transmission=
> >
> >
> > -The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI). This communication is intended
> to
> > be read only by the individual or entity to whom it is addressed or by their
> > designee. If the reader of this message is not the intended recipient, you are
> > on notice that any distribution of this message, in any form, is strictly
> > prohibited. Please promptly notify the sender by reply e-mail or by
> telephone
> > at 770-246-8600, and then delete or destroy all copies of the transmission.
> 
> 
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended to
> be read only by the individual or entity to whom it is addressed or by their
> designee. If the reader of this message is not the intended recipient, you are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by telephone
> at 770-246-8600, and then delete or destroy all copies of the transmission.




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118580): https://edk2.groups.io/g/devel/message/118580
Mute This Topic: https://groups.io/mt/105933432/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-