From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: None (no SPF record) identity=mailfrom; client-ip=69.167.158.73; helo=host12.webserveralpha.com; envelope-from=darylm@mc2research.net; receiver=edk2-devel@lists.01.org Received: from host12.webserveralpha.com (host12.webserveralpha.com [69.167.158.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C8629210D513C for ; Wed, 1 Aug 2018 16:51:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mc2research.com; s=default; h=Content-Transfer-Encoding:Content-Type: MIME-Version:Message-ID:Date:Subject:In-Reply-To:References:To:Sender:From: Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=POjPO7XZZFerIPg/FfR6rSlqTMaG6iXyH+NTPJvUJMA=; b=f/uQtmyf6tMUaEVyo7FYXajEe5 G+5GkLXBYxloSlD0woFW+g5i1HozSLx4HlrZyKxtmFdTSHLXJIsNAqQCLAvWjjw5CoCMTu2UCuLOx PpMew38OL1/2UfOoExWzn9ETx; Received: from mobile-166-176-184-150.mycingular.net ([166.176.184.150]:58536 helo=DWIM) by host12.webserveralpha.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.91) (envelope-from ) id 1fl0tY-0007oM-P0; Wed, 01 Aug 2018 19:51:09 -0400 From: Sender: "Daryl McDaniel" To: "'Laszlo Ersek'" , References: <019f01d429bf$f3cbd060$db637120$@mc2research.org> In-Reply-To: Date: Wed, 1 Aug 2018 16:51:10 -0700 Message-ID: <01c501d429f2$867424d0$935c6e70$@mc2research.org> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQD9WDVtHghZLxgFKA/Tin2pZjnDDQG52igkpkthkBCAAAQWkA== X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - host12.webserveralpha.com X-AntiAbuse: Original Domain - lists.01.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - mc2research.net X-Get-Message-Sender-Via: host12.webserveralpha.com: authenticated_id: darylm@mc2research.com X-Authenticated-Sender: host12.webserveralpha.com: darylm@mc2research.com X-Source: X-Source-Args: X-Source-Dir: Subject: Re: Undefined types referenced in MdePkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 23:51:10 -0000 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Language: en-us Laszlo, Thank you for the pointers to the dependent header files. I agree that main API header files should include any headers that they = depend upon and not require the developer to search out the = dependencies. Most modern pre-processors and compilers have = optimizations to mitigate reading the same header file multiple times. = This invalidates the old rationale for policies that don't allow header = files to include other header files. Now, I need to find out why my search tool didn't find those headers. = =E2=98=B9 In gratitude, Daryl McDaniel The Year of the Justifiably Defensive Lobster. The Season of the fraternizing CEOs. -----Original Message----- From: edk2-devel On Behalf Of Laszlo = Ersek Sent: Wednesday, August 1, 2018 2:56 PM To: edk2-lists@mc2research.org; edk2-devel@lists.01.org Subject: Re: [edk2] Undefined types referenced in MdePkg On 08/01/18 19:49, edk2-lists@mc2research.org wrote: > When including MdePkg/Include/Library/HobLib.h in my project I get=20 > errors indicating that the following types are undefined: >=20 > * EFI_RESOURCE_TYPE, lines 206 and 231 > * EFI_RESOURCE_ATTRIBUTE_TYPE, lines 207 and 232 >=20 > =20 >=20 > A similar thing is happening with = MdePkg/Include/Protocol/FirmwareVolume2.h. >=20 > * EFI_FV_FILE_ATTRIBUTES, lines 309, 443, 612 >=20 > =20 >=20 > I updated my EDK II tree then searched the entire tree for these=20 > types. They only show up in the locations mentioned above; never = defined. >=20 > =20 >=20 > Am I missing something or are these really undefined? >=20 > =20 >=20 > I don't want to just disable these errors since that could hide a=20 > bigger problem. IMO, the header files you mention should include the following files, respectively: - MdePkg/Include/Library/HobLib.h --> MdePkg/Include/Pi/PiHob.h - MdePkg/Include/Protocol/FirmwareVolume2.h --> MdePkg/Include/Pi/PiFirmwareVolume.h I'm firmly in the camp that believes that developers should not have to = hunt down themselves the dependencies of the main API header file that = they are actually interested in. Thanks Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel