From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lucky1.263xmail.com (lucky1.263xmail.com [211.157.147.135]) by mx.groups.io with SMTP id smtpd.web12.5295.1625446834386530631 for ; Sun, 04 Jul 2021 18:00:35 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: byosoft.net, ip: 211.157.147.135, mailfrom: byomail@byosoft.net) Received: from localhost (unknown [192.168.167.69]) by lucky1.263xmail.com (Postfix) with ESMTP id 32F4AB1AF8 for ; Mon, 5 Jul 2021 09:00:16 +0800 (CST) X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-ADDR-CHECKED4: 1 bpcheck: 1 X-ABS-CHECKED: 1 X-ANTISPAM-LEVEL: 2 X-ABS-CHECKED: 1 Received: from mail.byosoft.com.cn (unknown [58.240.74.242]) by smtp.263.net (postfix) whith ESMTP id P12341T139824203822848S1625446815316864_; Mon, 05 Jul 2021 09:00:16 +0800 (CST) X-IP-DOMAINF: 1 X-UNIQUE-TAG: <73d09d37af9781cdea69b49174df48e8> X-RL-SENDER: byomail@byosoft.net X-SENDER: byomail@byosoft.net X-LOGIN-NAME: byomail@byosoft.net X-FST-TO: devel@edk2.groups.io X-RCPT-COUNT: 1 X-SENDER-IP: 58.240.74.242 X-ATTACHMENT-NUM: 0 X-System-Flag: 0 Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Mon, 05 Jul 2021 08:52:58 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , , Cc: "'manickavasakam karpagavinayagam'" , , , , , , References: <20210618153734.11983-1-manickavasakamk@ami.com> <008101d7663f$a0a85c40$e1f914c0$@byosoft.com.cn> <168B5E8EE0C4DCE3.15098@groups.io> <168D3794E1211FAC.32224@groups.io> In-Reply-To: <168D3794E1211FAC.32224@groups.io> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0g5Zue5aSNOiBbZWRrMl1bUEFUQ0ggVjNdIE1kZVBrZyA6IEFkZCBJUE1JIE1hY3JvIGFuZCBTdHJ1Y3R1cmUgRGVmaW50aW9ucyB0byByZXNvbHZlIGJ1aWxkIGVycm9ycw==?= Date: Mon, 5 Jul 2021 08:52:58 +0800 Message-ID: <01c801d77138$193797e0$4ba6c7a0$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQKnQ/fofiCCKF3z1d0NqyaDwGwf0AHmU43KAORKmXMCYRnInAIHj2TwqVpNrPA= Sender: "gaoliming" Content-Type: multipart/alternative; boundary="----=_NextPart_000_01C9_01D7717B.275CACA0" Content-Language: zh-cn ------=_NextPart_000_01C9_01D7717B.275CACA0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable This patch in MdePkg has been merged at 55dee4947b20103fc48858b18307bd2b114= dc145 on edk2 master. =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 gaoliming =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B46=E6=9C=8830=E6=97=A5 9= :22 =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.com.c= n; lateefcs@gmail.com =E6=8A=84=E9=80=81: 'manickavasakam karpagavinayagam' ; isaac.w.oram@intel.com; nathaniel.l.desimone@intel.com; Felixp@ami.c= om; Harikrishnad@ami.com; manishj@ami.com; zacharyb@ami.com =E4=B8=BB=E9=A2=98: =E5=9B=9E=E5=A4=8D: [edk2-devel] =E5=9B=9E=E5=A4=8D: [= edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defintions to resolve= build errors =20 If no other comment, I will create PR to merge this patch.=20 =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > =E4=BB=A3=E8= =A1=A8 gaoliming =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B46=E6=9C=8824=E6=97=A5 8= :54 =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io ; lateefcs@gmail.com =20 =E6=8A=84=E9=80=81: 'manickavasakam karpagavinayagam' >; isaac.w.oram@intel.com ; nathaniel.l.desimone@intel.com ; Felixp@ami.com ; Harikrishnad@= ami.com ; manishj@ami.com ; zacharyb@ami.com =20 =E4=B8=BB=E9=A2=98: =E5=9B=9E=E5=A4=8D: [edk2-devel] =E5=9B=9E=E5=A4=8D: [= edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defintions to resolve= build errors =20 AbduL: This is same to the definition of UINT8 CompletionCode without bitfield. =20 Thanks Liming =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > =E4=BB=A3=E8= =A1=A8 AbduL Lateef =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B46=E6=9C=8823=E6=97=A5 1= 9:43 =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io ; gaoliming@byosoft.com.cn =20 =E6=8A=84=E9=80=81: manickavasakam karpagavinayagam >; isaac.w.oram@intel.com ; nathaniel.l.desimone@intel.com ; Felixp@ami.com ; Harikrishnad@am= i.com ; manishj@ami.com ; zacharyb@ami.com =20 =E4=B8=BB=E9=A2=98: Re: [edk2-devel] =E5=9B=9E=E5=A4=8D: [edk2][PATCH V3] = MdePkg : Add IPMI Macro and Structure Defintions to resolve build errors =20 whats the use of bitfield:8 for UINT8 variable type? +typedef struct { + UINT8 CompletionCode:8; +} IPMI_SET_BOOT_OPTIONS_RESPONSE; =20 Thanks AbduL =20 On Mon, Jun 21, 2021 at 7:19 AM gaoliming > wrote: Thanks for you update.=20 Reviewed-by: Liming Gao > Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: manickavasakam karpagavinayagam > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B46=E6=9C=8818=E6=97=A5= 23:38 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io =20 > =E6=8A=84=E9=80=81: isaac.w.oram@intel.com ; nathaniel.l.desimone@intel.com = ; > Felixp@ami.com ; Harikrishnad@ami.com ; manishj@ami.com ; > zacharyb@ami.com ; manickavasakamk@ami.com ; > gaoliming@byosoft.com.cn =20 > =E4=B8=BB=E9=A2=98: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structu= re Defintions > to resolve build errors >=20 > Build error reported for missing structures > IPMI_SET_BOOT_OPTIONS_RESPONSE, > EFI_IPMI_MSG_GET_BMC_EXEC_RSP and > macros EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCE > D_UPDATE_MODE > when using > edk2-platforms\Features\Intel\OutOfBandManagement\IpmiFeaturePkg >=20 > MdePkg : Rename IPMI Macro and Structure Defintions >=20 > Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB, > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to > IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT > IPMI_BMC_IN_FORCED_UPDATE_MODE >=20 > Notes: > V1 : > Rename the EFI_IPMI_MSG_GET_BMC_EXEC_RSPB, > EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT > EFI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to > IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_BMC_EXECUTION_CONTEXT > IPMI_BMC_IN_FORCED_UPDATE_MODE >=20 > V2: >=20 > Remove 0001-MdePkg-Add-IPMI-Macro-and-Structure-Defintions-to-re.patch >=20 > V3: >=20 > Add Signed-off-by information >=20 > Signed-off-by: Manickavasakam Karpagavinayagam > > > --- > .../IndustryStandard/IpmiNetFnChassis.h | 4 ++++ > .../IndustryStandard/IpmiNetFnFirmware.h | 18 > ++++++++++++++++++ > 2 files changed, 22 insertions(+) >=20 > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > index 79db55523d..d7cdd3a865 100644 > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h > @@ -186,6 +186,10 @@ typedef struct { > UINT8 ParameterData[0]; >=20 > } IPMI_SET_BOOT_OPTIONS_REQUEST; >=20 >=20 >=20 > +typedef struct { >=20 > + UINT8 CompletionCode:8; >=20 > +} IPMI_SET_BOOT_OPTIONS_RESPONSE; >=20 > + >=20 > // >=20 > // Definitions for Get System Boot options command >=20 > // >=20 > diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > index 2d892dbd5a..c4cbe2349b 100644 > --- a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > +++ b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h > @@ -17,4 +17,22 @@ > // All Firmware commands and their structure definitions to follow here >=20 > // >=20 >=20 >=20 > +// --------------------------------------------------------------------------= -- ------------ >=20 > +// Definitions for Get BMC Execution Context >=20 > +// --------------------------------------------------------------------------= -- ------------ >=20 > +#define IPMI_GET_BMC_EXECUTION_CONTEXT 0x23 >=20 > + >=20 > +// >=20 > +// Constants and Structure definitions for "Get Device ID" command to > follow here >=20 > +// >=20 > +typedef struct { >=20 > + UINT8 CurrentExecutionContext; >=20 > + UINT8 PartitionPointer; >=20 > +} IPMI_MSG_GET_BMC_EXEC_RSP; >=20 > + >=20 > +// >=20 > +// Current Execution Context responses >=20 > +// >=20 > +#define IPMI_BMC_IN_FORCED_UPDATE_MODE 0x11 >=20 > + >=20 > #endif >=20 > -- > 2.25.0.windows.1 >=20 >=20 > Please consider the environment before printing this email. >=20 > The information contained in this message may be confidential and > proprietary to American Megatrends (AMI). This communication is intende= d > to be read only by the individual or entity to whom it is addressed or b= y their > designee. If the reader of this message is not the intended recipient, y= ou are > on notice that any distribution of this message, in any form, is strictl= y > prohibited. Please promptly notify the sender by reply e-mail or by > telephone at 770-246-8600, and then delete or destroy all copies of the > transmission. =20 --=20 Thanks and Regards Abdul Lateef Attar Bangalore ------=_NextPart_000_01C9_01D7717B.275CACA0 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable

This patch in MdePkg has been merged at 55dee4947b20103f= c48858b18307bd2b114dc145 on edk2 master.

 

Tha= nks

Liming

=E5=8F=91=E4=BB=B6=E4=BA=BA:= devel@edk2.groups.io <devel@edk2.groups.io> =E4= =BB=A3=E8=A1=A8 gaoliming
=E5=8F=91=E9=80=81=E6=97=B6=E9=97= = =B4: 2021=E5=B9=B46<= /span>=E6=9C=8830=E6=97=A5 9:2= 2
=E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.com.cn; lateefcs@= gmail.com
=E6=8A=84=E9=80=81: 'manickavasakam karpagavinayagam' <manickavasakamk@ami.= com>; isaac.w.oram@intel.com; nathaniel.l.desimone@intel.com; Felixp@ami= .com; Harikrishnad@ami.com; manishj@ami.com; zacharyb@ami.com
= = =E4=B8=BB=E9=A2=98: =E5=9B=9E=E5=A4=8D: [edk2-devel] =E5=9B=9E=E5= =A4=8D: [edk2][PATCH V3] MdePkg : Add IPMI Macro and St= ructure Defintions to resolve build errors

 

If no other comment, I will create PR to merge this= patch.

 

Thanks

Liming

= =E5=8F=91= =E4=BB=B6=E4=BA=BA: devel@edk2.groups.io <devel@edk2.groups.io> =E4=BB=A3=E8=A1=A8 gaoliming
=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9=B46=E6=9C=8824=E6=97=A5 8:54
=E6=94= =B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; lateefcs@gmail.com
=E6=8A=84=E9= = =80=81: 'manickavasakam k= arpagavinayagam' <manickavasa= kamk@ami.com>; isaac.w.ora= m@intel.com; nathanie= l.l.desimone@intel.com; Felixp@ami.co= m; Harikrishnad@ami.com; manishj@ami.com; zacharyb@ami.com
=E4=B8=BB=E9=A2=98: =E5=9B=9E=E5=A4=8D: [edk2-devel] =E5=9B=9E=E5=A4=8D: [e= dk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defintions to resolve = build errors

<= span lang=3DEN-US> 

AbduL:=

 This is same to the defi= nition of UINT8 CompletionCode without bitfield.

 

Tha= nks

Liming

=E5=8F=91=E4=BB=B6=E4=BA=BA: devel@e= dk2.groups.io <devel@edk2.gr= oups.io> =E4=BB=A3=E8=A1=A8 AbduL Lateef
=E5=8F=91= =E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9= = =B46=E6=9C=8823=E6=97= =A5 19:43
=E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; gaoliming@byosoft.com.cn
=E6=8A=84=E9=80=81: manickavasakam karpagavinayagam &= lt;manickavasakamk@ami.com&g= t;; isaac.w.oram@intel.com; <= a href=3D"mailto:nathaniel.l.desimone@intel.com">nathaniel.l.desimone@intel= .com; Felixp@ami.com; Harikrishnad@ami.com; manishj@ami.com; zac= haryb@ami.com
=E4=B8=BB=E9=A2=98: Re: [edk2-devel] =E5=9B=9E=E5=A4=8D: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Definti= ons to resolve build errors

 

whats the use of bitfield:8 for UINT8 vari= able type?

+typedef struct {
+ UINT8 CompletionCode:8;
+} IPMI_SET_BOO= T_OPTIONS_RESPONSE;

 

Thanks

AbduL

 

On Mon, Jun 21, 2021 at 7:19 AM gaolim= ing <gaoliming@byosoft.com.c= n> wrote:

Thanks for you update= .

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

Thanks
= Liming
> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: manickavasakam karpagavinayagam <manickavasakamk@ami.com>
> = =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2021=E5=B9= = =B46=E6=9C=8818=E6=97= =A5 23:38
> =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io
> =E6=8A=84=E9=80=81: isaac.w.or= am@intel.com; nathaniel.l.desimone@intel.com;
> Felixp@ami.com; Harikrishnad@ami.com; manishj@ami.com;
> zacharyb@ami.com; manickavasakamk@am= i.com;
> gaoliming@byosoft.com.cn
> =E4=B8=BB=E9=A2=98: [edk2][PATCH V3] MdePkg : Add IPMI Macro and Structure Defint= ions
> to resolve build errors
>
> Build error reported = for missing structures
> IPMI_SET_BOOT_OPTIONS_RESPONSE,
> EFI_= IPMI_MSG_GET_BMC_EXEC_RSP and
> macros EFI_FIRMWARE_GET_BMC_EXECUTION= _CONTEXT
> EFI_FIRMWARE_BMC_IN_FULL_RUNTIME/EFI_FIRMWARE_BMC_IN_FORCE=
> D_UPDATE_MODE
> when using
> edk2-platforms\Features\I= ntel\OutOfBandManagement\IpmiFeaturePkg
>
> MdePkg : Rename IP= MI Macro and Structure Defintions
>
> Rename the EFI_IPMI_MSG_= GET_BMC_EXEC_RSPB,
> EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> E= FI_FIRMWARE_BMC_IN_FORCED_UPDATE_MODE to
> IPMI_MSG_GET_BMC_EXEC_RSPB= ,IPMI_GET_BMC_EXECUTION_CONTEXT
> IPMI_BMC_IN_FORCED_UPDATE_MODE
&= gt;
> Notes:
> V1 :
> Rename the EFI_IPMI_MSG_GET_BMC_EX= EC_RSPB,
> EFI_FIRMWARE_GET_BMC_EXECUTION_CONTEXT
> EFI_FIRMWAR= E_BMC_IN_FORCED_UPDATE_MODE to
> IPMI_MSG_GET_BMC_EXEC_RSPB,IPMI_GET_= BMC_EXECUTION_CONTEXT
> IPMI_BMC_IN_FORCED_UPDATE_MODE
>
&g= t; V2:
>
> Remove 0001-MdePkg-Add-IPMI-Macro-and-Structure-Def= intions-to-re.patch
>
> V3:
>
> Add Signed-off-by= information
>
> Signed-off-by: Manickavasakam Karpagavinayaga= m
> <= manickavasakamk@ami.com>
> ---
>  .../IndustryStand= ard/IpmiNetFnChassis.h        |  4 ++++
>&nb= sp; .../IndustryStandard/IpmiNetFnFirmware.h       | 18=
> ++++++++++++++++++
>  2 files changed, 22 insertions(+)=
>
> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnCha= ssis.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnChassis.h
>= index 79db55523d..d7cdd3a865 100644
> --- a/MdePkg/Include/IndustryS= tandard/IpmiNetFnChassis.h
> +++ b/MdePkg/Include/IndustryStandard/Ip= miNetFnChassis.h
> @@ -186,6 +186,10 @@ typedef struct {
> = ;   UINT8                 = ;                 ParameterData[0];=
>
>  } IPMI_SET_BOOT_OPTIONS_REQUEST;
>
> <= br>>
> +typedef struct {
>
> +  UINT8  &nb= sp;CompletionCode:8;
>
> +} IPMI_SET_BOOT_OPTIONS_RESPONSE;>
> +
>
>  //
>
>  //  = Definitions for Get System Boot options command
>
>  //>
> diff --git a/MdePkg/Include/IndustryStandard/IpmiNetFnFirmw= are.h
> b/MdePkg/Include/IndustryStandard/IpmiNetFnFirmware.h
>= index 2d892dbd5a..c4cbe2349b 100644
> --- a/MdePkg/Include/IndustryS= tandard/IpmiNetFnFirmware.h
> +++ b/MdePkg/Include/IndustryStandard/I= pmiNetFnFirmware.h
> @@ -17,4 +17,22 @@
>  // All Firmware= commands and their structure definitions to follow here
>
>&n= bsp; //
>
>
>
> +//
-------------------------= ---------------------------------------------------
------------
>=
> +//    Definitions for Get BMC Execution Context
>= ;
> +//
---------------------------------------------------------= -------------------
------------
>
> +#define IPMI_GET_BMC_= EXECUTION_CONTEXT  0x23
>
> +
>
> +//
>= ;
> +//  Constants and Structure definitions for "Get Devi= ce ID" command to
> follow here
>
> +//
> > +typedef struct {
>
> +  UINT8   CurrentE= xecutionContext;
>
> +  UINT8   PartitionPointe= r;
>
> +} IPMI_MSG_GET_BMC_EXEC_RSP;
>
> +
>= ;
> +//
>
> +// Current Execution Context responses
= >
> +//
>
> +#define IPMI_BMC_IN_FORCED_UPDATE_MODE&= nbsp; 0x11
>
> +
>
>  #endif
>
>= ; --
> 2.25.0.windows.1
>
>
> Please consider the= environment before printing this email.
>
> The information c= ontained in this message may be confidential and
> proprietary to Ame= rican Megatrends (AMI).  This communication is intended
> to be = read only by the individual or entity to whom it is addressed or by
thei= r
> designee. If the reader of this message is not the intended recip= ient, you
are
> on notice that any distribution of this message, i= n any form, is strictly
> prohibited.  Please promptly notify th= e sender by reply e-mail or by
> telephone at 770-246-8600, and then = delete or destroy all copies of the
> transmission.




<= span lang=3DEN-US> 

--

Thanks and Regards
Abdul Lateef Attar
Bangalore

------=_NextPart_000_01C9_01D7717B.275CACA0--