From: "gaoliming" <gaoliming@byosoft.com.cn>
To: <devel@edk2.groups.io>, <kuqin12@gmail.com>
Cc: "'Jian J Wang'" <jian.j.wang@intel.com>,
"'Hao A Wu'" <hao.a.wu@intel.com>,
"'Bret Barkelew'" <Bret.Barkelew@microsoft.com>,
"'Michael Kubacki'" <michael.kubacki@microsoft.com>
Subject: 回复: [edk2-devel] [PATCH v2 1/6] MdeModulePkg: VariableSmmRuntimeDxe: Fix Variable Policy Message Length
Date: Tue, 11 Jan 2022 09:18:32 +0800 [thread overview]
Message-ID: <01c801d80689$2653ec30$72fbc490$@byosoft.com.cn> (raw)
In-Reply-To: <20211221013334.1751-2-kuqin12@gmail.com>
Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Kun Qin
> 发送时间: 2021年12月21日 9:33
> 收件人: devel@edk2.groups.io
> 抄送: Jian J Wang <jian.j.wang@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Hao A Wu <hao.a.wu@intel.com>; Bret
> Barkelew <Bret.Barkelew@microsoft.com>; Michael Kubacki
> <michael.kubacki@microsoft.com>
> 主题: [edk2-devel] [PATCH v2 1/6] MdeModulePkg: VariableSmmRuntimeDxe:
> Fix Variable Policy Message Length
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3709
>
> In EDKII implementation of variable policy, the DXE runtime agent would
> communicate to MM to disable, register or query policies. However, these
> operations populate the value of MessageLength that includes communicate
> header to include MM communicate header, which mismatches with the
> description of PI specification.
>
> This fix will correct the MessageLength field calculation to exclude
> the size of MM_COMMUNICATE_HEADER.
>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Michael Kubacki <michael.kubacki@microsoft.com>
>
> Signed-off-by: Kun Qin <kuqin12@gmail.com>
> ---
>
> Notes:
> v2:
> - No review, no updates
>
> MdeModulePkg/Universal/Variable/RuntimeDxe/VariablePolicySmmDxe.c |
> 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git
> a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariablePolicySmmDxe.c
> b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariablePolicySmmDxe.c
> index 672a2293bcb1..b2094fbcd6ea 100644
> ---
> a/MdeModulePkg/Universal/Variable/RuntimeDxe/VariablePolicySmmDxe.c
> +++
> b/MdeModulePkg/Universal/Variable/RuntimeDxe/VariablePolicySmmDxe.c
> @@ -89,7 +89,7 @@ ProtocolDisableVariablePolicy (
> CommHeader = mMmCommunicationBuffer;
> PolicyHeader = (VAR_CHECK_POLICY_COMM_HEADER
> *)&CommHeader->Data;
> CopyGuid (&CommHeader->HeaderGuid,
> &gVarCheckPolicyLibMmiHandlerGuid);
> - CommHeader->MessageLength = BufferSize;
> + CommHeader->MessageLength = BufferSize - OFFSET_OF
> (EFI_MM_COMMUNICATE_HEADER, Data);
> PolicyHeader->Signature = VAR_CHECK_POLICY_COMM_SIG;
> PolicyHeader->Revision = VAR_CHECK_POLICY_COMM_REVISION;
> PolicyHeader->Command =
> VAR_CHECK_POLICY_COMMAND_DISABLE;
> @@ -138,7 +138,7 @@ ProtocolIsVariablePolicyEnabled (
> PolicyHeader = (VAR_CHECK_POLICY_COMM_HEADER
> *)&CommHeader->Data;
> CommandParams = (VAR_CHECK_POLICY_COMM_IS_ENABLED_PARAMS
> *)(PolicyHeader + 1);
> CopyGuid (&CommHeader->HeaderGuid,
> &gVarCheckPolicyLibMmiHandlerGuid);
> - CommHeader->MessageLength = BufferSize;
> + CommHeader->MessageLength = BufferSize - OFFSET_OF
> (EFI_MM_COMMUNICATE_HEADER, Data);
> PolicyHeader->Signature = VAR_CHECK_POLICY_COMM_SIG;
> PolicyHeader->Revision = VAR_CHECK_POLICY_COMM_REVISION;
> PolicyHeader->Command =
> VAR_CHECK_POLICY_COMMAND_IS_ENABLED;
> @@ -213,7 +213,7 @@ ProtocolRegisterVariablePolicy (
> PolicyHeader = (VAR_CHECK_POLICY_COMM_HEADER
> *)&CommHeader->Data;
> PolicyBuffer = (VOID *)(PolicyHeader + 1);
> CopyGuid (&CommHeader->HeaderGuid,
> &gVarCheckPolicyLibMmiHandlerGuid);
> - CommHeader->MessageLength = BufferSize;
> + CommHeader->MessageLength = BufferSize - OFFSET_OF
> (EFI_MM_COMMUNICATE_HEADER, Data);
> PolicyHeader->Signature = VAR_CHECK_POLICY_COMM_SIG;
> PolicyHeader->Revision = VAR_CHECK_POLICY_COMM_REVISION;
> PolicyHeader->Command =
> VAR_CHECK_POLICY_COMMAND_REGISTER;
> @@ -270,7 +270,7 @@ DumpVariablePolicyHelper (
> PolicyHeader = (VAR_CHECK_POLICY_COMM_HEADER
> *)&CommHeader->Data;
> CommandParams = (VAR_CHECK_POLICY_COMM_DUMP_PARAMS
> *)(PolicyHeader + 1);
> CopyGuid (&CommHeader->HeaderGuid,
> &gVarCheckPolicyLibMmiHandlerGuid);
> - CommHeader->MessageLength = BufferSize;
> + CommHeader->MessageLength = BufferSize - OFFSET_OF
> (EFI_MM_COMMUNICATE_HEADER, Data);
> PolicyHeader->Signature = VAR_CHECK_POLICY_COMM_SIG;
> PolicyHeader->Revision = VAR_CHECK_POLICY_COMM_REVISION;
> PolicyHeader->Command =
> VAR_CHECK_POLICY_COMMAND_DUMP;
> @@ -397,7 +397,7 @@ ProtocolLockVariablePolicy (
> CommHeader = mMmCommunicationBuffer;
> PolicyHeader = (VAR_CHECK_POLICY_COMM_HEADER
> *)&CommHeader->Data;
> CopyGuid (&CommHeader->HeaderGuid,
> &gVarCheckPolicyLibMmiHandlerGuid);
> - CommHeader->MessageLength = BufferSize;
> + CommHeader->MessageLength = BufferSize - OFFSET_OF
> (EFI_MM_COMMUNICATE_HEADER, Data);
> PolicyHeader->Signature = VAR_CHECK_POLICY_COMM_SIG;
> PolicyHeader->Revision = VAR_CHECK_POLICY_COMM_REVISION;
> PolicyHeader->Command =
> VAR_CHECK_POLICY_COMMAND_LOCK;
> --
> 2.32.0.windows.1
>
>
>
>
>
next prev parent reply other threads:[~2022-01-11 1:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 1:33 [PATCH v2 0/6] MM communicate functionality in variable policy Kun Qin
2021-12-21 1:33 ` [PATCH v2 1/6] MdeModulePkg: VariableSmmRuntimeDxe: Fix Variable Policy Message Length Kun Qin
2022-01-11 1:18 ` gaoliming [this message]
2021-12-21 1:33 ` [PATCH v2 2/6] MdePkg: MmCommunication2: Update MM communicate2 function description Kun Qin
2022-01-04 3:22 ` 回复: [edk2-devel] " gaoliming
2021-12-21 1:33 ` [PATCH v2 3/6] ArmPkg: MmCommunicationDxe: MM communicate function argument attributes Kun Qin
2021-12-21 1:33 ` [PATCH v2 4/6] ArmPkg: MmCommunicationDxe: Update MM communicate `CommBuffer**` checks Kun Qin
2021-12-21 1:33 ` [PATCH v2 5/6] ArmPkg: MmCommunicationDxe: Update MM communicate `CommSize` check Kun Qin
2021-12-21 1:33 ` [PATCH v2 6/6] ArmPkg: MmCommunicationDxe: Update MM communicate `MessageLength` check Kun Qin
2022-01-18 18:40 ` [edk2-devel] [PATCH v2 0/6] MM communicate functionality in variable policy Kun Qin
2022-01-18 22:04 ` Rebecca Cran
2022-01-18 22:06 ` Kun Qin
2022-01-19 7:59 ` Sami Mujawar
2022-01-19 9:37 ` Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01c801d80689$2653ec30$72fbc490$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox