From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web08.2682.1651019544559153362
 for <devel@edk2.groups.io>;
 Tue, 26 Apr 2022 17:32:26 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([101.224.116.119])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <abner.chang@hpe.com>; Wed, 27 Apr 2022 08:32:18 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-Originating-IP: 101.224.116.119
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Ard Biesheuvel'" <ardb@kernel.org>,
	"'edk2-devel-groups-io'" <devel@edk2.groups.io>,
	"'Gerd Hoffmann'" <kraxel@redhat.com>
Cc: "'Pawel Polawski'" <ppolawsk@redhat.com>,
	"'Ard Biesheuvel'" <ardb+tianocore@kernel.org>,
	"'Hao A Wu'" <hao.a.wu@intel.com>,
	"'Ray Ni'" <ray.ni@intel.com>,
	"'Oliver Steffen'" <osteffen@redhat.com>,
	"'Leif Lindholm'" <quic_llindhol@quicinc.com>,
	"'Jordan Justen'" <jordan.l.justen@intel.com>,
	"'Jiewen Yao'" <jiewen.yao@intel.com>,
	"'Abner Chang'" <abner.chang@hpe.com>,
	"'Jian J Wang'" <jian.j.wang@intel.com>
References: <20220422073713.2087781-1-kraxel@redhat.com> <20220422073713.2087781-2-kraxel@redhat.com> <CAMj1kXEsAkpBpR+njguw+Lf6s3tqiaSAe=Ne0krtfee4eCgW0w@mail.gmail.com>
In-Reply-To: <CAMj1kXEsAkpBpR+njguw+Lf6s3tqiaSAe=Ne0krtfee4eCgW0w@mail.gmail.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHY1IDEvNl0gTWRlTW9kdWxlUGtnL1BjaUhvc3RCcmlkZ2U6IGlvIHJhbmdlIGlzIG5vdCBtYW5kYXRvcnk=?=
Date: Wed, 27 Apr 2022 08:32:20 +0800
Message-ID: <01c801d859ce$417f81c0$c47e8540$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQHk056ZPoM2FDWaUeILs4yS4H/hwQGL2Ch5AS2ZTfas1CmkcA==
Content-Type: text/plain;
	charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Acked-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6-----
> =E5=8F=91=E4=BB=B6=E4=BA=BA: Ard Biesheuvel <ardb@kernel.org>
> =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B44=E6=9C=8826=E6=97=A5 =
4:49
> =E6=94=B6=E4=BB=B6=E4=BA=BA: edk2-devel-groups-io <devel@edk2.groups.io>;=
 Gerd Hoffmann
> <kraxel@redhat.com>
> =E6=8A=84=E9=80=81: Pawel Polawski <ppolawsk@redhat.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Liming Gao <gaoliming@byosoft.com.cn>; Hao
> A Wu <hao.a.wu@intel.com>; Ray Ni <ray.ni@intel.com>; Oliver Steffen
> <osteffen@redhat.com>; Leif Lindholm <quic_llindhol@quicinc.com>; Jordan
> Justen <jordan.l.justen@intel.com>; Jiewen Yao <jiewen.yao@intel.com>;
> Abner Chang <abner.chang@hpe.com>; Jian J Wang <jian.j.wang@intel.com>
> =E4=B8=BB=E9=A2=98: Re: [edk2-devel] [PATCH v5 1/6] MdeModulePkg/PciHostB=
ridge: io
> range is not mandatory
>=20
> On Fri, 22 Apr 2022 at 09:37, Gerd Hoffmann <kraxel@redhat.com> wrote:
> >
> > io range is not mandatory according to pcie spec,
> > so allow bridge configurations without io address
> > space assigned.
> >
> > Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> > Reviewed-by: Ard Biesheuvel <ardb@kernel.org>
>=20
> Could one of the MdeModulePkg maintainers please get this reviewed?
> Thanks.
>=20
> > ---
> >  MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
> b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
> > index b20bcd310ad5..712662707931 100644
> > --- a/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
> > +++ b/MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c
> > @@ -1085,6 +1085,9 @@ NotifyPhase (
> >                RootBridge->ResAllocNode[Index].Base   =3D
> BaseAddress;
> >                RootBridge->ResAllocNode[Index].Status =3D ResAllocated;
> >                DEBUG ((DEBUG_INFO, "Success\n"));
> > +            } else if ((Index =3D=3D TypeIo) && (RootBridge->Io.Base =
=3D=3D
> MAX_UINT64)) {
> > +              /* optional on PCIe */
> > +              DEBUG ((DEBUG_INFO, "PCI Root Bridge does not
> provide IO Resources.\n"));
> >              } else {
> >                ReturnStatus =3D EFI_OUT_OF_RESOURCES;
> >                DEBUG ((DEBUG_ERROR, "Out Of Resource!\n"));
> > --
> > 2.35.1
> >
> >
> >
> >=20
> >
> >