From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web12.342.1641863958025739753 for ; Mon, 10 Jan 2022 17:19:18 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Tue, 11 Jan 2022 09:19:12 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , References: <20220110032535.232-1-zhiguang.liu@intel.com> In-Reply-To: <20220110032535.232-1-zhiguang.liu@intel.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBXaWtpOiBBZGQgb3B0aW9uYWwgc3RlcHMgZm9yIGRldmVsb3BlciB0byBydW4gQ0kgdGVzdCBiZWZvcmUgc2VuZGluZw==?= Date: Tue, 11 Jan 2022 09:19:16 +0800 Message-ID: <01c901d80689$4068dd10$c13a9730$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQEQTSbkHqcamLZdVE+VYSsoWvQqda3seCHw Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Zhiguang: Thanks for your update. Reviewed-by: Liming Gao = Thanks Liming > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io = =B4=FA=B1=ED Zhiguang Liu > =B7=A2=CB=CD=CA=B1=BC=E4: 2022=C4=EA1=D4=C210=C8=D5 11:26 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Liming Gao > =D6=F7=CC=E2: [edk2-devel] [PATCH] Wiki: Add optional steps for = developer to run CI > test before sending >=20 > Cc: Liming Gao > Signed-off-by: Zhiguang Liu > --- > EDK-II-Development-Process.md | 60 > +++++++++++++++++++++++++++++++++++++++++++++--------------- > 1 file changed, 45 insertions(+), 15 deletions(-) >=20 > diff --git a/EDK-II-Development-Process.md > b/EDK-II-Development-Process.md > index 469a979..747c6e1 100644 > --- a/EDK-II-Development-Process.md > +++ b/EDK-II-Development-Process.md > @@ -59,20 +59,50 @@ The developer process for the EDK II project >=20 > `$ git rebase origin/master` >=20 > -9. Run the automated code formatting tool (Uncrustify) against your changes >=20 > - >=20 > - - [EDK-II-Code-Formatting](EDK-II-Code-Formatting "wikilink") >=20 > - >=20 > - - The changes must pass local CI which includes a code formatting check >=20 > - in order to be merged into the code base. >=20 > - >=20 > - - It is strongly recommended that you format the code after each commit. >=20 > - The code can then be easily amended with the formatted output. > Some >=20 > - developers might also prefer to format frequently while writing = the >=20 > - code using the plugin instructions described in the code = formatting >=20 > - wiki page. >=20 > - >=20 > -10. Create patch (serial) to the [[edk2-devel]] mailing list >=20 > +9. Run the automated code formatting tool (Uncrustify) against your changes > + > + - [EDK-II-Code-Formatting](EDK-II-Code-Formatting "wikilink") > + > + - The changes must pass local CI which includes a code formatting check > + in order to be merged into the code base. > + > + - It is strongly recommended that you format the code after each > commit. > + The code can then be easily amended with the formatted output. > Some > + developers might also prefer to format frequently while writing = the > + code using the plugin instructions described in the code = formatting > + wiki page. > + > +10. (Optional) Push changes to the developer's fork of the EDK II = project > + repository. > + > + - How to create a [GitHub > fork](https://help.github.com/en/github/getting-started-with-github/fork-= a-r > epo) > + - **NOTE:** A GitHub fork can also be created using the command > line > + utility called = [`hub`](https://github.com/github/hub/releases). > The > + `hub` usage information can be found > [here](https://hub.github.com/hub.1.html). > + > + - Add remote to the developer's fork of the EDK II project > + > + `$ git remote add > https://github.com//edk2.git` > + > + - Push the integration branch. > + > + `$ git push ` > + > +11. (Optional) Create a GitHub pull request from the developer's > + to edk2/master to run CI check. > + > + - How to create a [GitHub pull > request](https://help.github.com/en/github/collaborating-with-issues-and-= pu > ll-requests/creating-a-pull-request) > + - **NOTE:** A GitHub pull request can also be created using the > command > + line utility called [`hub`](https://github.com/github/hub/releases). > + The `hub` usage information can be found > [here](https://hub.github.com/hub.1.html). > + > + - Declare that it is for CI check test in the pull request title = and > + description. > + > + - Resolve GitHub pull request issues if it fails. Please refrence step 8 > + in the below **The maintainer process for the EDK II project** > + > +12. Create patch (serial) to the [[edk2-devel]] mailing list >=20 > - Clean out any old patches: `$ rm *.patch` >=20 > @@ -86,7 +116,7 @@ The developer process for the EDK II project >=20 > - `$ git send-email *.patch` >=20 > -11. Modify local commits based on the review feedbacks and repeat = steps >=20 > +13. Modify local commits based on the review feedbacks and repeat = steps > 3 to 9 >=20 > - For the latest commit, you can use `$ git commit --amend` > -- > 2.32.0.windows.2 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#85435): = https://edk2.groups.io/g/devel/message/85435 > Mute This Topic: https://groups.io/mt/88316431/4905953 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [gaoliming@byosoft.com.cn] > -=3D-=3D-=3D-=3D-=3D-=3D >=20