From: "Michael Kubacki" <mikuback@linux.microsoft.com>
To: devel@edk2.groups.io, rebecca@os.amperecomputing.com,
marcin.juszkiewicz@linaro.org, Laszlo Ersek <lersek@redhat.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>,
Pedro Falcato <pedro.falcato@gmail.com>,
Andrew Fish <afish@apple.com>,
"Leif Lindholm (Quic)" <quic_llindhol@quicinc.com>
Subject: Re: [edk2-devel] edk2 uncrustify update (73.0.8)?
Date: Mon, 13 Nov 2023 15:37:29 -0500 [thread overview]
Message-ID: <01ca37e2-c55a-47fe-ae05-99ffaac5f3d5@linux.microsoft.com> (raw)
In-Reply-To: <fe3db67a-b033-4ccd-bb89-3216ae47212d@os.amperecomputing.com>
On 11/13/2023 2:14 PM, Rebecca Cran via groups.io wrote:
> On 11/13/2023 5:29 AM, Marcin Juszkiewicz via groups.io wrote:
>
>> Still a fan of adding edk2-uncrustify to BaseTools. If we are expected
>> to use it then let it get installed at same moment as "build" command is.
>
> The issue with doing this is there's a push to remove all C/C++ code
> from BaseTools (including porting existing code to Python), and adding
> edk2-uncrustify would work against that.
>
That was a reason I did not add the code to BaseTools. I personally
think it would bloat the edk2 repo and complicate its build process for
something that rarely changes. Given binary dependencies are already
used and managed for other incoming binaries such as iasl and nasm
(https://github.com/tianocore/edk2/tree/master/BaseTools/Bin) and the
effort to eliminate C/C++ code from BaseTools, I think it makes sense to
keep it in a dedicated repository.
If there is another reason for the move, such as a preference to move
the repo under the Tianocore organization (for whatever reason) or
something like that, please let me know.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111180): https://edk2.groups.io/g/devel/message/111180
Mute This Topic: https://groups.io/mt/102559740/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-11-13 20:37 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 11:58 [edk2-devel] edk2 uncrustify update (73.0.8)? Laszlo Ersek
2023-11-13 12:29 ` Marcin Juszkiewicz
2023-11-13 19:14 ` Rebecca Cran via groups.io
2023-11-13 20:37 ` Michael Kubacki [this message]
2023-11-13 19:07 ` Pedro Falcato
2023-11-13 20:21 ` Michael Kubacki
2023-11-13 21:05 ` Michael D Kinney
2023-11-14 14:51 ` Laszlo Ersek
2023-11-14 15:12 ` Rebecca Cran via groups.io
2023-11-15 8:52 ` Laszlo Ersek
[not found] ` <17974449E158DE38.1153@groups.io>
2023-11-13 19:10 ` Pedro Falcato
2023-11-13 20:08 ` Michael Kubacki
2023-11-13 20:37 ` Rebecca Cran
2023-11-13 21:33 ` Pedro Falcato
2023-11-14 15:01 ` Laszlo Ersek
2023-11-16 8:29 ` Pedro Falcato
2023-11-16 17:36 ` Michael Kubacki
2023-11-23 2:07 ` Pedro Falcato
2023-11-17 9:08 ` Laszlo Ersek
2023-11-23 1:44 ` Pedro Falcato
2023-11-14 1:46 ` Michael Kubacki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01ca37e2-c55a-47fe-ae05-99ffaac5f3d5@linux.microsoft.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox