From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id DD5D2740034 for ; Mon, 13 Nov 2023 20:37:33 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=CXDVe2jYEnGN/oe4k1lyfneW155/GnGxeqkTU3DHXm0=; c=relaxed/simple; d=groups.io; h=DKIM-Filter:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1699907852; v=1; b=mKjblFJnd/w69ItEgunwr07IropopX7iwePnxyr0e9UdURo4HXCRsCIXUX9RgOT8QKqnKzaw FlUjxT9PXhK8KOhdu2Nyd7VVhSElYiy13L12VqI93kKoM9nS+/1XAK8RrbQCZ2Zj3cZ+p6eLU/T DY5XV8LUnKb5jAfbvBPqRDSo= X-Received: by 127.0.0.2 with SMTP id EaXYYY7687511xHKYsAIeZyY; Mon, 13 Nov 2023 12:37:32 -0800 X-Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mx.groups.io with SMTP id smtpd.web11.2099.1699907851973592401 for ; Mon, 13 Nov 2023 12:37:32 -0800 X-Received: from [192.168.4.22] (unknown [47.201.241.95]) by linux.microsoft.com (Postfix) with ESMTPSA id 7B8B820B74C1; Mon, 13 Nov 2023 12:37:30 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 7B8B820B74C1 Message-ID: <01ca37e2-c55a-47fe-ae05-99ffaac5f3d5@linux.microsoft.com> Date: Mon, 13 Nov 2023 15:37:29 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] edk2 uncrustify update (73.0.8)? To: devel@edk2.groups.io, rebecca@os.amperecomputing.com, marcin.juszkiewicz@linaro.org, Laszlo Ersek Cc: Michael Kinney , Pedro Falcato , Andrew Fish , "Leif Lindholm (Quic)" References: <0107c96b-849a-db48-194b-1a4c1f3b0c78@redhat.com> From: "Michael Kubacki" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,mikuback@linux.microsoft.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: E9v4d7sVYYG4wXVV9DakHEBMx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=mKjblFJn; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=linux.microsoft.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On 11/13/2023 2:14 PM, Rebecca Cran via groups.io wrote: > On 11/13/2023 5:29 AM, Marcin Juszkiewicz via groups.io wrote: >=20 >> Still a fan of adding edk2-uncrustify to BaseTools. If we are expected= =20 >> to use it then let it get installed at same moment as "build" command is= . >=20 > The issue with doing this is there's a push to remove all C/C++ code=20 > from BaseTools (including porting existing code to Python), and adding=20 > edk2-uncrustify would work against that. >=20 That was a reason I did not add the code to BaseTools. I personally=20 think it would bloat the edk2 repo and complicate its build process for=20 something that rarely changes. Given binary dependencies are already=20 used and managed for other incoming binaries such as iasl and nasm=20 (https://github.com/tianocore/edk2/tree/master/BaseTools/Bin) and the=20 effort to eliminate C/C++ code from BaseTools, I think it makes sense to=20 keep it in a dedicated repository. If there is another reason for the move, such as a preference to move=20 the repo under the Tianocore organization (for whatever reason) or=20 something like that, please let me know. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111180): https://edk2.groups.io/g/devel/message/111180 Mute This Topic: https://groups.io/mt/102559740/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-