public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "gaoliming via groups.io" <gaoliming=byosoft.com.cn@groups.io>
To: <devel@edk2.groups.io>, <shenbagadevir@ami.com>
Cc: "'Sainadh Nagolu'" <sainadhn@ami.com>,
	"'Sundaresan S'" <sundaresans@ami.com>,
	"'Srinivasan Mani'" <srinivasanm@ami.com>,
	"'Ramesh R'" <rameshr@ami.com>,
	"'Karthika R'" <karthikar@ami.com>
Subject: 回复: [edk2-devel] [PATCH] Changes to print PMIC&RCD info in Shell Smbiosview
Date: Tue, 30 Apr 2024 14:26:11 +0800	[thread overview]
Message-ID: <01cb01da9ac7$4b9953c0$e2cbfb40$@byosoft.com.cn> (raw)
In-Reply-To: <20240423115910.646-1-shenbagadevir@ami.com>

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Shenbagadevi
> R via groups.io
> 发送时间: 2024年4月23日 20:00
> 收件人: devel@edk2.groups.io; Shenbagadevi R <shenbagadevir@ami.com>
> 抄送: gaoliming@byosoft.com.cn; Sainadh Nagolu <sainadhn@ami.com>;
> Sundaresan S <sundaresans@ami.com>; Srinivasan Mani
> <srinivasanm@ami.com>; Ramesh R <rameshr@ami.com>; Karthika R
> <karthikar@ami.com>
> 主题: [edk2-devel] [PATCH] Changes to print PMIC&RCD info in Shell
> Smbiosview
> 
> Add changes to print PMIC and RCD details of Smbios Type17 in Shell
> smbiosview command
> 
> Signed-off-by: Shenbagadevi R <shenbagadevir@ami.com>
> ---
>  .../UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c      | 7
> +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git
> a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> index 35369f0183..0fbaeb88ae 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> +++
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c
> @@ -902,6 +902,13 @@ SmbiosPrintStructure (
>          ShellPrintEx (-1, -1, L"Extended Speed: 0x%x\n",
> Struct->Type17->ExtendedSpeed);
> 
>          ShellPrintEx (-1, -1, L"Extended Configured Memory Speed:
> 0x%x\n", Struct->Type17->ExtendedConfiguredMemorySpeed);
> 
>        }
> 
> +
> 
> +      if (AE_SMBIOS_VERSION (0x3, 0x7) && (Struct->Hdr->Length > 0x5C))
> {
> 
> +        ShellPrintEx (-1, -1, L"PMIC0 Manufacturer ID: 0x%x\n",
> Struct->Type17->Pmic0ManufacturerID);
> 
> +        ShellPrintEx (-1, -1, L"PMIC0 Revision Number: 0x%x\n",
> Struct->Type17->Pmic0RevisionNumber);
> 
> +        ShellPrintEx (-1, -1, L"RCD Manufacturer ID: 0x%x\n",
> Struct->Type17->RcdManufacturerID);
> 
> +        ShellPrintEx (-1, -1, L"RCD Revision Number: 0x%x\n",
> Struct->Type17->RcdRevisionNumber);
> 
> +      }
> 
> 
> 
>        break;
> 
> 
> 
> --
> 2.38.0.windows.1
> -The information contained in this message may be confidential and
> proprietary to American Megatrends (AMI). This communication is intended
to
> be read only by the individual or entity to whom it is addressed or by
their
> designee. If the reader of this message is not the intended recipient, you
are
> on notice that any distribution of this message, in any form, is strictly
> prohibited. Please promptly notify the sender by reply e-mail or by
telephone
> at 770-246-8600, and then delete or destroy all copies of the
transmission.
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118417): https://edk2.groups.io/g/devel/message/118417
Mute This Topic: https://groups.io/mt/105816495/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



      parent reply	other threads:[~2024-04-30  6:26 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-23 11:59 [edk2-devel] [PATCH] Changes to print PMIC&RCD info in Shell Smbiosview Shenbagadevi R via groups.io
2024-04-23 15:59 ` Giri Mudusuru via groups.io
2024-04-30  5:58   ` Sainadh Nagolu via groups.io
2024-04-30  6:26 ` gaoliming via groups.io [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='01cb01da9ac7$4b9953c0$e2cbfb40$@byosoft.com.cn' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox