From: "gaoliming via groups.io" <gaoliming=byosoft.com.cn@groups.io>
To: <devel@edk2.groups.io>, <gaoliming@byosoft.com.cn>,
<shenbagadevir@ami.com>
Cc: "'Sainadh Nagolu'" <sainadhn@ami.com>,
"'Sundaresan S'" <sundaresans@ami.com>,
"'Srinivasan Mani'" <srinivasanm@ami.com>,
"'Ramesh R'" <rameshr@ami.com>
Subject: 回复: [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0 Spec
Date: Tue, 30 Apr 2024 14:27:06 +0800 [thread overview]
Message-ID: <01cc01da9ac7$6c8759b0$45960d10$@byosoft.com.cn> (raw)
In-Reply-To: <17C66074E9D52EF0.8775@groups.io>
I see your patch in ShellPkg. For this change in MdePkg, Reviewed-by: Liming
Gao <gaoliming@byosoft.com.cn>
Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 gaoliming via
> groups.io
> 发送时间: 2024年4月15日 14:33
> 收件人: devel@edk2.groups.io; shenbagadevir@ami.com
> 抄送: 'Sainadh Nagolu' <sainadhn@ami.com>; 'Sundaresan S'
> <sundaresans@ami.com>; 'Srinivasan Mani' <srinivasanm@ami.com>;
> 'Ramesh R' <rameshr@ami.com>
> 主题: 回复: [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0
> Spec
>
> Shenbagadevi:
> I think you still need to update ShellPkg SmbiosView to support the
> updated TYPE17.
>
> Thanks
> Liming
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表
> Shenbagadevi
> > R via groups.io
> > 发送时间: 2023年11月17日 18:05
> > 收件人: devel@edk2.groups.io; Shenbagadevi R
> <shenbagadevir@ami.com>
> > 抄送: gaoliming@byosoft.com.cn; Sainadh Nagolu <sainadhn@ami.com>;
> > Sundaresan S <sundaresans@ami.com>; Srinivasan Mani
> > <srinivasanm@ami.com>; Ramesh R <rameshr@ami.com>
> > 主题: [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0 Spec
> >
> > As per Smbios 3.7.0 spec, added CXL 3.0 support in Type 9, also added
> > PMIC & RCD manufacturer ID and Revision information in Type17.
> >
> > Signed-off-by: Shenbagadevi R <shenbagadevir@ami.com>
> >
> > CC: Gaoliming <gaoliming@byosoft.com.cn>
> > CC: Sainadh N <sainadhn@ami.com>
> > CC: Sundaresan S <sundaresans@ami.com>
> > CC: Srinivasan M <srinivasanm@ami.com>
> > CC: Ramesh R <rameshr@ami.com>
> >
> > ---
> > MdePkg/Include/IndustryStandard/SmBios.h | 11 +++++++++--
> > 1 file changed, 9 insertions(+), 2 deletions(-)
> >
> > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h
> > b/MdePkg/Include/IndustryStandard/SmBios.h
> > index 56cec615a0..cfefc2fa52 100644
> > --- a/MdePkg/Include/IndustryStandard/SmBios.h
> > +++ b/MdePkg/Include/IndustryStandard/SmBios.h
> > @@ -5,7 +5,7 @@ Copyright (c) 2006 - 2023, Intel Corporation. All rights
> > reserved.<BR>
> > (C) Copyright 2015-2017 Hewlett Packard Enterprise Development
> LP<BR>
> >
> > (C) Copyright 2015 - 2019 Hewlett Packard Enterprise Development
> LP<BR>
> >
> > Copyright (c) 2022, AMD Incorporated. All rights reserved.<BR>
> >
> > -Copyright (c) 1985 - 2022, American Megatrends International LLC.<BR>
> >
> > +Copyright (c) 1985 - 2023, American Megatrends International LLC.<BR>
> >
> > SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> >
> >
> > **/
> >
> > @@ -1509,7 +1509,7 @@ typedef struct {
> > UINT8 AsyncSurpriseRemoval : 1;
> >
> > UINT8 FlexbusSlotCxl10Capable : 1;
> >
> > UINT8 FlexbusSlotCxl20Capable : 1;
> >
> > - UINT8 Reserved : 1; ///< Set to 0.
> >
> > + UINT8 FlexbusSlotCxl30Capable : 1; ///SMBIOS spec 3.7.0 updated
> > CXL 3.0 support
> >
> > } MISC_SLOT_CHARACTERISTICS2;
> >
> >
> >
> > ///
> >
> > @@ -2012,6 +2012,13 @@ typedef struct {
> > //
> >
> > UINT32 ExtendedSpeed;
> >
> > UINT32
> > ExtendedConfiguredMemorySpeed;
> >
> > + //
> >
> > + // Add for smbios 3.7.0
> >
> > + //
> >
> > + UINT16
> > Pmic0ManufacturerID;
> >
> > + UINT16
> > Pmic0RevisionNumber;
> >
> > + UINT16
> > RcdManufacturerID;
> >
> > + UINT16
> > RcdRevisionNumber;
> >
> > } SMBIOS_TABLE_TYPE17;
> >
> >
> >
> > ///
> >
> > --
> > 2.38.0.windows.1
> > -The information contained in this message may be confidential and
> > proprietary to American Megatrends (AMI). This communication is intended
> to
> > be read only by the individual or entity to whom it is addressed or by
> their
> > designee. If the reader of this message is not the intended recipient,
you
> are
> > on notice that any distribution of this message, in any form, is
strictly
> > prohibited. Please promptly notify the sender by reply e-mail or by
> telephone
> > at 770-246-8600, and then delete or destroy all copies of the
> transmission.
> >
> >
> >
> >
>
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#118418): https://edk2.groups.io/g/devel/message/118418
Mute This Topic: https://groups.io/mt/105816498/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
prev parent reply other threads:[~2024-04-30 6:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 10:05 [edk2-devel] [PATCH] MdePkg:Added support for Smbios 3.7.0 Spec Shenbagadevi R via groups.io
2024-04-15 5:33 ` Sainadh Nagolu via groups.io
2024-04-15 6:32 ` 回复: " gaoliming via groups.io
[not found] ` <17C66074E9D52EF0.8775@groups.io>
2024-04-30 6:27 ` gaoliming via groups.io [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01cc01da9ac7$6c8759b0$45960d10$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox