From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Chris Jones'" <christopher.jones@arm.com>, <devel@edk2.groups.io>
Cc: <Sami.Mujawar@arm.com>, <Akanksha.Jain2@arm.com>,
<Ben.Adderson@arm.com>, <michael.d.kinney@intel.com>,
<zhiguang.liu@intel.com>, <Matteo.Carlini@arm.com>, <nd@arm.com>
Subject: 回复: [PATCH RESEND v1 00/13] Add ACPI 6.4 header file
Date: Wed, 4 Aug 2021 11:27:59 +0800 [thread overview]
Message-ID: <01d001d788e0$b969f5e0$2c3de1a0$@byosoft.com.cn> (raw)
In-Reply-To: <20210730102241.508-1-christopher.jones@arm.com>
Chris:
This patch set is good. I have only one minor comments for struct
EFI_ACPI_6_4_GIC_STRUCTURE.
I suggest to keep the same field name to EFI_ACPI_6_3_GIC_STRUCTURE. We
can ignore ECC issue in MdePkg.ci.yaml IgnoreFiles list.
Thanks
Liming
> -----邮件原件-----
> 发件人: Chris Jones <christopher.jones@arm.com>
> 发送时间: 2021年7月30日 18:22
> 收件人: devel@edk2.groups.io
> 抄送: Sami.Mujawar@arm.com; Akanksha.Jain2@arm.com;
> Ben.Adderson@arm.com; michael.d.kinney@intel.com;
> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com;
> Matteo.Carlini@arm.com; nd@arm.com
> 主题: [PATCH RESEND v1 00/13] Add ACPI 6.4 header file
>
> Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3516)
>
> This patch series introduces a header file for the latest version of the
> ACPI 6.4 specification, January 2021. This header contains all updates
> to the ACPI specification in addition to addressing a few small errors
> from the previous ACPI header files.
>
> The patches have been resent to include the bugzilla id, no code has
> been changed.
>
> The changes can be seen at:
> https://github.com/chris-jones-arm/edk2/tree/1661_add_acpi_64_header_v
> 1
>
> Chris Jones (13):
> MdePkg: Add ACPI 6.4 header file
> MdePkg: Increment FADT version
> MdePkg: Rename SBSA Generic Watchdog to Arm Generic Watchdog
> MdePkg: Update PMTT to ACPI 6.4
> MdePkg: Add SPA Location Cookie field to SPA Range structure
> MdePkg: Remove DPPT table
> MdePkg: Add flags and MinTransferSize to Generic Initiator
> MdePkg: Add 'Type 5' PCC structure
> MdePkg: Add Multiprocessor Wakeup structure
> MdePkg: Add the Platform Health Assessment Table (PHAT)
> MdePkg: Add Secure Access Components in the SDEV table
> MdePkg: Add Cache ID to PPTT
> MdePkg: Fix broken coding style in Acpi64.h
>
> MdePkg/Include/IndustryStandard/Acpi.h | 4 +-
> MdePkg/Include/IndustryStandard/Acpi64.h | 3148
> ++++++++++++++++++++
> 2 files changed, 3150 insertions(+), 2 deletions(-)
> create mode 100644 MdePkg/Include/IndustryStandard/Acpi64.h
>
> --
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
prev parent reply other threads:[~2021-08-04 3:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-30 10:22 [PATCH RESEND v1 00/13] Add ACPI 6.4 header file Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 01/13] MdePkg: " Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 02/13] MdePkg: Increment FADT version Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 03/13] MdePkg: Rename SBSA Generic Watchdog to Arm Generic Watchdog Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 04/13] MdePkg: Update PMTT to ACPI 6.4 Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 05/13] MdePkg: Add SPA Location Cookie field to SPA Range structure Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 06/13] MdePkg: Remove DPPT table Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 07/13] MdePkg: Add flags and MinTransferSize to Generic Initiator Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 08/13] MdePkg: Add 'Type 5' PCC structure Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 09/13] MdePkg: Add Multiprocessor Wakeup structure Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 10/13] MdePkg: Add the Platform Health Assessment Table (PHAT) Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 11/13] MdePkg: Add Secure Access Components in the SDEV table Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 12/13] MdePkg: Add Cache ID to PPTT Chris Jones
2021-07-30 10:22 ` [PATCH RESEND v1 13/13] MdePkg: Fix broken coding style in Acpi64.h Chris Jones
2021-08-04 3:27 ` gaoliming [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01d001d788e0$b969f5e0$2c3de1a0$@byosoft.com.cn' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox