From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242])
 by mx.groups.io with SMTP id smtpd.web11.4388.1628047687146734736
 for <devel@edk2.groups.io>;
 Tue, 03 Aug 2021 20:28:08 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn)
Received: from DESKTOPS6D0PVI ([58.246.60.130])
	(envelope-sender <gaoliming@byosoft.com.cn>)
	by 192.168.6.13 with ESMTP
	for <akanksha.jain2@arm.com>; Wed, 04 Aug 2021 11:27:58 +0800
X-WM-Sender: gaoliming@byosoft.com.cn
X-Originating-IP: 58.246.60.130
X-WM-AuthFlag: YES
X-WM-AuthUser: gaoliming@byosoft.com.cn
From: "gaoliming" <gaoliming@byosoft.com.cn>
To: "'Chris Jones'" <christopher.jones@arm.com>,
	<devel@edk2.groups.io>
Cc: <Sami.Mujawar@arm.com>,
	<Akanksha.Jain2@arm.com>,
	<Ben.Adderson@arm.com>,
	<michael.d.kinney@intel.com>,
	<zhiguang.liu@intel.com>,
	<Matteo.Carlini@arm.com>,
	<nd@arm.com>
References: <20210730102241.508-1-christopher.jones@arm.com>
In-Reply-To: <20210730102241.508-1-christopher.jones@arm.com>
Subject: =?UTF-8?B?5Zue5aSNOiBbUEFUQ0ggUkVTRU5EIHYxIDAwLzEzXSBBZGQgQUNQSSA2LjQgaGVhZGVyIGZpbGU=?=
Date: Wed, 4 Aug 2021 11:27:59 +0800
Message-ID: <01d001d788e0$b969f5e0$2c3de1a0$@byosoft.com.cn>
MIME-Version: 1.0
X-Mailer: Microsoft Outlook 16.0
Thread-Index: AQGfVmPgUDIMTMc8jaOhdNChtxuwH6vTEIRg
Content-Type: text/plain;
	charset="gb2312"
Content-Transfer-Encoding: quoted-printable
Content-Language: zh-cn

Chris:
  This patch set is good. I have only one minor comments for struct
EFI_ACPI_6_4_GIC_STRUCTURE.
  I suggest to keep the same field name to EFI_ACPI_6_3_GIC_STRUCTURE. =
We
can ignore ECC issue in MdePkg.ci.yaml IgnoreFiles list.=20

Thanks
Liming
> -----=D3=CA=BC=FE=D4=AD=BC=FE-----
> =B7=A2=BC=FE=C8=CB: Chris Jones <christopher.jones@arm.com>
> =B7=A2=CB=CD=CA=B1=BC=E4: 2021=C4=EA7=D4=C230=C8=D5 18:22
> =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io
> =B3=AD=CB=CD: Sami.Mujawar@arm.com; Akanksha.Jain2@arm.com;
> Ben.Adderson@arm.com; michael.d.kinney@intel.com;
> gaoliming@byosoft.com.cn; zhiguang.liu@intel.com;
> Matteo.Carlini@arm.com; nd@arm.com
> =D6=F7=CC=E2: [PATCH RESEND v1 00/13] Add ACPI 6.4 header file
>=20
> Bugzilla: 3516 (https://bugzilla.tianocore.org/show_bug.cgi?id=3D3516)
>=20
> This patch series introduces a header file for the latest version of =
the
> ACPI 6.4 specification, January 2021. This header contains all updates
> to the ACPI specification in addition to addressing a few small errors
> from the previous ACPI header files.
>=20
> The patches have been resent to include the bugzilla id, no code has
> been changed.
>=20
> The changes can be seen at:
> https://github.com/chris-jones-arm/edk2/tree/1661_add_acpi_64_header_v
> 1
>=20
> Chris Jones (13):
>   MdePkg: Add ACPI 6.4 header file
>   MdePkg: Increment FADT version
>   MdePkg: Rename SBSA Generic Watchdog to Arm Generic Watchdog
>   MdePkg: Update PMTT to ACPI 6.4
>   MdePkg: Add SPA Location Cookie field to SPA Range structure
>   MdePkg: Remove DPPT table
>   MdePkg: Add flags and MinTransferSize to Generic Initiator
>   MdePkg: Add 'Type 5' PCC structure
>   MdePkg: Add Multiprocessor Wakeup structure
>   MdePkg: Add the Platform Health Assessment Table (PHAT)
>   MdePkg: Add Secure Access Components in the SDEV table
>   MdePkg: Add Cache ID to PPTT
>   MdePkg: Fix broken coding style in Acpi64.h
>=20
>  MdePkg/Include/IndustryStandard/Acpi.h   |    4 +-
>  MdePkg/Include/IndustryStandard/Acpi64.h | 3148
> ++++++++++++++++++++
>  2 files changed, 3150 insertions(+), 2 deletions(-)
>  create mode 100644 MdePkg/Include/IndustryStandard/Acpi64.h
>=20
> --
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")