From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by mx.groups.io with SMTP id smtpd.web10.7455.1644479898759651931 for ; Wed, 09 Feb 2022 23:58:20 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=none, err=permanent DNS error (domain: byosoft.com.cn, ip: 58.240.74.242, mailfrom: gaoliming@byosoft.com.cn) Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP for ; Thu, 10 Feb 2022 15:58:12 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming" To: , Cc: "'Chen, Christine'" , "'Pedro Falcato'" References: <20220126083014.480-1-bob.c.feng@intel.com> <000a01d8131a$f2b62390$d8226ab0$@byosoft.com.cn> <16CDFF5EEB5C1060.24088@groups.io> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0g5Zue5aSNOiBbUGF0Y2ggMS8yXSBCYXNlVG9vbHM6IFVwZGF0ZSBicm90bGkgc3VibW9kdWxl?= Date: Thu, 10 Feb 2022 15:58:14 +0800 Message-ID: <01d101d81e53$f512abb0$df380310$@byosoft.com.cn> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGhZuLKxOoc1PY8FttdINqrXa/GGQJTAR95AR2qZY4BXy1/S6zTV8LA Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn Bob: I have no comments for this patch set. Reviewed-by: Liming Gao =20 Now, we are in soft feature freeze phase. Does this patch set plan to cat= ch this stable tag? If yes, please reply the mail and cc to Stewards.=20 Thanks Liming > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > =E5=8F=91=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io = =E4=BB=A3=E8=A1=A8 Bob Feng > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B42=E6=9C=8810=E6=97=A5 = 14:45 > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io; Feng, Bob C ; Gao, > Liming > =E6=8A=84=E9=80=81: Chen, Christine ; 'Pedro Falcat= o' > > =E4=B8=BB=E9=A2=98: Re: [edk2-devel] =E5=9B=9E=E5=A4=8D: [Patch 1/2] Base= Tools: Update brotli submodule >=20 > Liming, >=20 > Do you have any more comments on this patch? >=20 > Thanks, > Bob >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Bob Feng > Sent: Thursday, January 27, 2022 10:24 AM > To: devel@edk2.groups.io; Gao, Liming > Cc: Chen, Christine ; 'Pedro Falcato' > > Subject: Re: [edk2-devel] =E5=9B=9E=E5=A4=8D: [Patch 1/2] BaseTools: Upda= te brotli > submodule >=20 > Yes. it passed the edk2 CI https://github.com/tianocore/edk2/pull/2442 >=20 >=20 > Thanks, > Bob >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of gaoliming > Sent: Thursday, January 27, 2022 9:12 AM > To: Feng, Bob C ; devel@edk2.groups.io > Cc: Chen, Christine ; 'Pedro Falcato' > > Subject: [edk2-devel] =E5=9B=9E=E5=A4=8D: [Patch 1/2] BaseTools: Update b= rotli submodule >=20 > Does this updated patch pass CI? >=20 > Thanks > Liming > > -----=E9=82=AE=E4=BB=B6=E5=8E=9F=E4=BB=B6----- > > =E5=8F=91=E4=BB=B6=E4=BA=BA: Bob Feng > > =E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: 2022=E5=B9=B41=E6=9C=8826=E6=97= =A5 16:30 > > =E6=94=B6=E4=BB=B6=E4=BA=BA: devel@edk2.groups.io > > =E6=8A=84=E9=80=81: Liming Gao ; Yuwei Chen > > ; Pedro Falcato > > =E4=B8=BB=E9=A2=98: [Patch 1/2] BaseTools: Update brotli submodule > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3D3417 > > Update the brotli submodule to the latest commit (f4153a0) so that the > > build isn't broken in GCC 11 compilers. > > > > Signed-off-by: Bob Feng > > Cc: Liming Gao > > Cc: Yuwei Chen > > Cc: Pedro Falcato > > --- > > BaseTools/Source/C/BrotliCompress/GNUmakefile | 7 +++++++ > > BaseTools/Source/C/BrotliCompress/Makefile | 11 ++++++++++- > > BaseTools/Source/C/BrotliCompress/brotli | 2 +- > > 3 files changed, 18 insertions(+), 2 deletions(-) > > > > diff --git a/BaseTools/Source/C/BrotliCompress/GNUmakefile > > b/BaseTools/Source/C/BrotliCompress/GNUmakefile > > index b150e5dd2b..fd8e05c0e6 100644 > > --- a/BaseTools/Source/C/BrotliCompress/GNUmakefile > > +++ b/BaseTools/Source/C/BrotliCompress/GNUmakefile > > @@ -8,10 +8,17 @@ MAKEROOT ?=3D .. > > > > > > APPNAME =3D BrotliCompress > > > > > > > > OBJECTS =3D \ > > > > BrotliCompress.o \ > > > > + brotli/c/common/platform.o \ > > > > + brotli/c/common/shared_dictionary.o \ > > > > + brotli/c/common/constants.o \ > > > > + brotli/c/common/context.o \ > > > > + brotli/c/enc/command.o \ > > > > + brotli/c/enc/compound_dictionary.o \ > > > > + brotli/c/enc/fast_log.o \ > > > > brotli/c/common/dictionary.o \ > > > > brotli/c/common/transform.o \ > > > > brotli/c/dec/bit_reader.o \ > > > > brotli/c/dec/decode.o \ > > > > brotli/c/dec/huffman.o \ > > > > diff --git a/BaseTools/Source/C/BrotliCompress/Makefile > > b/BaseTools/Source/C/BrotliCompress/Makefile > > index 038d1ec242..36e69aa656 100644 > > --- a/BaseTools/Source/C/BrotliCompress/Makefile > > +++ b/BaseTools/Source/C/BrotliCompress/Makefile > > @@ -11,18 +11,27 @@ CFLAGS =3D $(CFLAGS) /W2 > > > > > > APPNAME =3D BrotliCompress > > > > > > > > #LIBS =3D $(LIB_PATH)\Common.lib > > > > > > > > -COMMON_OBJ =3D brotli\c\common\dictionary.obj > > brotli\c\common\transform.obj > > > > +COMMON_OBJ =3D \ > > > > + brotli\c\common\constants.obj \ > > > > + brotli\c\common\context.obj \ > > > > + brotli\c\common\dictionary.obj \ > > > > + brotli\c\common\platform.obj \ > > > > + brotli\c\common\shared_dictionary.obj \ > > > > + brotli\c\common\transform.obj > > > > DEC_OBJ =3D \ > > > > brotli\c\dec\bit_reader.obj \ > > > > brotli\c\dec\decode.obj \ > > > > brotli\c\dec\huffman.obj \ > > > > brotli\c\dec\state.obj > > > > ENC_OBJ =3D \ > > > > + brotli\c\enc\command.obj \ > > > > + brotli\c\enc\compound_dictionary.obj \ > > > > brotli\c\enc\backward_references.obj \ > > > > + brotli\c\enc\fast_log.obj \ > > > > brotli\c\enc\backward_references_hq.obj \ > > > > brotli\c\enc\bit_cost.obj \ > > > > brotli\c\enc\block_splitter.obj \ > > > > brotli\c\enc\brotli_bit_stream.obj \ > > > > brotli\c\enc\cluster.obj \ > > > > diff --git a/BaseTools/Source/C/BrotliCompress/brotli > > b/BaseTools/Source/C/BrotliCompress/brotli > > index 666c3280cc..f4153a09f8 160000 > > --- a/BaseTools/Source/C/BrotliCompress/brotli > > +++ b/BaseTools/Source/C/BrotliCompress/brotli > > @@ -1 +1 @@ > > -Subproject commit 666c3280cc11dc433c303d79a83d4ffbdd12cc8d > > +Subproject commit f4153a09f87cbb9c826d8fc12c74642bb2d879ea > > -- > > 2.29.1.windows.1 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20 >=20