From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 97E7E9418C1 for ; Wed, 24 Jan 2024 14:49:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=S+vjkWTWQez/BycjQB2oVoMVAYQklcQr40ODIC4gmsg=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20140610; t=1706107784; v=1; b=wuipVLkTwwFqKPKWlg7I4J/hev+LRnJFDmE6LaGDxjNNtAjM2b8nAnPtODwT8wwzR6xygBzz PFrI+38LO2tHET4NeHcDWjQrxxj3PV7jjg/QGqJIaqLPdwvDhuWiEGsIWPQDaUvl/oPnbaV4MVy 3OuUaiMBdd2kBlnQZ4QITI5s= X-Received: by 127.0.0.2 with SMTP id bbkyYY7687511x7Bd7T3n4zY; Wed, 24 Jan 2024 06:49:44 -0800 X-Received: from zrleap.intel-email.com (zrleap.intel-email.com [114.80.218.36]) by mx.groups.io with SMTP id smtpd.web11.24409.1706107774415302311 for ; Wed, 24 Jan 2024 06:49:43 -0800 X-Received: from zrleap.intel-email.com (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 23DF0A32DFEA for ; Wed, 24 Jan 2024 22:49:25 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by zrleap.intel-email.com (Postfix) with ESMTP id 119A5A32DFC7 for ; Wed, 24 Jan 2024 22:49:25 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by zrleap.intel-email.com (Postfix) with SMTP id 3CA89A32DFC4 for ; Wed, 24 Jan 2024 22:49:21 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([114.93.194.54]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Wed, 24 Jan 2024 22:49:19 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 114.93.194.54 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , , Cc: "'Liu, Zhiguang'" , "'Bi, Dandan'" , "'Pedro Falcato'" , "'Chiu, Chasel'" References: <20240108145938.16154-1-dhaval@rivosinc.com> <20240108145938.16154-2-dhaval@rivosinc.com> In-Reply-To: Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIIHY0IDEvMV0gTWRlTW9kdWxlUGtnL0FjcGlUYWJsZUR4ZTogUHJlZmVyIHhEU0RUIG92ZXIgRFNEVCB3aGVuIGluc3RhbGxpbmcgdGFibGVz?= Date: Wed, 24 Jan 2024 22:49:21 +0800 Message-ID: <01d201da4ed4$8472cbc0$8d586340$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQIJFvJ8PJTp/NP5HoZQa3a5N8mE9AH4oix0A1bCoWWwYP7ywA== Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: PccZDFJYAeGroWZ87ejl7Q3kx7686176AA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=wuipVLkT; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Mike: Seemly, I miss this patch.=20 Dhaval: I add one comment below.=20 > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED Michael D > Kinney > =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA1=D4=C224=C8=D5 10:24 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io; dhaval@rivosinc.com > =B3=AD=CB=CD: Gao, Liming ; Liu, Zhiguang > ; Bi, Dandan ; Pedro Falcato > ; Chiu, Chasel ; Kinney, > Michael D > =D6=F7=CC=E2: Re: [edk2-devel] [PATCH v4 1/1] MdeModulePkg/AcpiTableDxe: = Prefer > xDSDT over DSDT when installing tables >=20 > Hi Liming, >=20 > I do not see any reviews of this patch. >=20 > What is the status? >=20 > Mike >=20 > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Dhaval > > Sharma > > Sent: Monday, January 8, 2024 7:00 AM > > To: devel@edk2.groups.io > > Cc: Gao, Liming ; Liu, Zhiguang > > ; Bi, Dandan ; Pedro > > Falcato ; Chiu, Chasel > > Subject: [edk2-devel] [PATCH v4 1/1] MdeModulePkg/AcpiTableDxe: Prefer > > xDSDT over DSDT when installing tables > > > > As per ACPI Spec 6.5+ Table 5-9 if xDSDT is available, > > it should be used first. Handle required flow when xDSDT > > is absent or present. > > > > Test: Tested on RISCV64 Qemu platform with xDSDT and booted to > > linux kernel. > > > > Cc: Liming Gao > > Cc: Zhiguang Liu > > Cc: Dandan Bi > > Cc: Pedro Falcato > > Cc: devel@edk2.groups.io > > Signed-off-by: Dhaval Sharma > > Acked-by: Chasel Chiu > > --- > > > > Notes: > > v4: > > - Fix typos and commit message adding more clarity to patch subject > > v3: > > - Added description of ACPI spec clarification based on which this > > patch is created > > - Optimizing if-else flow > > v2: > > - Added proper indentation for else if > > > > MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c | 23 > > ++++++++++++++------ > > 1 file changed, 16 insertions(+), 7 deletions(-) > > > > diff --git > > a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > > b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > > index e09bc9b704f5..61af6047a2a7 100644 > > --- a/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > > +++ b/MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableProtocol.c > > @@ -1892,14 +1892,23 @@ InstallAcpiTableFromHob ( > > } > > > > } > > > > > > > > - if (((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE > *)ChildTable)- > > >Dsdt !=3D 0) { > > > > + // > > > > + // First check if xDSDT is available, as that is preferred as > > per > > > > + // ACPI Spec 6.5+ Table 5-9 X_DSDT definition > > > > + // > > > > + if (((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE > *)ChildTable)- > > >XDsdt !=3D 0) { > > > > + TableToInstall =3D (VOID > > *)(UINTN)((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE *)ChildTable)- > > >XDsdt; > > > > + } else if (((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE > > *)ChildTable)->Dsdt !=3D 0) { > > > > TableToInstall =3D (VOID > > *)(UINTN)((EFI_ACPI_3_0_FIXED_ACPI_DESCRIPTION_TABLE *)ChildTable)- > > >Dsdt; > > > > - Status =3D AddTableToList (AcpiTableInstance, > > TableToInstall, TRUE, Version, TRUE, &TableKey); > > > > - if (EFI_ERROR (Status)) { > > > > - DEBUG ((DEBUG_ERROR, "InstallAcpiTableFromHob: Fail to > add > > ACPI table DSDT\n")); > > > > - ASSERT_EFI_ERROR (Status); > > > > - break; > > > > - } > > > > + } else { > > > > + break; [Liming] If XDsdt and Dsdt are both zero, here is break. The previous logic will continue to look when Dsdt is zero.=20 Please check whether this change is by purpose. If this change is by design= , I still think the return Status should be set to EFI_NOT_FOUND. Thanks Liming > > > > + } > > > > + > > > > + Status =3D AddTableToList (AcpiTableInstance, TableToInstall, > > TRUE, Version, TRUE, &TableKey); > > > > + if (EFI_ERROR (Status)) { > > > > + DEBUG ((DEBUG_ERROR, "InstallAcpiTableFromHob: Fail to > add > > ACPI table DSDT\n")); > > > > + ASSERT_EFI_ERROR (Status); > > > > + break; > > > > } > > > > } > > > > } > > > > -- > > 2.39.2 > > > > > > > > -=3D-=3D-=3D-=3D-=3D-=3D > > Groups.io Links: You receive all messages sent to this group. > > View/Reply Online (#113401): > > https://edk2.groups.io/g/devel/message/113401 > > Mute This Topic: https://groups.io/mt/103598583/1643496 > > Group Owner: devel+owner@edk2.groups.io > > Unsubscribe: https://edk2.groups.io/g/devel/unsub > > [michael.d.kinney@intel.com] > > -=3D-=3D-=3D-=3D-=3D-=3D > > >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#114306): https://edk2.groups.io/g/devel/message/114306 Mute This Topic: https://groups.io/mt/103932913/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-