From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=210.71.195.41; helo=out02.hibox.biz; envelope-from=tim.lewis@insyde.com; receiver=edk2-devel@lists.01.org Received: from out02.hibox.biz (out01.hibox.biz [210.71.195.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8EBFC20945DBF for ; Wed, 9 May 2018 07:12:11 -0700 (PDT) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2D9AAC6APNa/ws0GKxCGhoBAQEBAQIBA?= =?us-ascii?q?QEBCAEBAQGDQ2EXYyiDKIhJHY5MgQ+TKhSBZAsYCwgBhEACgmchNBgBAgEBAQE?= =?us-ascii?q?BAQJsHAyFKAEBAQEDAQEGAlQQCwwBAwIGAw0EAQMBASgHGQ4BHgMBBQgCBAESC?= =?us-ascii?q?wWDDgQDgWcDFQ8wqgcaAogmgkiCK4R9glE/gQ+DC4J6FwEBAQKBIoYPAowfKi6?= =?us-ascii?q?LNQgCgWeDfoUMg1yBNTyFdIR+h0KBUDeEQIJGgSUcOA2BRXBQgkMJNoFhF4NFh?= =?us-ascii?q?RSFXh8wAYEMCAwBjT4rghkBAQ?= X-IronPort-AV: E=Sophos;i="5.49,381,1520870400"; d="scan'208";a="4626154" Received: from unknown (HELO hb3-BKT201.hibox.biz) ([172.24.52.11]) by out02.hibox.biz with ESMTP; 09 May 2018 22:12:04 +0800 Received: from unknown (HELO hb3-BKT101.hibox.biz) ([172.24.51.11]) by hb3-BKT201.hibox.biz with ESMTP; 09 May 2018 22:12:04 +0800 Received: from unknown (HELO hb3-IN01.hibox.biz) ([172.24.12.11]) by hb3-BKT101.hibox.biz with ESMTP; 09 May 2018 22:12:04 +0800 X-Remote-IP: 70.42.240.150 X-Remote-Host: No hostname X-SBRS: None X-MID: 11342101 X-Auth-ID: tim.lewis@insyde.com X-EnvelopeFrom: tim.lewis@insyde.com hiBox-Sender: 1 Received: from unknown (HELO DESKTOPAVHFBJF) ([70.42.240.150]) by hb3-IN01.hibox.biz with ESMTP/TLS/AES256-SHA; 09 May 2018 22:11:54 +0800 From: "Tim Lewis" To: =?iso-8859-1?Q?'Marvin_H=E4user'?= , Cc: "'Yao, Jiewen'" References: <74D8A39837DF1E4DA445A8C0B3885C503AB98291@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AB98303@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AB983CA@shsmsx102.ccr.corp.intel.com> <003701d3e734$f31a7770$d94f6650$@insyde.com> In-Reply-To: Date: Wed, 9 May 2018 07:11:47 -0700 Message-ID: <01eb01d3e79f$ad4e1bf0$07ea53d0$@insyde.com> MIME-Version: 1.0 X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQH+/tuOV9z+ScBXPyNfb+V7j60Y7AHO5MhdAghrJxgCPMX98AH2v1pvAUVkrF0BtBig/QIJvHuEo2jQ/9A= Subject: Re: [PATCH] MdePkg/BaseLib: Globally include ChkStk.c X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 May 2018 14:12:14 -0000 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Language: en-us Marvin - My suggestion would be the same as yours: to generate a runtime error. Tim -----Original Message----- From: edk2-devel On Behalf Of Marvin H=E4user Sent: Wednesday, May 9, 2018 1:45 AM To: edk2-devel@lists.01.org Cc: Yao, Jiewen ; Tim Lewis Subject: Re: [edk2] [PATCH] MdePkg/BaseLib: Globally include ChkStk.c Hey Tim, The compiler has no information regarding the size of the stack and = hence cannot determine an overflow. This is basically a warning that stack of a single function is big = enough to reach past the Guard Page and ensures it will be accessed. Yao, I just realized there already is Stack protection code in edk2, I was = only aware of Heap protection. Wouldn't a proper implementation make sense now to maybe not expand the stack, but at least runtime-error? Regards, Marvin > -----Original Message----- > From: Tim Lewis > Sent: Wednesday, May 9, 2018 3:28 AM > To: 'Yao, Jiewen' ; Marvin.Haeuser@outlook.com;=20 > edk2-devel@lists.01.org > Subject: RE: [edk2] [PATCH] MdePkg/BaseLib: Globally include ChkStk.c >=20 > I think that this is a fatal error in EDK2. It basically says, "we are = > out of stack space." The alternative is: the system hangs in an=20 > unexpected way since the stack overflows into other pages. >=20 > Tim >=20 > -----Original Message----- > From: edk2-devel On Behalf Of Yao,=20 > Jiewen > Sent: Tuesday, May 8, 2018 5:25 PM > To: Marvin.Haeuser@outlook.com; edk2-devel@lists.01.org > Subject: Re: [edk2] [PATCH] MdePkg/BaseLib: Globally include ChkStk.c >=20 > We discussed internally in Intel. >=20 > The quick workaround is: use /Gs65536. :-) >=20 > At the same time, our recommendation is to revisit the code which=20 > triggers this error. Why this function need such a big stack? And try=20 > to reduce the local stack usage. >=20 > What is why we still use /Gs32768 as default, instead of /Gs65536. >=20 > Thank you > Yao Jiewen >=20 >=20 > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf=20 > > Of Marvin H?user > > Sent: Tuesday, May 8, 2018 5:21 PM > > To: edk2-devel@lists.01.org > > Cc: Yao, Jiewen > > Subject: Re: [edk2] [PATCH] MdePkg/BaseLib: Globally include=20 > > ChkStk.c > > > > Oh, if you are prefering a good implementation, I will be all for=20 > > that. This was just a 'quick workaround', same as currently done for GCC. > > I'm actually unsure whether a good implementation is possible with a = > > flat memory model. It will likely be mere luck whether there is=20 > > enough space free below the stack, except for maybe when it's=20 > > located very high (preferably past the 32-bit space). > > Has there been any prior discussion on this topic? Would be=20 > > interested to follow up if there was. > > > > Thanks, > > Marvin > > > > > -----Original Message----- > > > From: Yao, Jiewen > > > Sent: Wednesday, May 9, 2018 2:13 AM > > > To: Marvin.Haeuser@outlook.com; edk2-devel@lists.01.org > > > Cc: Gao, Liming > > > Subject: RE: [PATCH] MdePkg/BaseLib: Globally include ChkStk.c > > > > > > There are some open source implementation: > > > MSVC: https://github.com/ispc/ispc/issues/542 > > > GCC: > > > > https://android.googlesource.com/toolchain/gcc/+/b094d6c4bf572654a03 > > > 1e cc4afe675154c886dc5/gcc-4.4.3/gcc/config/i386/chkstk.asm > > > > > > The compiler generated code assumes the stack is enlarged after we = > > > can chkstk. > > > > > > I agree empty function can make build pass. > > > But more important, we need make it work if there is a need to=20 > > > increase the stack. > > > The potential issue is that the later code (after chkstk) assumes=20 > > > the stack is increased, but actually it is not. > > > > > > That is why I ask how this is validated. > > > > > > Thank you > > > Yao Jiewen > > > > > > > > > > -----Original Message----- > > > > From: Marvin H=E4user [mailto:Marvin.Haeuser@outlook.com] > > > > Sent: Tuesday, May 8, 2018 4:58 PM > > > > To: edk2-devel@lists.01.org > > > > Cc: Yao, Jiewen ; Gao, Liming=20 > > > > > > > > Subject: RE: [PATCH] MdePkg/BaseLib: Globally include ChkStk.c > > > > > > > > Hey Yao, > > > > > > > > As far as I am aware, all __chkstk does is access the stack in 4 = > > > > KB intervals from the current location to the maximum requested=20 > > > > location to eventually hit the Windows Guard Page, which then=20 > > > > triggers the stack > > > increase. > > > > Because I do not know of any equivalent concept in edk2 and the=20 > > > > intrinsic was already disabled for GCC, I supposed it was a good = > > > > idea to do so globally. Are the potential issues I am not aware = of? > > > > > > > > Thanks, > > > > Marvin. > > > > > > > > > -----Original Message----- > > > > > From: Yao, Jiewen > > > > > Sent: Wednesday, May 9, 2018 1:52 AM > > > > > To: Marvin.Haeuser@outlook.com; edk2-devel@lists.01.org > > > > > Cc: Gao, Liming > > > > > Subject: RE: [PATCH] MdePkg/BaseLib: Globally include ChkStk.c > > > > > > > > > > HI Marvin > > > > > Would you mind to share the information on how you test this > update? > > > > > > > > > > > > > > > Per my experience, chkstk not only does the check but also=20 > > > > > does the real work to allocate more stack. > > > > > > > > > > /Gs can be used to indicate the size (/Gs[num] control stack=20 > > > > > checking calls) > > > > > > > > > > We use /Gs32768 by default, see tools_def.txt. > > > > > > > > > > Usually, we just increase this value to override the default=20 > > > > > one, if we hit this issue. > > > > > > > > > > Thank you > > > > > Yao Jiewen > > > > > > > > > > > -----Original Message----- > > > > > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On = > > > > > > Behalf Of Marvin H?user > > > > > > Sent: Tuesday, May 8, 2018 4:37 PM > > > > > > To: edk2-devel@lists.01.org > > > > > > Cc: Gao, Liming > > > > > > Subject: Re: [edk2] [PATCH] MdePkg/BaseLib: Globally include = > > > > > > ChkStk.c > > > > > > > > > > > > Hey Liming, > > > > > > > > > > > > According to the MSDN documentation, the call will be=20 > > > > > > inserted for a stack usage past a defined threshold - 4 KB=20 > > > > > > for IA32, 8 KB for X64 > > > (source: > > > > > > https://msdn.microsoft.com/en- > us/library/ms648426(v=3Dvs.85).aspx). > > > > > > > > > > > > Thanks, > > > > > > Marvin > > > > > > > > > > > > > -----Urspr=FCngliche Nachricht----- > > > > > > > Von: Gao, Liming > > > > > > > Gesendet: Montag, 7. Mai 2018 14:16 > > > > > > > An: Marvin.Haeuser@outlook.com; edk2-devel@lists.01.org > > > > > > > Cc: Kinney, Michael D > > > > > > > Betreff: RE: [PATCH] MdePkg/BaseLib: Globally include=20 > > > > > > > ChkStk.c > > > > > > > > > > > > > > Marvin: > > > > > > > In VS compiler, what case will trig this intrinsic = function? > > > > > > > > > > > > > > Thanks > > > > > > > Liming > > > > > > > > -----Original Message----- > > > > > > > > From: edk2-devel=20 > > > > > > > > [mailto:edk2-devel-bounces@lists.01.org] > > > > > > > > On Behalf Of Marvin H?user > > > > > > > > Sent: Saturday, May 5, 2018 10:25 PM > > > > > > > > To: edk2-devel@lists.01.org > > > > > > > > Cc: Kinney, Michael D ; Gao, = > > > > > > > > Liming > > > > > > > > Subject: [edk2] [PATCH] MdePkg/BaseLib: Globally include = > > > > > > > > ChkStk.c > > > > > > > > > > > > > > > > Initially added for GCC build support, this patch=20 > > > > > > > > includes the function for all compilers and all=20 > > > > > > > > architectures. This is done as huge variables on the=20 > > > > > > > > stack may cause the generation of calls to this=20 > > > > > > > > intrinsic function for Microsoft compilers, even for the IA32 architecture, too. > > > > > > > > > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > > > > > Signed-off-by: Marvin Haeuser > > > > > > > > > --- > > > > > > > > MdePkg/Library/BaseLib/{ChkStkGcc.c =3D> ChkStk.c} | 48 > > > > > > > > ++++++++++------ > > > > > > > ---- > > > > > > > > MdePkg/Library/BaseLib/BaseLib.inf | 4 = +- > > > > > > > > 2 files changed, 26 insertions(+), 26 deletions(-) > > > > > > > > > > > > > > > > diff --git a/MdePkg/Library/BaseLib/ChkStkGcc.c > > > > > > > > b/MdePkg/Library/BaseLib/ChkStk.c similarity index 74%=20 > > > > > > > > rename from MdePkg/Library/BaseLib/ChkStkGcc.c > > > > > > > > rename to MdePkg/Library/BaseLib/ChkStk.c index > > > > > > > > ecba3853b159..59e6d73f9331 100644 > > > > > > > > --- a/MdePkg/Library/BaseLib/ChkStkGcc.c > > > > > > > > +++ b/MdePkg/Library/BaseLib/ChkStk.c > > > > > > > > @@ -1,24 +1,24 @@ > > > > > > > > -/** @file > > > > > > > > - Provides hack function for passng GCC build. > > > > > > > > - > > > > > > > > - Copyright (c) 2006 - 2008, Intel Corporation. All=20 > > > > > > > > rights reserved.
> > > > > > > > - This program and the accompanying materials > > > > > > > > - are licensed and made available under the terms and=20 > > > > > > > > conditions of the BSD License > > > > > > > > - which accompanies this distribution. The full text=20 > > > > > > > > of the license may be found at > > > > > > > > - http://opensource.org/licenses/bsd-license.php. > > > > > > > > - > > > > > > > > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON > AN > > > "AS > > > > > IS" > > > > > > > > BASIS, > > > > > > > > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, > > > EITHER > > > > > > > EXPRESS OR IMPLIED. > > > > > > > > - > > > > > > > > -**/ > > > > > > > > - > > > > > > > > -#include "BaseLibInternals.h" > > > > > > > > - > > > > > > > > -/** > > > > > > > > - Hack function for passing GCC build. > > > > > > > > -**/ > > > > > > > > -VOID > > > > > > > > -__chkstk() > > > > > > > > -{ > > > > > > > > -} > > > > > > > > - > > > > > > > > +/** @file > > > > > > > > + Provides hack function for passing build. > > > > > > > > + > > > > > > > > + Copyright (c) 2006 - 2018, Intel Corporation. All=20 > > > > > > > > + rights reserved.
This program and the=20 > > > > > > > > + accompanying materials are licensed and made available = > > > > > > > > + under the terms and conditions of the BSD License =20 > > > > > > > > + which accompanies this distribution. The full text of = > > > > > > > > + the license may be found at > > > > > > > > + http://opensource.org/licenses/bsd- > > > > > > > license.php. > > > > > > > > + > > > > > > > > + THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON > AN > > > "AS > > > > > IS" > > > > > > > > + BASIS, WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY > > > KIND, > > > > > > > EITHER EXPRESS OR IMPLIED. > > > > > > > > + > > > > > > > > +**/ > > > > > > > > + > > > > > > > > +#include "BaseLibInternals.h" > > > > > > > > + > > > > > > > > +/** > > > > > > > > + Hack function for passing build. > > > > > > > > +**/ > > > > > > > > +VOID > > > > > > > > +__chkstk() > > > > > > > > +{ > > > > > > > > +} > > > > > > > > + > > > > > > > > diff --git a/MdePkg/Library/BaseLib/BaseLib.inf > > > > > > > > b/MdePkg/Library/BaseLib/BaseLib.inf > > > > > > > > index 5fbbd02a94b6..d23a6db2581a 100644 > > > > > > > > --- a/MdePkg/Library/BaseLib/BaseLib.inf > > > > > > > > +++ b/MdePkg/Library/BaseLib/BaseLib.inf > > > > > > > > @@ -1,7 +1,7 @@ > > > > > > > > ## @file > > > > > > > > # Base Library implementation. > > > > > > > > # > > > > > > > > -# Copyright (c) 2007 - 2016, Intel Corporation. All=20 > > > > > > > > rights reserved.
> > > > > > > > +# Copyright (c) 2007 - 2018, Intel Corporation. All=20 > > > > > > > > +rights reserved.
> > > > > > > > # Portions copyright (c) 2008 - 2009, Apple Inc. All=20 > > > > > > > > rights reserved.
# Portions copyright (c) 2011 -=20 > > > > > > > > 2013, > ARM Ltd. > > > > > > > > All rights reserved.
# @@ -64,6 +64,7 @@ [Sources] > > > > > > > > SafeString.c > > > > > > > > String.c > > > > > > > > FilePaths.c > > > > > > > > + ChkStk.c > > > > > > > > BaseLibInternals.h > > > > > > > > > > > > > > > > [Sources.Ia32] > > > > > > > > @@ -781,7 +782,6 @@ [Sources.X64] > > > > > > > > X64/DisableCache.S | GCC > > > > > > > > X64/RdRand.nasm| GCC > > > > > > > > X64/RdRand.S | GCC > > > > > > > > - ChkStkGcc.c | GCC > > > > > > > > > > > > > > > > [Sources.IPF] > > > > > > > > Ipf/AccessGp.s > > > > > > > > -- > > > > > > > > 2.17.0.windows.1 > > > > > > > > > > > > > > > > _______________________________________________ > > > > > > > > edk2-devel mailing list > > > > > > > > edk2-devel@lists.01.org > > > > > > > > https://lists.01.org/mailman/listinfo/edk2-devel > > > > > > _______________________________________________ > > > > > > edk2-devel mailing list > > > > > > edk2-devel@lists.01.org > > > > > > https://lists.01.org/mailman/listinfo/edk2-devel > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel