From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 82AE3740032 for ; Fri, 13 Sep 2024 00:57:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=CB8hyrivsCu36aOYV0kRrDn6nFt2LMw5Oku6/F3/QBI=; c=relaxed/simple; d=groups.io; h=From:To:Cc:References:In-Reply-To:Subject:Date:Message-ID:MIME-Version:Thread-Index:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Transfer-Encoding:Content-Language; s=20240830; t=1726189072; v=1; x=1726448270; b=bUlZPQGSPqRm0lCa/VfMn6encdz59FhoyAfX1vxFAsC9grGG0C3EERx8MqH3jy0uFjlH6MSv RDneC8lES/f4/ti7OQiNkD5AzdUQhhYF6FSxiVkx2Eocf+pCCwS/UlG12aEVyIa9/o4FVsXDd3c HJ5dqSlETEpgQq6MswC4dwKIxJ4u/R+pKQfY0WZ/omvjlxZoXcD4kxnF7LugC8q/TtkDFKQcpm9 fBd22/hYve2DaKV/xsdXj1pEtEkX9SxG0CQwqqnn9uPv+nggv8z/vxMXz4ngX4wF9bRI1ctIMrs kiADbMEu651cNQkqFzUdaS+X+uCeAJfc/tYjvJ1bqkmGg== X-Received: by 127.0.0.2 with SMTP id 56P9YY7687511xx8LCVBE6xl; Thu, 12 Sep 2024 17:57:50 -0700 X-Received: from cxsh.intel-email.com (cxsh.intel-email.com [121.46.250.151]) by mx.groups.io with SMTP id smtpd.web10.63225.1726189069039531913 for ; Thu, 12 Sep 2024 17:57:50 -0700 X-Received: from cxsh.intel-email.com (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id C4FB4DDA7B7 for ; Fri, 13 Sep 2024 08:57:46 +0800 (CST) X-Received: from localhost (localhost [127.0.0.1]) by cxsh.intel-email.com (Postfix) with ESMTP id C026BDDA7B4 for ; Fri, 13 Sep 2024 08:57:46 +0800 (CST) X-Received: from mail.byosoft.com.cn (mail.byosoft.com.cn [58.240.74.242]) by cxsh.intel-email.com (Postfix) with SMTP id 1C90CDDA7B3 for ; Fri, 13 Sep 2024 08:57:42 +0800 (CST) X-Received: from DESKTOPS6D0PVI ([58.246.60.130]) (envelope-sender ) by 192.168.6.13 with ESMTP(SSL) for ; Fri, 13 Sep 2024 08:57:25 +0800 X-WM-Sender: gaoliming@byosoft.com.cn X-Originating-IP: 58.246.60.130 X-WM-AuthFlag: YES X-WM-AuthUser: gaoliming@byosoft.com.cn From: "gaoliming via groups.io" To: , Cc: "'Zhiguang Liu'" , "'Michael D Kinney'" , "'Chun-Yi Lee'" References: <20240912065209.12517-1-jlee@suse.com> In-Reply-To: <20240912065209.12517-1-jlee@suse.com> Subject: =?UTF-8?B?5Zue5aSNOiBbZWRrMi1kZXZlbF0gW1BBVENIXSBNZGVQa2cgRGVidWdMaWI6IEVuYWJsZSBGSUxFIE5BTUUgYXMgREVCVUcgQVNTRVJUIGZvciBHQ0MxMg==?= Date: Fri, 13 Sep 2024 08:57:26 +0800 Message-ID: <01ee01db0577$e7e763f0$b7b62bd0$@byosoft.com.cn> MIME-Version: 1.0 Thread-Index: AQJHSwieOO201tUq+8//xAr0n7mCHrF8WZpw Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 12 Sep 2024 17:57:50 -0700 Resent-From: gaoliming@byosoft.com.cn Reply-To: devel@edk2.groups.io,gaoliming@byosoft.com.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: iOv2yrTXemmU8p2f9GT6HKBlx7686176AA= Content-Type: text/plain; charset="gb2312" Content-Transfer-Encoding: quoted-printable Content-Language: zh-cn X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=bUlZPQGS; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Please submit it in Github Edk2 as pull request. I agree this is a good change.=20 > -----=D3=CA=BC=FE=D4=AD=BC=FE----- > =B7=A2=BC=FE=C8=CB: devel@edk2.groups.io =B4=FA=B1= =ED Chun-Yi Lee > =B7=A2=CB=CD=CA=B1=BC=E4: 2024=C4=EA9=D4=C212=C8=D5 14:52 > =CA=D5=BC=FE=C8=CB: devel@edk2.groups.io > =B3=AD=CB=CD: Zhiguang Liu ; Michael D Kinney > ; Chun-Yi Lee > =D6=F7=CC=E2: [edk2-devel] [PATCH] MdePkg DebugLib: Enable FILE NAME as D= EBUG > ASSERT for GCC12 >=20 > Using __FILE_NAME__ is useful for reducing the size of debug image and > it's also good for reproducable builds. The gcc-12 also supported this > macro. >=20 > Ref: > https://gcc.gnu.org/git/gitweb.cgi?p=3Dgcc.git;h=3D1a9b3f04c11eb467a8dc50= 4a3 > 7dad57a371a0d4c >=20 > This patch removed the checking of __clang__ when using __FILE_NAME__. >=20 > Cc: Zhiguang Liu > Cc: Michael D Kinney > Signed-off-by: Chun-Yi Lee > --- > MdePkg/Include/Library/DebugLib.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/MdePkg/Include/Library/DebugLib.h > b/MdePkg/Include/Library/DebugLib.h > index 0db3b78e..fc5c8346 100644 > --- a/MdePkg/Include/Library/DebugLib.h > +++ b/MdePkg/Include/Library/DebugLib.h > @@ -342,13 +342,13 @@ UnitTestDebugAssert ( > #if defined (_ASSERT) > #undef _ASSERT > #endif > - #if defined (__clang__) && defined (__FILE_NAME__) > + #if defined (__FILE_NAME__) > #define _ASSERT(Expression) UnitTestDebugAssert (__FILE_NAME__, > DEBUG_LINE_NUMBER, DEBUG_EXPRESSION_STRING (Expression)) > #else > #define _ASSERT(Expression) UnitTestDebugAssert (__FILE__, > DEBUG_LINE_NUMBER, DEBUG_EXPRESSION_STRING (Expression)) > #endif > #else > - #if defined (__clang__) && defined (__FILE_NAME__) > + #if defined (__FILE_NAME__) > #define _ASSERT(Expression) DebugAssert (__FILE_NAME__, > DEBUG_LINE_NUMBER, DEBUG_EXPRESSION_STRING (Expression)) > #else > #define _ASSERT(Expression) DebugAssert (__FILE__, > DEBUG_LINE_NUMBER, DEBUG_EXPRESSION_STRING (Expression)) > -- > 2.35.3 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120560): https://edk2.groups.io/g/devel/message/120560 Mute This Topic: https://groups.io/mt/108424554/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-