From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web08.4408.1665395303058626451
 for <devel@edk2.groups.io>;
 Mon, 10 Oct 2022 02:48:23 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id D42421480;
	Mon, 10 Oct 2022 02:48:28 -0700 (PDT)
Received: from [192.168.1.11] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C5C163F792;
	Mon, 10 Oct 2022 02:48:21 -0700 (PDT)
Message-ID: <0203add0-9124-adde-48db-7fafb19f2b08@arm.com>
Date: Mon, 10 Oct 2022 11:48:16 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.11.0
Subject: Re: [edk2-devel] [PATCH 14/14] ShellPkg/AcpiView: Update PCCT fields for ACPI 6.5
To: devel@edk2.groups.io
Cc: Sami Mujawar <sami.mujawar@arm.com>,
 Alexei Fedorov <Alexei.Fedorov@arm.com>, ray.ni@intel.com,
 zhichao.gao@intel.com
References: <20221010092058.118714-1-Pierre.Gondois@arm.com>
 <171CAABD595C9750.32766@groups.io>
From: "PierreGondois" <pierre.gondois@arm.com>
In-Reply-To: <171CAABD595C9750.32766@groups.io>
Content-Language: en-US
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

+ Ray Ni
+ Zhichao Gao

as the patch wasn't sent to them.

On 10/10/22 11:20, PierreGondois via groups.io wrote:
> From: Pierre Gondois <pierre.gondois@arm.com>
> 
> The ACPI specification updated some terms in accordance with:
> s1.1.1 Principle of Inclusive Terminology
> 
> Update the PCCT parser accordincly with these new terms.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Pierre Gondois <Pierre.Gondois@arm.com>
> ---
>   .../UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c   | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c
> index 8cffdaaf0716..8ad39090afe3 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pcct/PcctParser.c
> @@ -146,7 +146,7 @@ ValidatePccDoorbellGas (
>     IN VOID   *Context
>     )
>   {
> -  // For slave subspaces this field is optional, if not present the field
> +  // For responder subspaces this field is optional, if not present the field
>     // should just contain zeros.
>     if (*PccSubspaceType == EFI_ACPI_6_4_PCCT_SUBSPACE_TYPE_4_EXTENDED_PCC) {
>       if (IsZeroBuffer (
> @@ -214,7 +214,7 @@ ValidatePccErrStatusGas (
>     IN VOID   *Context
>     )
>   {
> -  // This field is ignored by the OSPM on slave channels.
> +  // This field is ignored by the OSPM on responder channels.
>     if (*PccSubspaceType == EFI_ACPI_6_4_PCCT_SUBSPACE_TYPE_4_EXTENDED_PCC) {
>       return;
>     }
> @@ -237,7 +237,7 @@ ValidatePlatInterrupt (
>     IN VOID   *Context
>     )
>   {
> -  // If a slave subspace is present in the PCCT, then the global Platform
> +  // If a responder subspace is present in the PCCT, then the global Platform
>     // Interrupt flag must be set to 1.
>     if ((*PccSubspaceType == EFI_ACPI_6_4_PCCT_SUBSPACE_TYPE_4_EXTENDED_PCC) &&
>         ((*PccGlobalFlags & EFI_ACPI_6_4_PCCT_FLAGS_PLATFORM_INTERRUPT) !=